diff options
-rw-r--r-- | ChangeLog | 5 | ||||
-rw-r--r-- | io.c | 14 | ||||
-rw-r--r-- | test/ruby/test_io.rb | 9 |
3 files changed, 21 insertions, 7 deletions
@@ -1,3 +1,8 @@ +Thu Oct 15 14:57:58 2009 Nobuyoshi Nakada <nobu@ruby-lang.org> + + * io.c (io_reopen): unread current buffer before telling the + position, for the case of reopening same file. [ruby-dev:39479] + Thu Oct 15 14:20:58 2009 Nobuyoshi Nakada <nobu@ruby-lang.org> * ext/iconv/iconv.c (iconv_create): cannot retry with given block. @@ -5654,13 +5654,6 @@ io_reopen(VALUE io, VALUE nfile) rb_io_fmode_modestr(orig->mode)); } } - if (orig->mode & FMODE_READABLE) { - pos = io_tell(orig); - } - if (orig->mode & FMODE_WRITABLE) { - if (io_fflush(orig) < 0) - rb_sys_fail(0); - } if (fptr->mode & FMODE_WRITABLE) { if (io_fflush(fptr) < 0) rb_sys_fail(0); @@ -5668,6 +5661,13 @@ io_reopen(VALUE io, VALUE nfile) else { io_tell(fptr); } + if (orig->mode & FMODE_READABLE) { + pos = io_tell(orig); + } + if (orig->mode & FMODE_WRITABLE) { + if (io_fflush(orig) < 0) + rb_sys_fail(0); + } /* copy rb_io_t structure */ fptr->mode = orig->mode | (fptr->mode & FMODE_PREP); diff --git a/test/ruby/test_io.rb b/test/ruby/test_io.rb index 8b1714b01e..71f31e37a3 100644 --- a/test/ruby/test_io.rb +++ b/test/ruby/test_io.rb @@ -1286,6 +1286,15 @@ class TestIO < Test::Unit::TestCase assert_equal("bar\n", f.gets, '[ruby-core:24240]') } end + + open(__FILE__) do |f| + f2 = open(t.path) + f.reopen(f2) + assert_equal("foo\n", f.gets) + assert_equal("bar\n", f.gets) + f.reopen(f2) + assert_equal("baz\n", f.gets, '[ruby-dev:39479]') + end end def test_foreach |