| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
Fixing typo. It seems I failed to press the shift key.
|
| |
|
| |
|
|
|
|
| |
[Bug #16167]
|
| |
|
|
|
|
|
|
| |
Parents commit hashs in logs of merge commits are abbreviated to
necessary length depending on the repositories. Exclude merge
commits from ChangeLog to make it stable.
|
| |
|
|
|
|
|
|
| |
This should only happen if the API is misused. It's much better
to warn here and fix the problem, versus to try to debug TypeErrors
or segfaults later.
|
| |
|
| |
|
|
|
|
|
| |
Just exporting may not imply exporting ChangeLog which needs
notes/commits. [Bug #16167]
|
|
|
|
|
|
| |
Enters raw-mode but enable interrupts.
https://github.com/ruby/io-console/commit/7cba76561a
|
|
|
|
|
| |
To prevent the `v` reference from being eliminated before argv is used,
calling `rb_free_tmp_buffer` against `v` explicitly.
|
|
|
|
| |
Needs another room to append an empty hash.
|
| |
|
|
|
|
|
|
|
| |
nagachika pointed out that ALLOC_N is actually just malloc, so
this memory wasn't being freed. This shouldn't be a performance
sensitive code path, and will be going away after 2.7, so just
allocate a temp buffer that will be freed later by Ruby GC.
|
|
|
|
|
|
|
|
|
|
|
| |
It is not safe to set this in C functions that can be called from
other C functions, as in the non argument-delegation case, you
can end up calling a Ruby method with a flag indicating keywords
are set without passing keywords.
Introduce some new *_kw functions that take a kw_splat flag and
use these functions to set RB_PASS_CALLED_KEYWORDS in places where
we know we are delegating methods (e.g. Class#new, Method#call)
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Remove rb_add_empty_keyword, and instead of calling that every
place you need to add empty keyword hashes, run that code in
a single static function in vm_eval.c.
Add 4 defines to include/ruby/ruby.h, these are to be used as
int kw_splat values when calling the various rb_*_kw functions:
RB_NO_KEYWORDS :: Do not pass keywords
RB_PASS_KEYWORDS :: Pass final argument (which should be hash) as keywords
RB_PASS_EMPTY_KEYWORDS :: Add an empty hash to arguments and pass as keywords
RB_PASS_CALLED_KEYWORDS :: Passes same keyword type as current method was
called with (for method delegation)
rb_empty_keyword_given_p needs to stay. It is required if argument
delegation is done but delayed to a later point, which Enumerator
does.
Use RB_PASS_CALLED_KEYWORDS in rb_call_super to correctly
delegate keyword arguments to super method.
|
|
|
|
|
|
|
|
|
| |
This sets the correct VM frame flags when using Method#call to
call funcs, and handles empty keyword hashes for cfuncs,
attr_reader, and attr_writer. It also fixes calls to send through
Method#call. It adds tests for all of those, as well as tests for
using Method#call to call define_method, lambda, and sym_procs
(which didn't require code changes).
|
| |
|
| |
|
|
|
|
| |
This reverts commit 805b0a481132938638dbd32830cf5dca3910efb1.
|
|
|
|
| |
This reverts commit 685f12bbca50ff9b7a16b3016b3b8b3f2ac8b796.
|
|
|
|
| |
This reverts commit 6d9e54816f828983bcf383ce6fce287bd3ca05b9.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
RubyVM::InstructionSequence.to_binary generates a bytecode binary
representation. To check compatibility with binary and loading
MRI we prepared major/minor version and compare them at loading
time. However, development version of MRI can change this format
but we can not increment minor version to make them consistent
with Ruby's major/minor versions.
To solve this issue, we introduce new minor version scheme
(binary's minor_version = ruby's minor * 10000 + dev ver)
and we can check incompatibility with older dev version.
|
| |
|
| |
|
|
|
|
| |
Fixed new Struct-related keyword argument warnings
|
|
|
|
| |
Co-authored-by: Victor Shepelev <zverok.offline@gmail.com>
|
| |
|
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We are seeing SEGVs in CI:
http://ci.rvm.jp/results/trunk-gc-asserts@ruby-sky1/2253563
This is happening because Ripper constructs AST nodes differently than
parse.y normally does. Specifically in this case Ripper is assigning 3
`VALUE` objects:
https://github.com/ruby/ruby/blob/1febb6f4a14f7222c6d30250bfdc252d34238187/parse.y#L757-L761
Where parse.y will normally assign other things:
https://github.com/ruby/ruby/blob/1febb6f4a14f7222c6d30250bfdc252d34238187/parse.y#L11258-L11260
The important one is the last one, the `struct rb_ary_pattern_info`. The
mark function assumed that `NODE_ARYPTN` have a pointer to `struct
rb_ary_pattern_info`, and used it:
https://github.com/ruby/ruby/blob/1febb6f4a14f7222c6d30250bfdc252d34238187/node.c#L1269-L1274
In the case of Ripper, `NODE_ARYPTN` doesn't point to an
`rb_ary_pattern_info`, so the mark function would SEGV. This commit
changes Ripper so that its `NODE_ARYPTN` nodes also point at an
`rb_ary_pattern_info`, and the mark function can continue with the same
assumption.
|
|
|
|
|
|
|
|
| |
Previously, calling transform_values would call rb_hash_aset for each
key, needing to rehash it and look up its location.
Instead, we can use rb_hash_stlike_foreach_with_replace to replace the
values as we iterate without rehashing the keys.
|
| |
|
| |
|
|
|
|
|
|
|
|
|
| |
Previously, the warning functions skipped warning in these cases.
This removes the skipping, and uses a less descriptive warning
instead.
This affected both last argument to keyword warnings and keyword
split warnings.
|
| |
|
| |
|
| |
|
|
|
|
| |
See also https://travis-ci.org/ruby/ruby/jobs/583031687#L1874
|
|
|
|
|
| |
https://docs.aws.amazon.com/cli/latest/reference/s3/sync.html
> --no-progress (boolean) File transfer progress is not displayed. This flag is only applied when the quiet and only-show-errors flags are not provided.
|
|
|
|
|
|
| |
Macros can't be expressions, that is a GNU extension (I didn't know
that). This commit converts the macro to a function so that everything
will compile correctly on non-GNU compatible compilers.
|
| |
|
| |
|
|
|
|
| |
Fixes a test in RubySpec
|
|
|
|
| |
https://github.com/ruby/io-console/commit/4e17c90788
|
|
|
|
|
|
| |
About unused variables and a function.
https://github.com/ruby/io-console/commit/32baf54e7a
|