aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* [rubygems/rubygems] Only add .rubocop.yml when --rubocop flag is passedUtkarsh Gupta2020-06-182-8/+0
| | | | | | Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/ef2dae4222
* Ship default .rubocop.ymlUtkarsh Gupta2020-06-183-0/+15
| | | | | | | | | | | Currently, there is no `.rubocop.yml` shipped by default. So when a user runs `rubocop` after creating a new gem via `bundle gem foo`, it throws a bunch of offenses. With the default `.rubocop.yml` present, the number of those offenses significantly reduce by 25. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
* [rubygems/rubygems] Only add .rubocop.yml when --rubocop flag is passedUtkarsh Gupta2020-06-182-0/+9
| | | | | | Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/ef2dae4222
* Rename hidden templatesDavid Rodríguez2020-06-185-4/+4
| | | | | | | Because they don't play nice with ruby-core's gitignore and cause issues with ruby-core integration. Also, because it's consistent with other templates such as `gitignore.tt`.
* Undeprecate the `--no-cache` flagDavid Rodríguez2020-06-182-2/+1
| | | | | This is not a remembered option, so it shouldn't have been deprecated. At least not for that reason.
* Removed the old file with https://github.com/rubygems/rubygems/pull/3667Hiroshi SHIBATA2020-06-181-6/+0
|
* s/sys_exec!/sys_execDavid Rodríguez2020-06-187-14/+14
|
* [rubygems/rubygems] Remove now unused "bang helpers"David Rodríguez2020-06-181-12/+0
| | | | https://github.com/rubygems/rubygems/commit/84e4c58e83
* [rubygems/rubygems] s/run!/runDavid Rodríguez2020-06-1813-33/+33
| | | | https://github.com/rubygems/rubygems/commit/e3f60d8aec
* [rubygems/rubygems] s/ruby!/rubyDavid Rodríguez2020-06-186-24/+24
| | | | https://github.com/rubygems/rubygems/commit/a73fa0760e
* [rubygems/rubygems] s/gem_command!/gem_commandDavid Rodríguez2020-06-185-11/+11
| | | | https://github.com/rubygems/rubygems/commit/f52733f6a4
* [rubygems/rubygems] s/install_gemfile!/install_gemfileDavid Rodríguez2020-06-1845-159/+159
| | | | https://github.com/rubygems/rubygems/commit/4d1a0c465a
* [rubygems/rubygems] s/bundle!/bundleDavid Rodríguez2020-06-1865-659/+659
| | | | https://github.com/rubygems/rubygems/commit/746a4b3d74
* Generalize CI templatesFrank Lam2020-06-183-5/+5
|
* Use consistent filenaming for Travis templateFrank Lam2020-06-182-1/+7
|
* Update github workflow templateFrank Lam2020-06-181-3/+3
| | | | * https://github.com/ruby/setup-ruby is now the more recommended action
* Update CI templatesFrank Lam2020-06-182-4/+4
| | | | | * Next version of Bundler will auto choose jobs by default * --retry 3 is already default
* [rubygems/rubygems] Prefer using bundle! to avoid unnecessary swallowing of ↵Frank Lam2020-06-181-26/+26
| | | | | | errors https://github.com/rubygems/rubygems/commit/6bac832a58
* [rubygems/rubygems] Fix nonexistent constant in CircleCI templateFrank Lam2020-06-181-1/+1
| | | | | Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> https://github.com/rubygems/rubygems/commit/851f8afad1
* [rubygems/rubygems] Move already configured --test hint to before test file ↵Frank Lam2020-06-182-11/+6
| | | | | | creation https://github.com/rubygems/rubygems/commit/9e5f7a9099
* [rubygems/rubygems] Move already configured --ci hint to before CI file creationFrank Lam2020-06-182-11/+6
| | | | https://github.com/rubygems/rubygems/commit/2af2abe5fd
* [rubygems/rubygems] Lower verboseness of user-facing text for bundle gemFrank Lam2020-06-182-9/+6
| | | | https://github.com/rubygems/rubygems/commit/288f073c3c
* [rubygems/rubygems] Fix --ci flag manpage documentationFrank Lam2020-06-183-3/+3
| | | | https://github.com/rubygems/rubygems/commit/515effe8de
* [rubygems/rubygems] Rebuild man pages for bundle gemFrank Lam2020-06-183-2/+49
| | | | https://github.com/rubygems/rubygems/commit/b5a9cec1be
* [rubygems/rubygems] Make test framework/CI configuration for bundle gem ↵Frank Lam2020-06-183-11/+70
| | | | | | | | consistent * Add hints for --ci option https://github.com/rubygems/rubygems/commit/5f779f45b0
* [rubygems/rubygems] Remove extra whitespaceFrank Lam2020-06-181-1/+1
| | | | https://github.com/rubygems/rubygems/commit/9986cd01fc
* [rubygems/rubygems] Set CI global config to false in gem_helper_specFrank Lam2020-06-181-1/+1
| | | | https://github.com/rubygems/rubygems/commit/39b18fe7fc
* [rubygems/rubygems] Fix CI spec typoFrank Lam2020-06-181-1/+1
| | | | | Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com> https://github.com/rubygems/rubygems/commit/24f3739585
* [rubygems/rubygems] Incorporate naming/grammar suggestions from olleolleolleFrank Lam2020-06-183-14/+14
| | | | https://github.com/rubygems/rubygems/commit/80571452ca
* [rubygems/rubygems] Move CI specs below test framework specsFrank Lam2020-06-181-79/+79
| | | | https://github.com/rubygems/rubygems/commit/d8e416d89b
* [rubygems/rubygems] Remove shared examples for present test frameworkFrank Lam2020-06-181-22/+0
| | | | | | * `bundle gem` has new option to select CI provider https://github.com/rubygems/rubygems/commit/320f3546c1
* [rubygems/rubygems] Separate CI and test framework shared examplesFrank Lam2020-06-181-4/+0
| | | | | | * `bundle gem` has new option to choose CI provider other than Travis CI https://github.com/rubygems/rubygems/commit/afaecf16de
* [rubygems/rubygems] Extract shared example for absence of CI filesFrank Lam2020-06-181-0/+9
| | | | https://github.com/rubygems/rubygems/commit/22cb599bcc
* [rubygems/rubygems] minor language tweaks, small code refactorAndre Arko2020-06-181-27/+20
| | | | https://github.com/rubygems/rubygems/commit/84e9f3711c
* [rubygems/rubygems] update question textColby Swandale2020-06-181-1/+1
| | | | https://github.com/rubygems/rubygems/commit/f14c8a5ec2
* Manually cherry-picked at ↵Hiroshi SHIBATA2020-06-186-4/+189
| | | | https://github.com/rubygems/rubygems/commit/80260b3496e357bf96ffe6f381e29bf25b6749cb
* [rubygems/rubygems] Remove unnecessary `bundle install`David Rodríguez2020-06-181-1/+1
| | | | | | | These specs doesn't really need an installed bundle, they only need a `Gemfile`. https://github.com/rubygems/rubygems/commit/06c85683ae
* [rubygems/rubygems] Make helpers raise by defaultDavid Rodríguez2020-06-1861-390/+378
| | | | https://github.com/rubygems/rubygems/commit/ade0c441d5
* [rubygems/rubygems] Fix a couple of specs that were loading an incorrect bundlerDavid Rodríguez2020-06-182-2/+2
| | | | | | | | | | | We have a check on an `at_exit` hook that checks that system bundler is never loaded instead of our development copy. The check was failing in these cases, but in a silent way because the errors were being swallowed. This commit changes these specs to make sure they load the right bundler. https://github.com/rubygems/rubygems/commit/cd1c1bc297
* [rubygems/rubygems] Change spec to do the right thing on bundler 3David Rodríguez2020-06-181-2/+2
| | | | | | | | | | | | | | On bundler 3, the `--deployment` flag doesn't exist, so the `bundle install --deployment` command was failing silently and the spec was verifying a different scenario. Change the spec to work the same regardless of bundler's major version. Also, from the spec description it was not apparently that a specific case involving deployment mode was being tested, so I reworded it to make it more apparent. https://github.com/rubygems/rubygems/commit/3e33e2b927
* [rubygems/rubygems] Fix some sudo specs to do the right thing on bundler 3David Rodríguez2020-06-181-3/+4
| | | | | | | | | | | | | | | On bundler 3, where the default install path is `.bundle`, these specs were trying to change permissions of the `.bundle/ruby/<ruby_abi_version>` folder, which didn't exist yet,so the permission changing command was failing and the spec was not testing the right thing. Change the specs so that the permissions are correctly changed, by first configuring the local path to be `.bundle` (which creates the `.bundle` folder), and then changing permissions of the `.bundle` folder explicitly, which exists already. https://github.com/rubygems/rubygems/commit/2833162fb0
* [rubygems/rubygems] Fix spec to test the right thing on bundler 3David Rodríguez2020-06-181-1/+1
| | | | | | | | | | Bundler 3 installs by default to `.bundle`. That means that, because the `bar` gem was not previously available at this location but as a system gem, the initial `bundle install` was silently failing. As a consequence, the spec was not testing the exact scenario it meant to test. https://github.com/rubygems/rubygems/commit/202399521c
* [rubygems/rubygems] Remove bad `bundle install`David Rodríguez2020-06-181-1/+1
| | | | | | | | | This spec is specifically testing for the case where there's no `Gemfile.lock` file and it's only doing the expected thing because the `bundle install` command is silently failing. Remove the `bundle install` to reduce confusion. https://github.com/rubygems/rubygems/commit/ec39fbde0e
* [rubygems/rubygems] Simplify `bundle update --ruby` specsDavid Rodríguez2020-06-181-5/+4
| | | | | | | They don't need to run that many commands, and the new version is also more readable in my opinion. https://github.com/rubygems/rubygems/commit/efff3e3210
* [rubygems/rubygems] Fix redundant commandsDavid Rodríguez2020-06-181-2/+0
| | | | | | | They are preceded by `install_gemfile` calls, which mean `bundle install` is being run twice for no reason. https://github.com/rubygems/rubygems/commit/d2b2d10862
* [rubygems/rubygems] Fix unintended Gemfile installationDavid Rodríguez2020-06-181-1/+1
| | | | | | | | | | This command is failing because of the same reason that the subsequent `bundle exec` is failing: the gemspec is invalid. The `bundle install` here deviates the `bundle exec` focus from the test and is unnecessary: all we need is a `Gemfile` that will trigger the `bundle exec`, so let's create and avoid the extra command. https://github.com/rubygems/rubygems/commit/eb83cf6cf1
* [rubygems/rubygems] Remove failing command that doesn't affect the specDavid Rodríguez2020-06-181-4/+0
| | | | | | | This command was silently failing but doesn't really affect the outcome of the spec. https://github.com/rubygems/rubygems/commit/7880d08146
* [rubygems/rubygems] Remove broken testDavid Rodríguez2020-06-181-15/+0
| | | | | | | | | | | | | | | | | | | | | It turns out that this test is checking essentially nothing useful. The paperclip gem doesn't exist in our setup, so initial install is failing and the test is only checking that calling `bundle check` 3 times on a broken setup always returns the same thing. I went to the history of this test: * https://github.com/rubygems/bundler/commit/105654a31e07e9b0a198f1a5a5ec94e365854edf * https://github.com/rubygems/bundler/commit/ae53be1f8748bfc41bc6565dc4922a1c0ac80998 * https://github.com/rubygems/bundler/commit/d19f4a7b32ccf4ec4ecda5c7c0354adc81e1efb6 * https://github.com/rubygems/bundler/commit/092f169d01472336598e29b32550399991940d63 * https://github.com/rubygems/bundler/commit/36878435b5f0be75fc6f2e07cebd7f15aaddadf0 And have finally decided to remove it since I'm not sure changing it to something else will lead to testing something useful and not already tested. https://github.com/rubygems/rubygems/commit/6184322967
* [rubygems/rubygems] Fix silently broken specDavid Rodríguez2020-06-181-1/+5
| | | | | | | | | | This spec was broken. The second `bundle install` was silently failing. This means that the spec was actually checking an scenario completely different from the one that was supposed to be tested. And also a very dummy one: that running `bundle cache` twice doesn't cache a completely unrelated gem. https://github.com/rubygems/rubygems/commit/f11a5d2df9
* [rubygems/rubygems] Remove incorrect tagsDavid Rodríguez2020-06-181-4/+4
| | | | | | | The inner specs have separated specs for the `< 3` and `= 2` cases, so this outer tag is incorrect. https://github.com/rubygems/rubygems/commit/61e905ca27