aboutsummaryrefslogtreecommitdiffstats
path: root/compile.c
Commit message (Collapse)AuthorAgeFilesLines
* Use ID instead of GENTRY for gvars. (#3278)Koichi Sasada2020-07-031-46/+4
| | | | | | | | | | | | Use ID instead of GENTRY for gvars. Global variables are compiled into GENTRY (a pointer to struct rb_global_entry). This patch replace this GENTRY to ID and make the code simple. We need to search GENTRY from ID every time (st_lookup), so additional overhead will be introduced. However, the performance of accessing global variables is not important now a day and this simplicity helps Ractor development.
* compile_redo: fix wrong condition卜部昌平2020-06-291-1/+1
|
* ibf_dump_object_object: do not goto into a branch卜部昌平2020-06-291-8/+4
| | | | | I'm not necessarily against every goto in general, but jumping into a branch is definitely a bad idea. Better refactor.
* compile_call: do not goto into a branch卜部昌平2020-06-291-10/+9
| | | | | I'm not necessarily against every goto in general, but jumping into a branch is definitely a bad idea. Better refactor.
* compile_redo: do not goto into a branch卜部昌平2020-06-291-7/+3
| | | | | I'm not necessarily against every goto in general, but jumping into a branch is definitely a bad idea. Better refactor.
* compile_next: do not goto into a branch卜部昌平2020-06-291-6/+2
| | | | | I'm not necessarily against every goto in general, but jumping into a branch is definitely a bad idea. Better refactor.
* compile_break: do not goto into a branch卜部昌平2020-06-291-19/+15
| | | | | I'm not necessarily against every goto in general, but jumping into a branch is definitely a bad idea. Better refactor.
* compile_branch_condition: do not goto into a branch卜部昌平2020-06-291-10/+10
| | | | | I'm not necessarily against every goto in general, but jumping into a branch is definitely a bad idea. Better refactor.
* optimize_checktype: do not goto into a branch卜部昌平2020-06-291-2/+1
| | | | | I'm not necessarily against every goto in general, but jumping into a branch is definitely a bad idea. Better refactor.
* iseq_set_exception_table: do not goto into a branch卜部昌平2020-06-291-5/+2
| | | | | I'm not necessarily against every goto in general, but jumping into a branch is definitely a bad idea. Better refactor.
* Removed non-ASCII code to suppress warnings by localized compilersNobuyoshi Nakada2020-06-271-2/+2
|
* Cosmetic changeKazuki Tsujimoto2020-06-271-1/+2
|
* Add #deconstruct cache to find patternVladimir Dementyev2020-06-271-59/+65
|
* Optimize array pattern matching by caching #deconstruct valueVladimir Dementyev2020-06-271-16/+64
|
* Removed no longer used flagsNobuyoshi Nakada2020-06-271-2/+0
|
* Not to rewrite node while compilingNobuyoshi Nakada2020-06-271-9/+4
| | | | | | Moved this hack mark to an argument to `compile_hash`. > Bad Hack: temporarily mark hash node with flag so > compile_hash can compile call differently.
* Introduce Primitive.attr! to annotate 'inline' (#3242)Takashi Kokubun2020-06-201-0/+8
| | | [Feature #15589]
* compile.c: Improve branch coverage instrumentation [Bug #16967]Yusuke Endoh2020-06-201-23/+73
| | | | | | | | | | | | | | Formerly, branch coverage measurement counters are generated for each compilation traverse of the AST. However, ensure clause node is traversed twice; one is for normal-exit case (the resulted bytecode is embedded in its outer scope), and the other is for exceptional case (the resulted bytecode is used in catch table). Two branch coverage counters are generated for the two cases, but it is not desired. This changeset revamps the internal representation of branch coverage measurement. Branch coverage counters are generated only at the first visit of a branch node. Visiting the same node reuses the already-generated counter, so double counting is avoided.
* compile.c: pass NODE* instead of a quadruple of code locationYusuke Endoh2020-06-201-82/+37
|
* compile.c (branch_coverage_valid_p): Refactored outYusuke Endoh2020-06-201-8/+10
|
* compile.c: Use functions for building branch coverage instructionsYusuke Endoh2020-06-201-54/+65
| | | | instead of maros. Just refactoring.
* [Feature #16254] Allow `Primitive.func` styleNobuyoshi Nakada2020-06-191-3/+12
|
* [Feature #16254] Allow `__builtin.func` styleNobuyoshi Nakada2020-06-191-7/+18
|
* Dup splat array in certain cases where there is a block argumentJeremy Evans2020-06-181-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes: ```ruby args = [1, 2, -> {}]; foo(*args, &args.pop) ``` call `foo` with 1, 2, and the lambda, in addition to passing the lambda as a block. This is different from the previous behavior, which passed the lambda as a block but not as a regular argument, which goes against the expected left-to-right evaluation order. This is how Ruby already compiled arguments if using leading arguments, trailing arguments, or keywords in the same call. This works by disabling the optimization that skipped duplicating the array during the splat (splatarray instruction argument switches from false to true). In the above example, the splat call duplicates the array. I've tested and cases where a local variable or symbol are used do not duplicate the array, so I don't expect this to decrease the performance of most Ruby programs. However, programs such as: ```ruby foo(*args, &bar) ``` could see a decrease in performance, if `bar` is a method call and not a local variable. This is not a perfect solution, there are ways to get around this: ```ruby args = Struct.new(:a).new([:x, :y]) def args.to_a; a; end def args.to_proc; a.pop; ->{}; end foo(*args, &args) # calls foo with 1 argument (:x) # not 2 arguments (:x and :y) ``` A perfect solution would require completely disabling the optimization. Fixes [Bug #16504] Fixes [Bug #16500]
* Replaced accessors of `Struct` with `invokebuiltin`Nobuyoshi Nakada2020-06-171-9/+8
|
* Revert "Replaced accessors of `Struct` with `invokebuiltin`"Nobuyoshi Nakada2020-06-161-8/+9
| | | | | This reverts commit 19cabe8b09d92d033c244f32ff622b8e513375f1, which didn't support tool/lib/iseq_loader_checker.rb.
* Replaced accessors of `Struct` with `invokebuiltin`Nobuyoshi Nakada2020-06-161-9/+8
|
* Introduce find pattern [Feature #16828]Kazuki Tsujimoto2020-06-141-0/+167
|
* Fix crashes in the peephole optimizer on OpenBSD/sparc64Jeremy Evans2020-06-081-2/+3
| | | | | | | These crashes are due to alignment issues, casting ADJUST to INSN and then accessing after the end of the ADJUST. These patches come from Stefan Sperling <stsp@apache.org>, who reported the issue.
* compile.c: Mark cursor in debug listNobuyoshi Nakada2020-05-311-5/+5
|
* compile.c: Removed wrong conversionNobuyoshi Nakada2020-05-311-1/+1
|
* Adjusted an indentNobuyoshi Nakada2020-05-301-1/+1
|
* add indent for debug disasm outputKoichi Sasada2020-05-291-3/+3
|
* Fixed potential memory leakNobuyoshi Nakada2020-05-221-3/+4
| | | | | Create a wrapper object first, then buffer allocation which can fail.
* Use a pinning list for keeping objects alive during assembly.Aaron Patterson2020-05-201-14/+87
| | | | | | | | | | The GC will not disassemble incomplete instruction sequences. So it is important that when instructions are being assembled, any objects the instructions point at should not be moved. This patch implements a fixed width array that pins its references. When the instructions are done being assembled, the pinning array goes away and the objects inside the iseqs are allowed to move.
* Prefer dedicated enum over intNobuyoshi Nakada2020-05-181-1/+1
|
* built-in method call must not have a receiverNobuyoshi Nakada2020-05-181-0/+1
|
* drop varargs.h support卜部昌平2020-05-111-1/+1
| | | | | This header file is simply out of date (for decades since at least 1989). It's the 21st century. Just stop using it.
* sed -i 's|ruby/impl|ruby/internal|'卜部昌平2020-05-111-1/+1
| | | | To fix build failures.
* sed -i s|ruby/3|ruby/impl|g卜部昌平2020-05-111-1/+1
| | | | This shall fix compile errors.
* Added more NORETURN declarationsNobuyoshi Nakada2020-05-111-1/+3
|
* Fix pseudo code for NODE_ARYPTN, NODE_HSHPTNKazuki Tsujimoto2020-05-041-2/+0
| | | | | Due to the change in 3893a8dd42fb3bbd71750648c3c0de118955a6ea, there is no longer a need to put true/false.
* Create succ_index_table as a part of `iseq_setup`Nobuyoshi Nakada2020-04-151-0/+7
| | | | | | With compiling `CPDEBUG >= 2`, `rb_iseq_disasm` segfaults if this table has not been created. Also `ibf_load_iseq_each` calls `rb_iseq_insns_info_encode_positions`.
* Disassemble nop-inserted listNobuyoshi Nakada2020-04-151-0/+2
|
* Show heading for update_catch_except_flagsNobuyoshi Nakada2020-04-151-0/+1
|
* Avoid UB with flexible array memberAlan Wu2020-04-121-2/+2
| | | | | | | Accessing past the end of an array is technically UB. Use C99 flexible array member instead to avoid the UB and simplify allocation size calculation. See also: DCL38-C in the SEI CERT C Coding Standard
* Suppress -Wswitch warningsNobuyoshi Nakada2020-04-081-0/+2
|
* Merge pull request #2991 from shyouhei/ruby.h卜部昌平2020-04-081-17/+18
| | | Split ruby.h
* Reduce allocations for keyword argument hashesJeremy Evans2020-03-171-20/+42
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously, passing a keyword splat to a method always allocated a hash on the caller side, and accepting arbitrary keywords in a method allocated a separate hash on the callee side. Passing explicit keywords to a method that accepted a keyword splat did not allocate a hash on the caller side, but resulted in two hashes allocated on the callee side. This commit makes passing a single keyword splat to a method not allocate a hash on the caller side. Passing multiple keyword splats or a mix of explicit keywords and a keyword splat still generates a hash on the caller side. On the callee side, if arbitrary keywords are not accepted, it does not allocate a hash. If arbitrary keywords are accepted, it will allocate a hash, but this commit uses a callinfo flag to indicate whether the caller already allocated a hash, and if so, the callee can use the passed hash without duplicating it. So this commit should make it so that a maximum of a single hash is allocated during method calls. To set the callinfo flag appropriately, method call argument compilation checks if only a single keyword splat is given. If only one keyword splat is given, the VM_CALL_KW_SPLAT_MUT callinfo flag is not set, since in that case the keyword splat is passed directly and not mutable. If more than one splat is used, a new hash needs to be generated on the caller side, and in that case the callinfo flag is set, indicating the keyword splat is mutable by the callee. In compile_hash, used for both hash and keyword argument compilation, if compiling keyword arguments and only a single keyword splat is used, pass the argument directly. On the caller side, in vm_args.c, the callinfo flag needs to be recognized and handled. Because the keyword splat argument may not be a hash, it needs to be converted to a hash first if not. Then, unless the callinfo flag is set, the hash needs to be duplicated. The temporary copy of the callinfo flag, kw_flag, is updated if a hash was duplicated, to prevent the need to duplicate it again. If we are converting to a hash or duplicating a hash, we need to update the argument array, which can including duplicating the positional splat array if one was passed. CALLER_SETUP_ARG and a couple other places needs to be modified to handle similar issues for other types of calls. This includes fairly comprehensive tests for different ways keywords are handled internally, checking that you get equal results but that keyword splats on the caller side result in distinct objects for keyword rest parameters. Included are benchmarks for keyword argument calls. Brief results when compiled without optimization: def kw(a: 1) a end def kws(**kw) kw end h = {a: 1} kw(a: 1) # about same kw(**h) # 2.37x faster kws(a: 1) # 1.30x faster kws(**h) # 2.19x faster kw(a: 1, **h) # 1.03x slower kw(**h, **h) # about same kws(a: 1, **h) # 1.16x faster kws(**h, **h) # 1.14x faster
* Make {**{}} return unfrozen empty hashJeremy Evans2020-03-171-6/+20
| | | | | | | | | | | | | | | | Previously, method call keyword splats and hash keyword splats were compiled exactly the same. This is because parse-wise, they operate on indentical nodes when it comes to compiling the **{}. Fix this by using an ugly hack of temporarily modifying the nd_brace flag in the method call keyword splat case. Inside compile_hash, only optimize the **{} case for hashes where the nd_brace flag has been modified to reflect we are in the method call keyword splat case and it is safe to do so. Since compile_keyword_args is only called in one place, move the keyword_node_p call out of that method to the single caller to avoid duplicating the code.
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-26 04:11:09 +0000