aboutsummaryrefslogtreecommitdiffstats
path: root/gc.c
Commit message (Collapse)AuthorAgeFilesLines
* GC measurement featureKoichi Sasada2021-11-191-37/+60
| | | | | | | * `GC.measure_total_time = true` enables total time measurement (default: true) * `GC.measure_total_time` returns current flag. * `GC.total_time` returns measured total time in nano seconds. * `GC.stat(:time)` (and Hash) returns measured total time in milli seconds.
* support `GC.stat(:time)` take 2Koichi Sasada2021-11-191-0/+51
|
* `Primitive.mandatory_only?` for fast pathKoichi Sasada2021-11-151-5/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Compare with the C methods, A built-in methods written in Ruby is slower if only mandatory parameters are given because it needs to check the argumens and fill default values for optional and keyword parameters (C methods can check the number of parameters with `argc`, so there are no overhead). Passing mandatory arguments are common (optional arguments are exceptional, in many cases) so it is important to provide the fast path for such common cases. `Primitive.mandatory_only?` is a special builtin function used with `if` expression like that: ```ruby def self.at(time, subsec = false, unit = :microsecond, in: nil) if Primitive.mandatory_only? Primitive.time_s_at1(time) else Primitive.time_s_at(time, subsec, unit, Primitive.arg!(:in)) end end ``` and it makes two ISeq, ``` def self.at(time, subsec = false, unit = :microsecond, in: nil) Primitive.time_s_at(time, subsec, unit, Primitive.arg!(:in)) end def self.at(time) Primitive.time_s_at1(time) end ``` and (2) is pointed by (1). Note that `Primitive.mandatory_only?` should be used only in a condition of an `if` statement and the `if` statement should be equal to the methdo body (you can not put any expression before and after the `if` statement). A method entry with `mandatory_only?` (`Time.at` on the above case) is marked as `iseq_overload`. When the method will be dispatch only with mandatory arguments (`Time.at(0)` for example), make another method entry with ISeq (2) as mandatory only method entry and it will be cached in an inline method cache. The idea is similar discussed in https://bugs.ruby-lang.org/issues/16254 but it only checks mandatory parameters or more, because many cases only mandatory parameters are given. If we find other cases (optional or keyword parameters are used frequently and it hurts performance), we can extend the feature.
* Remove RCLASS(obj)->ptr when RVARGC is enabledMatt Valentine-House2021-11-111-4/+4
| | | | | | | With RVARGC we always store the rb_classext_t in the same slot as the RClass struct that refers to it. So we don't need to store the pointer or access through the pointer anymore and can switch the RCLASS_EXT macro to use an offset
* fix a memory leak introduced in 8bbd319Matt Valentine-House2021-11-111-2/+6
| | | | | | This commit fixes a memory leak introduced in an early part of the variable width allocation project that would prevent the rb_classext_t struct from being free'd when the class is swept.
* [Feature #18290] Deprecate rb_gc_force_recycle and remove ↵Peter Zhu2021-11-081-72/+1
| | | | | | | | invalidate_mark_stack_chunk This commit deprecates rb_gc_force_recycle and coverts it to a no-op function. Also removes invalidate_mark_stack_chunk since only rb_gc_force_recycle uses it.
* make obj_free return true when it frees an objectMatt Valentine-House2021-10-291-9/+8
| | | | | Previously obj_free returned true when it could not free a slot because of a finalizer, and false when it successfully frees a slot.
* Prefer size pool heap macros over direct accessMatt Valentine-House2021-10-291-15/+15
|
* Fix a warningKazuhiro NISHIYAMA2021-10-281-1/+1
| | | | | | | | | | | ``` ../gc.c:2342:45: warning: comparison of integers of different signs: 'short' and 'size_t' (aka 'unsigned long') [-Wsign-compare] GC_ASSERT(size_pools[pool_id].slot_size == slot_size); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~ ``` Add cast to short, because `GC_ASSERT`s in `size_pool_for_size` already use cast to short.
* Fix a warningKazuhiro NISHIYAMA2021-10-281-1/+1
| | | | | | | | ``` ../gc.c:2342:25: warning: array subscript is of type 'char' [-Wchar-subscripts] GC_ASSERT(size_pools[pool_id].slot_size == slot_size); ^~~~~~~~ ```
* Align `RFloat` at VALUE boundaryNobuyoshi Nakada2021-10-271-6/+5
|
* [Feature #18239] Implement VWA for stringsPeter Zhu2021-10-251-56/+89
| | | | | This commit adds support for embedded strings with variable capacity and uses Variable Width Allocation to allocate strings.
* [Feature #18239] Refactor RVARGC alloc functionsPeter Zhu2021-10-251-1/+3
| | | | | The allocation functions no longer assume that one RVALUE needs to be allocated.
* Suppress false warning for freed pointerNobuyoshi Nakada2021-10-241-13/+24
|
* Push compaction page alignment check downAaron Patterson2021-10-211-18/+18
| | | | | | | | | | | | It seems like `gc_verify_compaction_references` is not protected in case alignment is wrong. This commit pushes the alignment check down to `gc_start_internal` so that anyone trying to compact will check page alignment I think this method may be getting called on PowerPC and the alignment might be wrong. http://rubyci.s3.amazonaws.com/ppc64le/ruby-master/log/20211021T190006Z.fail.html.gz
* Partial revert of ceebc7fc98dAaron Patterson2021-10-201-1/+1
| | | | | | | I'm looking through the places where YJIT needs notifications. It looks like these changes to gc.c and vm_callinfo.h have become unnecessary since 84ab77ba592. This commit just makes the diff against upstream smaller, but otherwise shouldn't change any behavior.
* MicroJIT: generate less code for CFUNCsAlan Wu2021-10-201-1/+1
| | | | | | | | Added UJIT_CHECK_MODE. Set to 1 to double check method dispatch in generated code. It's surprising to me that we need to watch both cc and cme. There might be opportunities to simplify there.
* Print errno when mprotect failsAaron Patterson2021-10-201-2/+2
| | | | Trying to figure out the problem on s390x.
* Move rb_ractor_p definitionS.H2021-10-041-2/+0
|
* Using NIL_P macro instead of `== Qnil`S.H2021-10-031-4/+4
|
* Cast to void pointer to suppress -Wformat-pedantic in RUBY_DEBUG_LOGNobuyoshi Nakada2021-10-031-4/+4
|
* Introduce `RBIMPL_NONNULL_ARG` macroNobuyoshi Nakada2021-09-271-8/+1
| | | | | Runtime assertion for the argument declared as non-null. This macro does nothing if `RBIMPL_ATTR_NONNULL` is effective, otherwise asserts that the argument is non-null.
* Fix malloc_increase is not correctly calculatedPeter Zhu2021-09-201-3/+3
| | | | | | | | | | Commit 123eeb1c1a904923754ce65148dbef045b56e083 added incremental GC which moved resetting malloc_increase, oldmalloc_increase to before marking. However, during_minor_gc is not set until gc_marks_start. So the value will be from the last GC run, rather than the current one. Before the incremental GC commit, this code was in gc_before_sweep which ran before sweep (after marking) so the value during_minor_gc was correct.
* Fix total_freed_objects for invalidated pagesPeter Zhu2021-09-151-1/+2
| | | | | | When the object is moved back into the T_MOVED, the flags of the T_MOVED is not copied, so the FL_FROM_FREELIST flag is lost. This causes total_freed_objects to always be incremented.
* Don't overwrite free_slots count during sweepingPeter Zhu2021-09-151-1/+2
| | | | | gc_compact_finish may invalidate pages, which may move objects from this page to other pages, which updates the free_slots of this page.
* Update the free_slots count of the original pagePeter Zhu2021-09-151-20/+9
| | | | | | When invalidating a page during compaction, the free_slots count should be updated for the page of the object and not the page of the forwarding address (since the object gets moved back to the forwarding address).
* Using RB_BIGNUM_TYPE_P macroS-H-GAMELINKS2021-09-111-2/+2
|
* suppress GCC's -Wnonnull-compare卜部昌平2021-09-101-0/+7
| | | | | This particular NULL check must be a good thing to do both statically and dynamically.
* Replace RBOOL macroS-H-GAMELINKS2021-09-051-4/+4
|
* Remove heap_is_swept_object functionPeter Zhu2021-09-011-12/+1
| | | | | is_swept_object just calls heap_is_swept_object so remove heap_is_swept_object.
* Fix memory leak in Variable Width AllocationPeter Zhu2021-08-271-23/+27
| | | | | | Force recycled objects could create a freelist for the page. At the start of sweeping we should append to the freelist to avoid permanently losing the slots on the freelist.
* [Feature #18045] Implement size classes for GCPeter Zhu2021-08-251-329/+749
| | | | | | | | | This commits implements size classes in the GC for the Variable Width Allocation feature. Unless `USE_RVARGC` compile flag is set, only a single size class is created, maintaining current behaviour. See the redmine ticket for more details. Co-authored-by: Aaron Patterson <tenderlove@ruby-lang.org>
* [Feature #18045] Remove T_PAYLOADPeter Zhu2021-08-251-343/+2
| | | | | | | This commit removes T_PAYLOAD since the new VWA implementation no longer requires T_PAYLOAD types. Co-authored-by: Aaron Patterson <tenderlove@ruby-lang.org>
* Replace intptr_t with uintptr_t in gc.cPeter Zhu2021-08-231-21/+21
| | | | | Pointers may be large to the point where intptr_t would be negative. This is problematic when doing comparisons of pointers.
* Revert "[Feature #18045] Implement size classes for GC"Peter Zhu2021-08-231-754/+674
| | | | | | This reverts commits 48ff7a9f3e47bffb3e4d067a12ba9b936261caa0 and b2e2cf2dedd104acad8610721db5e4d341f135ef because it is causing crashes in SPARC solaris and i386 debian.
* [Feature #18045] Implement size classes for GCPeter Zhu2021-08-231-331/+752
| | | | | | | | | This commits implements size classes in the GC for the Variable Width Allocation feature. Unless `USE_RVARGC` compile flag is set, only a single size class is created, maintaining current behaviour. See the redmine ticket for more details. Co-authored-by: Aaron Patterson <tenderlove@ruby-lang.org>
* [Feature #18045] Remove T_PAYLOADPeter Zhu2021-08-231-343/+2
| | | | | | | This commit removes T_PAYLOAD since the new VWA implementation no longer requires T_PAYLOAD types. Co-authored-by: Aaron Patterson <tenderlove@ruby-lang.org>
* Turned the reminder comment to a compile-time messageNobuyoshi Nakada2021-08-201-1/+2
|
* Undefine the alloc function for T_DATA classesMike Dalessio2021-08-201-2/+13
| | | | | | | | | | | | | | which have not undefined or redefined it. When a `T_DATA` object is created whose class has not undefined or redefined the alloc function, the alloc function now gets undefined by Data_Wrap_Struct et al. Optionally, a future release may also warn that this being done. This should help developers of C extensions to meet the requirements explained in "doc/extension.rdoc". Without a check like this, there is no easy way for an author of a C extension to see where they have made a mistake.
* `SIZE_MAX` is not `size_t` on emscriptenNobuyoshi Nakada2021-08-161-3/+3
|
* Make during_compacting flag in GC one bitPeter Zhu2021-08-111-2/+2
| | | | | | | | Commit c32218de1ba094223420a4ea017707f48d0009c5 turned during_compacting flag to 2 bits to support the case when there is no write barrier. But commit 32b7dcfb56a417c1d1c354102351fc1825d653bf changed compaction to always enable the write barrier. This commit cleans up some of the leftover code.
* Make bit flags `reason` unsignedNobuyoshi Nakada2021-08-081-26/+26
|
* Suppress warnings when GC_ENABLE_INCREMENTAL_MARK == 0Nobuyoshi Nakada2021-08-081-8/+7
|
* Using RBOOL macroS.H2021-08-021-5/+5
|
* Do not check pending interrupts when running finalizersJeremy Evans2021-07-291-0/+4
| | | | | | | | | | | | | This fixes cases where exceptions raised using Thread#raise are swallowed by finalizers and not delivered to the running thread. This could cause issues with finalizers that rely on pending interrupts, but that case is expected to be rarer. Fixes [Bug #13876] Fixes [Bug #15507] Co-authored-by: Koichi Sasada <ko1@atdot.net>
* Suppress exception message in finalizer [Feature #17798]Nobuyoshi Nakada2021-07-231-1/+1
|
* Show exception in finalizer [Feature #17798]Nobuyoshi Nakada2021-07-231-1/+14
|
* Access rb_execution_context_t::errinfo directlyNobuyoshi Nakada2021-07-231-2/+2
|
* Use rb_equalNobuyoshi Nakada2021-07-231-1/+1
| | | | It can be optimized and handles Qnil properly.
* Finalizers no longer store the safe levelNobuyoshi Nakada2021-07-231-6/+6
|
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-27 00:00:45 +0000