aboutsummaryrefslogtreecommitdiffstats
path: root/hash.c
Commit message (Collapse)AuthorAgeFilesLines
* Don't check for null pointer in calls to freePeter Zhu2023-06-301-1/+1
| | | | | | | | According to the C99 specification section 7.20.3.2 paragraph 2: > If ptr is a null pointer, no action occurs. So we do not need to check that the pointer is a null pointer.
* Fix memory leak in Hash#replacePeter Zhu2023-06-291-1/+14
| | | | Hash#replace can leak memory if the receiver has an ST table.
* Fix memory leak when copying ST tablesPeter Zhu2023-06-291-2/+5
| | | | | | | | | | | | | | | | | st_copy allocates a st_table, which is not needed for hashes since it is allocated by VWA and embedded, so this causes a memory leak. The following script demonstrates the issue: ```ruby 20.times do 100_000.times do {a: 1, b: 2, c: 3, d: 4, e: 5, f: 6, g: 7, h: 8, i: 9} end puts `ps -o rss= -p #{$$}` end ```
* Refactor rb_hash_replace to use hash_copyPeter Zhu2023-06-291-28/+21
|
* Declare `RHASH_AR_TABLE` and `RHASH_ST_TABLE` return non-nullNobuyoshi Nakada2023-06-231-4/+2
|
* Remove dead code in hash.cPeter Zhu2023-06-221-53/+0
| | | | | RHASH_TABLE_NULL_P and ar_alloc_table are no longer needed since all Hash will have AR tables.
* hash.c no longer needs the transient heapPeter Zhu2023-06-121-5/+2
|
* * remove trailing spaces. [ci skip]git2023-06-081-1/+1
|
* [DOC] Add comment about flags for HashPeter Zhu2023-06-081-0/+17
|
* [DOC] Mention the edge case of `any?`/`all?`Nobuyoshi Nakada2023-06-011-0/+5
|
* Remove dead code in rb_hash_replacePeter Zhu2023-05-231-5/+0
| | | | | We now always copy the ST table, so we don't need to initialize the ST table of hash when hash2 is empty.
* Fix crash when replacing ST hash with AR hashPeter Zhu2023-05-231-3/+27
| | | | | | | | | With VWA, AR hashes are much larger than ST hashes. Hash#replace attempts to directly copy the contents of AR hashes into ST hashes so there will be memory corruption caused by writing past the end of memory. This commit changes it so that if a ST hash is being replaced with an AR hash it will insert each element into the ST hash.
* Remove dead code in ar_copyPeter Zhu2023-05-231-4/+0
| | | | new_tab can no longer ever be NULL so this is dead code.
* Hash.new: print a deprecation warning when receiving keyword arguments (#7828)Jean byroot Boussier2023-05-231-5/+9
| | | | | | | | | | [Feature #19236] In Ruby 3.3, `Hash.new` shall print a deprecation warning if keyword arguments are passed instead of treating them as an implicit positional Hash. This will allow to safely introduce a `capacity` keyword argument in 3.4 Co-authored-by: Jean Boussier <byroot@ruby-lang.org>
* Move ar_hint to ar_table_structPeter Zhu2023-05-171-14/+17
| | | | This allows Hashes with ST tables to fit int he 80 byte size pool.
* Implement Hash ST tables on VWAPeter Zhu2023-05-171-71/+39
|
* Implement Hash AR tables on VWAPeter Zhu2023-05-171-77/+22
|
* Add `rb_sys_fail_sprintf` macroNobuyoshi Nakada2023-05-121-4/+4
|
* [DOC] hash.c: fix typo in `#<=>` docsPiotr Szotkowski2023-05-011-1/+1
|
* Adjust function style [ci skip]Nobuyoshi Nakada2023-04-151-3/+1
|
* hash.c: Fix hash_iter_lev_dec corrupting shapeJean Boussier2023-04-111-3/+9
| | | | | | | [Bug #19589] When decrementing `iter_lev` from `65` to `64` the flags would be corrupted, causing the shape_id to be invalid.
* [Feature #19474] Refactor NEWOBJ macrosMatt Valentine-House2023-04-061-1/+1
| | | | NEWOBJ_OF is now our canonical newobj macro. It takes an optional ec
* Change Hash#compact to keep default values and compare_by_identity flagJeremy Evans2023-03-241-11/+5
| | | | | | | | | The documentation states it returns a copy of self with nil value entries removed. However, the previous behavior was creating a plain new hash with non-nil values copied into it. This change aligns the behavior with the documentation. Fixes [Bug #19113]
* Copy compare_by_identity flag for empty hashes in Hash.ruby2_keywords_hashJeremy Evans2023-03-241-3/+6
| | | | | | | This was already copied for non-empty hashes. As Hash.ruby2_keywords_hash copies default values, it should also copy the compare_by_identity flag. Partially Fixes [Bug #19113]
* Do not copy compare_by_identity flag for non-empty hashes in Hash.[]Jeremy Evans2023-03-241-4/+16
| | | | | | | | It wasn't copied for empty hashes, and Hash.[] doesn't copy the default value, so copying the compare_by_identity flag does not make sense. Partially Fixes [Bug #19113]
* Resurrect symbols used by ObjectSpaceTakashi Kokubun2023-03-061-1/+1
|
* Stop exporting symbols for MJITTakashi Kokubun2023-03-061-8/+8
|
* Implement ObjectSpace::WeakKeyMap basic allocatorJean Boussier2023-02-231-2/+2
| | | | [Feature #18498]
* Remove (newly unneeded) remarks about aliasesBurdetteLamar2023-02-191-26/+2
|
* Merge gc.h and internal/gc.hMatt Valentine-House2023-02-091-1/+1
| | | | [Feature #19425]
* Remove dead code in ar_copyPeter Zhu2023-02-031-32/+16
| | | | | | All of the callers of ar_copy guarantee that hash2 has an ar table, so we don't need the logic to handle the case when hash2 doesn't have an ar table.
* Remove redundant else if statement in hash.cPeter Zhu2023-02-021-2/+4
| | | | Hashes can only be ar or st, so the else if is redundant.
* Remove rb_hash_ar_table_pPeter Zhu2023-01-311-12/+0
| | | | It's dead code and duplicate of RHASH_AR_TABLE_P.
* Remove rb_hash_st_tablePeter Zhu2023-01-311-7/+0
| | | | It's a duplicate of RHASH_ST_TABLE.
* Remove rb_hash_ar_tablePeter Zhu2023-01-311-7/+0
| | | | It's dead code and duplicate of RHASH_AR_TABLE.
* Document thread-safety issues with Hash default_procJeremy Evans2023-01-201-0/+4
| | | | Fixes [Bug #19237]
* Assert possible hash functions in RHASH_ST_TABLE (#7107)Takashi Kokubun2023-01-111-0/+4
| | | | | | | | | | Because of the function pointer, it's hard to figure out what hash functions could be used in Hash objects when st_lookup is used. Having this assertion makes it easier to understand what hash_stlike_lookup could possibly do. (AR uses only rb_any_hash) For example, this clarifies that hash_stlike_lookup never calls a #hash method when a key is T_STRING or T_SYMBOL.
* Use FL_TEST_RAW in rb_hash_default_valueJohn Hawthorn2022-12-171-1/+3
| | | | | | | | | We should always have a T_HASH here, so we can use FL_TEST_RAW to avoid checking whether we may have an immediate value. I expect this to be a very small performance improvement (perf stat ./miniruby benchmark/hash_aref_miss.rb shows a ~1% improvement). It also removes 9 instructions from rb_hash_default_value on x86_64.
* Use a BOP for Hash#defaultJohn Hawthorn2022-12-171-3/+17
| | | | | | | | | | | | | | | | | | | | On a hash miss we need to call default if it is redefined in order to return the default value to be used. Previously we checked this with rb_method_basic_definition_p, which avoids the method call but requires a method lookup. This commit replaces the previous check with BASIC_OP_UNREDEFINED_P and a new BOP_DEFAULT. We still need to fall back to rb_method_basic_definition_p when called on a subclasss of hash. | |compare-ruby|built-ruby| |:---------------|-----------:|---------:| |hash_aref_miss | 2.692| 3.531| | | -| 1.31x| Co-authored-by: Daniel Colson <danieljamescolson@gmail.com> Co-authored-by: "Ian C. Anderson" <ian@iancanderson.com> Co-authored-by: Jack McCracken <me@jackmc.xyz>
* Using UNDEF_P macroS-H-GAMELINKS2022-11-161-15/+15
|
* Adjust indents [ci skip]Nobuyoshi Nakada2022-10-241-13/+13
|
* Introduce `hash_iter_status_check` functionS.H2022-10-231-18/+15
|
* Improved formatting of `hash_foreach_iter` functions. (#6615)Samuel Williams2022-10-221-7/+10
|
* [Bug #17767] Now `ENV.clone` raises `TypeError` as well as `ENV.dup`Nobuyoshi Nakada2022-08-021-13/+8
| | | | | | One year ago, the former method has been deprecated while the latter has become an error. Then the 3.1 released, it is enough time to make also the former an error.
* Rename rb_ary_tmp_new to rb_ary_hidden_newPeter Zhu2022-07-261-1/+1
| | | | | | rb_ary_tmp_new suggests that the array is temporary in some way, but that's not true, it just creates an array that's hidden and not on the transient heap. This commit renames it to rb_ary_hidden_new.
* Expand tabs [ci skip]Takashi Kokubun2022-07-211-273/+273
| | | | [Misc #18891]
* ENV.merge! support multile arguments [Feature #18279]Nobuyoshi Nakada2022-06-171-10/+15
|
* Restore rb_exec_recursive_outerJohn Hawthorn2022-06-151-0/+1
| | | | This was a public method, so we should probably keep it.
* Make method id explicit in rb_exec_recursive_outerJohn Hawthorn2022-06-101-1/+1
| | | | | | | | | | | | | | Previously, because opt_aref and opt_aset don't push a frame, when they would call rb_hash to determine the hash value of the key, the initial level of recursion would incorrectly use the method id at the top of the stack instead of "hash". This commit replaces rb_exec_recursive_outer with rb_exec_recursive_outer_mid, which takes an explicit method id, so that we can make the hash calculation behave consistently. rb_exec_recursive_outer was documented as being internal, so I believe this should be okay to change.
* Document best-practices for writing hash methods (#5805)Chris Seaton2022-04-301-0/+13
| | | | | * Discussion is as per https://bugs.ruby-lang.org/issues/18611. Co-authored-by: Sam Bostock <sam.bostock@shopify.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-25 11:19:10 +0000