aboutsummaryrefslogtreecommitdiffstats
path: root/lib/bundler
Commit message (Collapse)AuthorAgeFilesLines
* Fix a couple of bundler issues with keyword argument separationJeremy Evans2019-08-301-1/+6
| | | | | There are more issues than this, but hopefully this is enough to get make test-bundler passing in CI.
* Revert "require 'pp' before use PP"Kazuhiro NISHIYAMA2019-08-301-1/+0
| | | | | of lib/bundler/vendor/molinillo/lib/molinillo/resolution.rb. This reverts commit 500149709b92ccb36396589a0c39afb3ff77bfb6 partially.
* Removed debug printNobuyoshi Nakada2019-08-301-10/+0
| | | | It seems to be fixed by b870ca58791e576f5dbb263f54ae433a7f6d65ee.
* Add guard as same as `==`Kazuhiro NISHIYAMA2019-08-301-0/+1
| | | | | | | | Try to fix failure at https://github.com/ruby/ruby/runs/207580232#step:10:382 ``` undefined method `name' for "Gemfile.lock":String /home/runner/work/ruby/ruby/lib/bundler/resolver/spec_group.rb:65:in `eql?' ```
* require 'pp' before use PPKazuhiro NISHIYAMA2019-08-301-0/+1
| | | | | | | `Kernel#pp` has wrapper, but `PP` does not. https://github.com/ruby/ruby/runs/207405029#step:10:141 `NameError: uninitialized constant Bundler::Molinillo::Resolver::Resolution::PP`
* The investigation is going on...Nobuyoshi Nakada2019-08-211-0/+10
|
* [bundler/bundler] Remove old rubies stuff no longer neededDavid Rodríguez2019-08-212-6/+2
| | | | https://github.com/bundler/bundler/commit/36fb3287f4
* Fix some bundler specs (#2380)David Rodríguez2019-08-203-13/+10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * These seem to consistenly pass already * Show actual command when running `make test-bundler` Current the setup command that installs the necessary gems for testing bundler was printed, but not the actual command that runs the tests. That was a bit confusing. * Borrow trick from setproctitle specs * A title that long doesn't get set sometimes No idea why, but the test doesn't need that the title is that long. * Fix most gem helper spec ruby-core failures * Fix the rest of the gem helper failures * Fix version spec by improving the assertion * Remove unnecessary `BUNDLE_RUBY` environment var We can use `RUBY` when necessary, and `BUNDLE_RUBY` is not a good name because bundler considers `BUNDLE_*` variables as settings. * Rename `BUNDLE_GEM` to `GEM_COMMAND` This is more descriptive I think, and also friendlier for bundler because `BUNDLE_` env variables are interpreted by bundler as settings, and this is not a bundler setting. This fixes one bundler spec failure in config specs against ruby-core. * Fix quality spec when run in core Use the proper path helper. * Fix dummy lib builder to never load default gems If a dummy library is named as a default gem, when requiring the library from its executable, the default gem would be loaded when running from core, because in core all default gems share path with bundler, and thus they are always in the $LOAD_PATH. We fix the issue by loading lib relatively inside dummy lib executables. * More exact assertions Sometimes I have the problem that I do some "print debugging" inside specs, and suddently the spec passes. This happens when the assertion is too relaxed, and the things I print make it match, specially when they are simple strings like "1.0" than can be easily be part of gem paths that I print for debugging. I fix this by making a more exact assertion. * Detect the correct shebang when ENV["RUBY"] is set * Relax assertion So that the spec passes even if another paths containing "ext" are in the load path. This works to fix a ruby-core issue, but it's a better assertion in general. We just want to know that the extension path was added. * Use folder structure independent path helper It should fix this spec for ruby-core. * Fix the last failing spec on ruby-core * Skip `bundle open <default_gem>` spec when no default gems
* [bundler/bundler] No need to activate the `fileutils` default gemDavid Rodríguez2019-08-181-6/+1
| | | | | | | The version we're vendoring actually relaxed this restriction back to 2.3.0+, so we can always use the vendored version. https://github.com/bundler/bundler/commit/d366cbfe5d
* [bundler/bundler] Last relative requiresDavid Rodríguez2019-08-183-9/+9
| | | | https://github.com/bundler/bundler/commit/fb587b9ebb
* [bundler/bundler] Move local variable to only branch where it's usedDavid Rodríguez2019-08-181-1/+1
| | | | https://github.com/bundler/bundler/commit/3995b3345d
* [bundler/bundler] Fix open default gem errorZehan Zhao2019-08-181-5/+9
| | | | https://github.com/bundler/bundler/commit/792d724752
* [bundler/bundler] Fix `bundle doctor` commandDavid Rodríguez2019-08-181-1/+1
| | | | | | | | | | | | | | Previously `bundle doctor` would fail on any bundle that does not include git gems or plugins. This is because the previously used `Bundler.home` does not exist unless the bundle includes git gems or plugins. For example, with `bundle config set path .bundle`, it points to which does not exist unless this kind of gems exist in the Gemfile. The name `Bundler.home` is really unfortunate, it should probably be have more descriptive name, and be private. But for now I just want to make `bundle doctor` usable. https://github.com/bundler/bundler/commit/5531a18c1e
* [bundler/bundler] Bundler displays a duplicate gem entries warning even if ↵David Stosik2019-08-181-1/+1
| | | | | | gems only appear once per group https://github.com/bundler/bundler/commit/d18a83109e
* [bundler/bundler] Fix bundle bin location in core repoDavid Rodríguez2019-08-171-1/+1
| | | | https://github.com/bundler/bundler/commit/9437568ab4
* Fix typosKazuhiro NISHIYAMA2019-08-171-1/+1
|
* [bundler/bundler] Add `--[no-]git` option to `bundle gem`David Rodríguez2019-08-162-1/+2
| | | | | | | I think using `--no-git` can be useful when creating gems inside monorepos. https://github.com/bundler/bundler/commit/154c687310
* [bundler/bundler] Remove misleading comment in GemfileDavid Rodríguez2019-08-161-4/+1
| | | | | | | Since we no longer use `git` to find out the list of files, the comment is misleading. https://github.com/bundler/bundler/commit/54d85d5349
* [bundler/bundler] Stop printing deprecation messages during specsDavid Rodríguez2019-08-161-2/+18
| | | | | | | | | | | | Previously under some circunstances (met during some specs), bundler would print deprecations to a separate UI different from "bundler's UI". This UI would not be captured by the specs, and thus would be printed to screen during the specs. This commit fixes that by making sure all deprecation messages always go through bundler's UI. https://github.com/bundler/bundler/commit/220c54b7fa
* [bundler/bundler] Fix typo in comment: attibutes -> attributesMasato Ohba2019-08-161-1/+1
| | | | https://github.com/bundler/bundler/commit/876545805e
* [bundler/bundler] Use the standard RUBY_ENGINE_VERSION instead of JRUBY_VERSIONBenoit Daloze2019-08-161-11/+1
| | | | | | | * RUBY_ENGINE and RUBY_ENGINE_VERSION are defined on every modern Ruby. * There is no such constant as TRUFFLERUBY_VERSION or RBX_VERSION. https://github.com/bundler/bundler/commit/f9d910403b
* [bundler/bundler] Fix inconsistent lockfile orderDavid Rodríguez2019-08-161-1/+6
| | | | | | | | When Gemfile would specify path sources as relative paths starting with "./", the lockfile would have inconsistent order on `bundle install` and `bundle update`. https://github.com/bundler/bundler/commit/c7532ced89
* [bundler/bundler] Reuse `root` methodDavid Rodríguez2019-08-161-2/+2
| | | | https://github.com/bundler/bundler/commit/42363091da
* [bundler/bundler] Remove Bundler.rubygems.config_map because it was deprecated.Hiroshi SHIBATA2019-08-031-4/+0
| | | | https://github.com/bundler/bundler/commit/5215ae7fa3
* [bundler/bundler] Point to CoC which contains the contributor covenantAdam Wanninger2019-08-031-1/+2
| | | | https://github.com/bundler/bundler/commit/a94f74682e
* [bundler/bundler] Bump rubocop to 0.74.0David Rodríguez2019-08-033-3/+3
| | | | | | | And reenable exclusion because the bug why we added them has been fixed. See https://github.com/rubocop-hq/rubocop/issues/6861. https://github.com/bundler/bundler/commit/bda63fcffc
* [bundler/bundler] net-http-persistent 3.1.0 has been releasedDavid Rodríguez2019-08-033-9/+31
| | | | https://github.com/bundler/bundler/commit/ffb7d6fa53
* [bundler/bundler] Adapt to the way my automatiek patch worksDavid Rodríguez2019-08-031-1/+1
| | | | https://github.com/bundler/bundler/commit/b8ee4aec0b
* [bundler/bundler] Bump net-http-persistent to 3.0.1David Rodríguez2019-08-0312-440/+811
| | | | | | | | | | | | | * Adds an extra artifice task to vendorize new `connection_pool` dependency. * Cherry-pick's needed Windows fix not yet merged into master branch of `net-http-persistent`. * Update bundler usages to be compatible with the new version, and fix unit specs. https://github.com/bundler/bundler/commit/0575baa6bb
* [bundler/bundler] Enable `Style/UnneededInterpolation` copDavid Rodríguez2019-08-033-3/+3
| | | | https://github.com/bundler/bundler/commit/4c6a3c3cf7
* [bundler/bundler] Check for straneous quotesDavid Rodríguez2019-08-031-1/+1
| | | | | | And use single quotes consistenly. https://github.com/bundler/bundler/commit/8b9fbbb2df
* [bundler/bundler] [CurrentRuby] Say we are ruby? when the generic local ↵Samuel Giddins2019-08-031-0/+2
| | | | | | | | | platform is Gem::Platform::RUBY This allows us to always say we're ruby? when force_ruby_platform is set, and fixes using gemspec & force_ruby_platform on windows. https://github.com/bundler/bundler/commit/3cb89b7e5c
* [bundler/bundler] Fully remove compatibility guardDavid Rodríguez2019-08-033-13/+0
| | | | https://github.com/bundler/bundler/commit/2a7a5daba0
* [bundler/bundler] Remove development dependencies from gemspecDavid Rodríguez2019-08-031-7/+0
| | | | | | And refactor development setup. https://github.com/bundler/bundler/commit/f288806d02
* [bundler/bundler] RUBY_ENGINE should always be defined after 1.8.7David Rodríguez2019-08-033-15/+8
| | | | https://github.com/bundler/bundler/commit/d6c9196d18
* [bundler/bundler] Add exclamation mark to methodDavid Rodríguez2019-08-031-2/+2
| | | | | | | | | To indicate that it can raise. Co-authored-by: Guillermo Guerrero <wolf.fox1985@gmail.com> Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> https://github.com/bundler/bundler/commit/584e841624
* [bundler/bundler] Move `strict` to an attributeDavid Rodríguez2019-08-031-8/+8
| | | | | | | Co-authored-by: Guillermo Guerrero <wolf.fox1985@gmail.com> Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> https://github.com/bundler/bundler/commit/7b68d86bdd
* [bundler/bundler] Extract some methodsDavid Rodríguez2019-08-031-19/+31
| | | | | | | Co-authored-by: Guillermo Guerrero <wolf.fox1985@gmail.com> Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> https://github.com/bundler/bundler/commit/027aba0cff
* [bundler/bundler] Unfold message to single line for readabilityDavid Rodríguez2019-08-031-2/+1
| | | | https://github.com/bundler/bundler/commit/d845a213ca
* [bundler/bundler] Extract a `print_gems` methodGuillermo Guerrero2019-08-031-16/+13
| | | | https://github.com/bundler/bundler/commit/0d8c8d207e
* [bundler/bundler] Less complexityGuillermo Guerrero2019-08-031-15/+8
| | | | https://github.com/bundler/bundler/commit/be9d6e7cfc
* [bundler/bundler] Move more locals to attributesDavid Rodríguez2019-08-031-10/+11
| | | | | | | Co-authored-by: Guillermo Guerrero <wolf.fox1985@gmail.com> Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> https://github.com/bundler/bundler/commit/4335df3e4c
* [bundler/bundler] Move `any?` logic to the attributeDavid Rodríguez2019-08-031-5/+3
| | | | | | | | | | It's the only usage of the `options_include_groups` attribute and its name suggests a boolean, so it fits better now. Co-authored-by: Guillermo Guerrero <wolf.fox1985@gmail.com> Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> https://github.com/bundler/bundler/commit/53c0fae760
* [bundler/bundler] Move `options_include_groups` to an attributeDavid Rodríguez2019-08-031-5/+5
| | | | | | | Co-authored-by: Guillermo Guerrero <wolf.fox1985@gmail.com> Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> https://github.com/bundler/bundler/commit/832fb900f0
* [bundler/bundler] Prefer feature flag to harcoded checkDavid Rodríguez2019-08-031-1/+1
| | | | https://github.com/bundler/bundler/commit/8c83921d08
* [bundler/bundler] Restore `cache_all` flag removalDavid Rodríguez2019-08-031-3/+4
| | | | https://github.com/bundler/bundler/commit/04a04719f0
* [bundler/bundler] Add workaround from old rubygemsDavid Rodríguez2019-08-031-1/+9
| | | | | | | In these versions, the `approximate_recommendation` method doesn't include the prerelease logic. https://github.com/bundler/bundler/commit/caf13e9e4f
* [bundler/bundler] Update error messages to be more preciseDavid Rodríguez2019-08-031-1/+1
| | | | https://github.com/bundler/bundler/commit/9ddeeb1fe1
* [bundler/bundler] Remove unnecessary method parameterDavid Rodríguez2019-08-031-2/+2
| | | | https://github.com/bundler/bundler/commit/72194d1aac
* [bundler/bundler] Use a consistent requirement in binstubDavid Rodríguez2019-08-031-9/+12
| | | | https://github.com/bundler/bundler/commit/50ccdb32c2