aboutsummaryrefslogtreecommitdiffstats
path: root/lib
Commit message (Collapse)AuthorAgeFilesLines
* [ruby/csv] doc: Match text to the struct name ↵Vince2021-10-241-1/+1
| | | | | | (https://github.com/ruby/csv/pull/217) https://github.com/ruby/csv/commit/744e41130c
* [ruby/csv] Bump versionSutou Kouhei2021-10-241-1/+1
| | | | https://github.com/ruby/csv/commit/3025070cea
* Sync did_you_meanYuki Nishijima2021-10-221-1/+1
|
* Sync did_you_mean againYuki Nishijima2021-10-227-96/+82
|
* Revert "Sync did_you_mean"Yuki Nishijima2021-10-227-83/+96
| | | | This reverts commit e22d293e06966733e71a7fd9725eee06c03d0177.
* Sync did_you_meanYuki Nishijima2021-10-227-96/+83
|
* [ruby/mutex_m] Make VERSION shareablerm1552021-10-221-0/+1
| | | | https://github.com/ruby/mutex_m/commit/a839e29d04
* [ruby/uri] URI#HTTP#origin and URI#HTTP#authority ↵Tiago2021-10-221-0/+39
| | | | | | | (https://github.com/ruby/uri/pull/30) https://github.com/ruby/uri/commit/bf13946c32 Co-authored-by: Samuel Williams <samuel.williams@oriontransfer.co.nz>
* [ruby/delegate] gemspec: Drop unused executables directivesOlle Jonsson2021-10-221-2/+0
| | | | https://github.com/ruby/delegate/commit/81a3c32140
* [rubygems/rubygems] Re-enable `default_ignores` option for standard Justin Searls2021-10-221-2/+0
| | | | | | | | I am not sure why this flag was turned off (it wasn't explained in my commit message in 0365dc852767ae589376a7aad1fb129738e408b0 or in my PR in #4411). Whatever the reason, without `default_ignores` turned on, most default CI configurations will immediately fail, as they most likely vendor and cache their dependencies under `vendor`, which will cause standard to run against all the vendored gems and (most likely) fail. I think we should remove this before this feature is released. https://github.com/rubygems/rubygems/commit/677f74be48
* [ruby/prettyprint] Bump up prettyprint version to 0.1.1Hiroshi SHIBATA2021-10-211-1/+1
| | | | https://github.com/ruby/prettyprint/commit/0e8eee5f5f
* [ruby/pp] Bump up pp version to 0.2.1Hiroshi SHIBATA2021-10-211-1/+1
| | | | https://github.com/ruby/pp/commit/06b839b9ca
* [ruby/securerandom] Bump up securerandom version to 0.1.1Hiroshi SHIBATA2021-10-211-1/+1
| | | | https://github.com/ruby/securerandom/commit/5f9d3d1dfa
* [ruby/rinda] Bump up rinda version to 0.1.1Hiroshi SHIBATA2021-10-211-1/+1
| | | | https://github.com/ruby/rinda/commit/d394ba107e
* [ruby/optparse] Bump up optparse version to 0.2.0Hiroshi SHIBATA2021-10-211-1/+1
| | | | https://github.com/ruby/optparse/commit/1226b670e6
* [ruby/net-http] Bump up net-http version to 0.2.0Hiroshi SHIBATA2021-10-211-1/+1
| | | | https://github.com/ruby/net-http/commit/f3e65e2a31
* [ruby/net-protocol] Bump up net-protocol version to 0.1.2Hiroshi SHIBATA2021-10-211-1/+1
| | | | https://github.com/ruby/net-protocol/commit/088e52609a
* [ruby/uri] Bump up uri version to 0.11.0Hiroshi SHIBATA2021-10-211-1/+1
| | | | https://github.com/ruby/uri/commit/1619f713e6
* [ruby/ostruct] Bump up ostruct version to 0.5.0Hiroshi SHIBATA2021-10-211-1/+1
| | | | https://github.com/ruby/ostruct/commit/c535a406f8
* [ruby/fileutils] Bump up fileutils version to 1.6.0Hiroshi SHIBATA2021-10-211-1/+1
| | | | https://github.com/ruby/fileutils/commit/918d19e4f2
* [ruby/racc] Bump up racc version to 1.6.0Hiroshi SHIBATA2021-10-191-1/+1
| | | | https://github.com/ruby/racc/commit/0c5fe2637c
* [ruby/logger] Bump up logger version to 1.4.4Hiroshi SHIBATA2021-10-191-1/+1
| | | | https://github.com/ruby/logger/commit/82a59c8d3f
* [ruby/tempfile] Bump up tempfile version to 0.1.2Hiroshi SHIBATA2021-10-191-1/+1
| | | | https://github.com/ruby/tempfile/commit/e5ec902256
* [ruby/rdoc] fix: alias to method with call-seqMike Dalessio2021-10-161-1/+1
| | | | | | | | | | | | | This change fixes alias call-seq to return nil if the method's call-seq does not specify the alias. Previously, the alias's call-seq would be an empty string in this case which broke darkfish rendering. This change also backfills test coverage for 0ead786 which moved call-seq deduplication into AnyMethod. https://github.com/ruby/rdoc/commit/5ce2789b6f
* [ruby/rdoc] Support linking #==Mike Dalessio2021-10-161-1/+1
| | | | | | | | | See related commits: - ebc66662 for #=== - 4943d208 for #[], #[]=, #<<, and #>> https://github.com/ruby/rdoc/commit/8e47f7840a
* [ruby/rdoc] feat: add support for :category: on C functionsMike Dalessio2021-10-163-0/+10
| | | | https://github.com/ruby/rdoc/commit/45c92005fe
* [ruby/rdoc] fix: comments in C files use the global markup optionMike Dalessio2021-10-161-1/+5
| | | | | | | | Previously, Parser::C comments all defaulted to "rdoc" format, even when the user had set a different default with the `--markup=<choice>` option. https://github.com/ruby/rdoc/commit/4643b08a26
* [ruby/rdoc] extract Comment creation in Parser::CMike Dalessio2021-10-161-9/+12
| | | | | | This is a prefactor for fixing comment format handling. https://github.com/ruby/rdoc/commit/a3d366feed
* Make explicit opening filesNobuyoshi Nakada2021-10-151-3/+3
|
* [rubygems/rubygems] Update broken link in ↵Jack Schuss2021-10-151-1/+2
| | | | | | Bundler::Fetcher::CertificateFailureError https://github.com/rubygems/rubygems/commit/11b5d479cb
* [ruby/drb] Bump up drb version to 2.1.0Hiroshi SHIBATA2021-10-141-1/+1
| | | | https://github.com/ruby/drb/commit/e4b7b68d67
* [ruby/drb] Bump up drb version to 2.0.5Hiroshi SHIBATA2021-10-141-1/+1
| | | | https://github.com/ruby/drb/commit/7edf67654c
* [ruby/time] Bump up time version to 0.2.0Hiroshi SHIBATA2021-10-141-1/+1
| | | | https://github.com/ruby/time/commit/b9dd593b23
* [ruby/open-uri] Bump up open-uri version to 0.2.0Hiroshi SHIBATA2021-10-141-1/+1
| | | | https://github.com/ruby/open-uri/commit/ec4275a1eb
* [ruby/base64] Bump up base64 version to 0.1.1Hiroshi SHIBATA2021-10-141-1/+1
| | | | https://github.com/ruby/base64/commit/b9e23b27f9
* [ruby/find] Bump up find version to 0.1.1Hiroshi SHIBATA2021-10-141-1/+1
| | | | https://github.com/ruby/find/commit/90c35c477a
* [ruby/yaml] Bump up yaml version to 0.2.0Hiroshi SHIBATA2021-10-141-1/+1
| | | | https://github.com/ruby/yaml/commit/cef5360823
* [ruby/timeout] Bump up timeout version to 0.2.0Hiroshi SHIBATA2021-10-141-1/+1
| | | | https://github.com/ruby/timeout/commit/02e792ddd8
* [ruby/cgi] Bump up cgi version to 0.3.0Hiroshi SHIBATA2021-10-141-1/+1
| | | | https://github.com/ruby/cgi/commit/95324433b4
* [ruby/benchmark] Bump up benchamark version to 0.2.0Hiroshi SHIBATA2021-10-141-1/+1
| | | | https://github.com/ruby/benchmark/commit/eea1657fa2
* [ruby/fileutils] Remove counterproductive optimizationDavid Rodríguez2021-10-141-8/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I think it's debatable which is the most common usage of `FileUtils.mkdir_p`, but even assuming the most common use case is creating a folder when it doesn't previously exist but the parent does, this optimization doesn't seem to have a noticiable effect there while harming other use cases. For benchmarks, I created this script ```ruby require "benchmark/ips" Benchmark.ips do |x| x.report("old mkdir_p - exists") do FileUtils.mkdir_p "/tmp" end x.report("new_mkdir_p - exists") do FileUtils.mkdir_p_new "/tmp" end x.compare! end FileUtils.rm_rf "/tmp/foo" Benchmark.ips do |x| x.report("old mkdir_p - doesnt exist, parent exists") do FileUtils.mkdir_p "/tmp/foo" FileUtils.rm_rf "/tmp/foo" end x.report("new_mkdir_p - doesnt exist, parent exists") do FileUtils.mkdir_p_new "/tmp/foo" FileUtils.rm_rf "/tmp/foo" end x.compare! end Benchmark.ips do |x| x.report("old mkdir_p - doesnt exist, parent either") do FileUtils.mkdir_p "/tmp/foo/bar" FileUtils.rm_rf "/tmp/foo" end x.report("new_mkdir_p - doesnt exist, parent either") do FileUtils.mkdir_p_new "/tmp/foo/bar" FileUtils.rm_rf "/tmp/foo" end x.compare! end Benchmark.ips do |x| x.report("old mkdir_p - more levels") do FileUtils.mkdir_p "/tmp/foo/bar/baz" FileUtils.rm_rf "/tmp/foo" end x.report("new_mkdir_p - more levels") do FileUtils.mkdir_p_new "/tmp/foo/bar/baz" FileUtils.rm_rf "/tmp/foo" end x.compare! end ``` and copied the method with the "optimization" removed as `FileUtils.mkdir_p_new`. The results are as below: ``` Warming up -------------------------------------- old mkdir_p - exists 15.914k i/100ms new_mkdir_p - exists 46.512k i/100ms Calculating ------------------------------------- old mkdir_p - exists 161.461k (± 3.2%) i/s - 811.614k in 5.032315s new_mkdir_p - exists 468.192k (± 2.9%) i/s - 2.372M in 5.071225s Comparison: new_mkdir_p - exists: 468192.1 i/s old mkdir_p - exists: 161461.0 i/s - 2.90x (± 0.00) slower Warming up -------------------------------------- old mkdir_p - doesnt exist, parent exists 2.142k i/100ms new_mkdir_p - doesnt exist, parent exists 1.961k i/100ms Calculating ------------------------------------- old mkdir_p - doesnt exist, parent exists 21.242k (± 6.7%) i/s - 107.100k in 5.069206s new_mkdir_p - doesnt exist, parent exists 19.682k (± 4.2%) i/s - 100.011k in 5.091961s Comparison: old mkdir_p - doesnt exist, parent exists: 21241.7 i/s new_mkdir_p - doesnt exist, parent exists: 19681.7 i/s - same-ish: difference falls within error Warming up -------------------------------------- old mkdir_p - doesnt exist, parent either 945.000 i/100ms new_mkdir_p - doesnt exist, parent either 1.002k i/100ms Calculating ------------------------------------- old mkdir_p - doesnt exist, parent either 9.689k (± 4.4%) i/s - 49.140k in 5.084342s new_mkdir_p - doesnt exist, parent either 10.806k (± 4.6%) i/s - 54.108k in 5.020714s Comparison: new_mkdir_p - doesnt exist, parent either: 10806.3 i/s old mkdir_p - doesnt exist, parent either: 9689.3 i/s - 1.12x (± 0.00) slower Warming up -------------------------------------- old mkdir_p - more levels 702.000 i/100ms new_mkdir_p - more levels 775.000 i/100ms Calculating ------------------------------------- old mkdir_p - more levels 7.046k (± 3.5%) i/s - 35.802k in 5.087548s new_mkdir_p - more levels 7.685k (± 5.5%) i/s - 38.750k in 5.061351s Comparison: new_mkdir_p - more levels: 7685.1 i/s old mkdir_p - more levels: 7046.4 i/s - same-ish: difference falls within error ``` I think it's better to keep the code simpler is the optimization is not so clear like in this case. https://github.com/ruby/fileutils/commit/e842a0e70e
* [ruby/fileutils] Simplify loop to find out segments to be createdDavid Rodríguez2021-10-141-3/+1
| | | | | | | Doing it this way is simpler and it doesn't end up adding "/" to the list of folders, so it doesn't need to be removed later. https://github.com/ruby/fileutils/commit/df08e124ce
* [rubygems/rubygems] Remove unnecessary methodDavid Rodríguez2021-10-131-7/+2
| | | | https://github.com/rubygems/rubygems/commit/97241e0ea4
* [rubygems/rubygems] Reuse `sh` helper for `git push` tooDavid Rodríguez2021-10-131-3/+1
| | | | https://github.com/rubygems/rubygems/commit/32aa540163
* [rubygems/rubygems] Simplify some codeDavid Rodríguez2021-10-131-2/+1
| | | | | | | | This method always receives an array, and we require `shellwords` unconditionally at the top of the file, so `shelljoin` will always be available. https://github.com/rubygems/rubygems/commit/05c8ac641d
* [rubygems/rubygems] Reuse `sh` helperDavid Rodríguez2021-10-131-4/+1
| | | | https://github.com/rubygems/rubygems/commit/c218d4d79e
* [rubygems/rubygems] Improve error messages in gem helpersDavid Rodríguez2021-10-131-3/+3
| | | | | | | | | | Previously they were printing the original command that was run, and telling the user to rerun it. However, the command sometimes would not match the exact command that was run (for example, when using the `--local` flag), and in any case, it's simpler and more useful to print the underlying error anyways. https://github.com/rubygems/rubygems/commit/5bc0d51b58
* [rubygems/rubygems] Fix `bundle install` crash due to an incorrectly ↵David Rodríguez2021-10-131-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | incomplete resolve In case we have a corrupted lockfile that claims to support a platform, but it's missing platform specific gems for it, bundler has a check that detects the situation and forces a re-resolve. The result of this check is kept under the `@locked_specs_incomplete_for_platformn` instance variable in `Definition`. The installer, however, calls `Definition#nothing_changed?` before this instance variable has been filled, so the result of it is actually incorrect here since it will claim that nothing has changed, but something has changed (locked specs are incomplete for the current platform). The consequence of this incorrect result is that the installer thinks it can go on without re-resolving, resulting in the incomplete resolution from the lockfile being used, and in a crash being triggered due to that. The solution is to make sure the `@locked_specs_incomplete_for_platform` instance variable is filled before `nothing_changed?` gets called. Moving it to `initialize` makes the most sense, not because it's the best place for it (we can refactor this later), but because all of the other "outdated definition" checks are already set there. https://github.com/rubygems/rubygems/commit/708afdd789
* [rubygems/rubygems] No need to use converged dependencies eitherDavid Rodríguez2021-10-131-1/+1
| | | | | | This is exclusively about the lockfile. https://github.com/rubygems/rubygems/commit/d6c6d040cd
* [rubygems/rubygems] Extract `locked_dependencies` helperDavid Rodríguez2021-10-131-4/+8
| | | | https://github.com/rubygems/rubygems/commit/7326d47530