aboutsummaryrefslogtreecommitdiffstats
path: root/spec/bundler/commands
Commit message (Collapse)AuthorAgeFilesLines
...
* [rubygems/rubygems] s/rails_fail/rails_pinned_to_old_activesupport/David Rodríguez2020-06-181-2/+2
| | | | | | | | | The `rails_fail` name is misleading because there's no specific reason why such a gem would need to fail. As a matter of fact, `bundle install`'ing a Genfile with only that dependency like the spec the previous commit adds is not expected to fail. https://github.com/rubygems/rubygems/commit/b947f40701
* Accommodate process title spec to ruby-core setupDavid Rodríguez2020-06-151-3/+3
| | | | | | I'm guessing the commands under ruby-core setup are very long, so the title gets truncated. Use a shorter title, since the test doesn't really care.
* Fix most exec specsDavid Rodríguez2020-06-151-10/+10
| | | | | | | | | The `gem_command` helper was failing to require `support/hax.rb`, which takes care of making sure rubygems actually picks up the right `ruby` executable under ruby-core setup (`ENV["RUBY"]`). This caused binstubs to be generated with a wrong shebang, and that caused `bundle exec` to not work. The error message was pretty confusing though due to https://bugs.ruby-lang.org/issues/16952.
* [rubygems/rubygems] Remove multiline gem specifications correctlyCarsten Wirth2020-06-051-0/+24
| | | | https://github.com/rubygems/rubygems/commit/8dca0ad56e
* [rubygems/rubygems] Fix `bundle info` not indicating a gem which has been ↵DEVRAJ KUMAR2020-06-051-0/+9
| | | | | | | | deleted, unlike `bundle show` Co-Authored-By: David Rodríguez <deivid.rodriguez@riseup.net> https://github.com/rubygems/rubygems/commit/2851b40ffb
* [rubygems/rubygems] Tag test framework hint specs and use out helperFrank Lam2020-06-051-8/+11
| | | | https://github.com/rubygems/rubygems/commit/1db61b5b5e
* [rubygems/rubygems] Add user hint specs for bundle gem --testFrank Lam2020-06-051-2/+22
| | | | https://github.com/rubygems/rubygems/commit/1d2292a88f
* [rubygems/rubygems] Fix bundle gem ignoring global gem.test configFrank Lam2020-06-051-12/+59
| | | | | | | | | | | | | | | | | | | | | | | | | | * bundle gem previously ignored gem.test when passed empty -t flag, defaulting to RSpec * bundle gem will now ask user for test framework when passed empty -t flag and gem.test is set to false, but will not overwrite gem.test * thor option parsing for String types falls back to human name for nil, so setting lazy_default to nil won't work * https://github.com/erikhuda/thor/blob/c5161501e0cfac7a8c5b838a9c6084c275f03c0d/lib/thor/parser/options.rb#L224 Default to Bundler.settings["gem.test"] for empty --test Add shared examples for test framework to newgem spec Add examples for empty --test flag to newgem spec Simplify conditional for prompting test framework Follow naming conventions for bundler settings Add more descriptive test framework help text for bundle gem Update man pages for bundler https://github.com/rubygems/rubygems/commit/ab0785a09f
* [rubygems/rubygems] Remove `forgotten_command_line_usages` from specsDavid Rodríguez2020-06-056-28/+61
| | | | | | | | Instead, use the non-deprecated option except when specifically testing deprecated CLI flags. In that case, pass the flag directly and limit the specs to `bundler < 3`. https://github.com/rubygems/rubygems/commit/3d5e186241
* [rubygems/rubygems] Reword specs to not mention deprecated flagsDavid Rodríguez2020-06-052-25/+11
| | | | https://github.com/rubygems/rubygems/commit/f878a81f22
* [rubygems/rubygems] Improve specs testing option remembering behaviorDavid Rodríguez2020-06-052-5/+5
| | | | | | By making them more explicit. https://github.com/rubygems/rubygems/commit/9979c5a811
* [rubygems/rubygems] Pass `--deployment` flag directlyDavid Rodríguez2020-06-051-1/+1
| | | | | | | This spec is run only in bundler 2 mode, and it's testing the `--deployment` flag specifically. https://github.com/rubygems/rubygems/commit/a5d91c68b6
* Fixup 1d079a0c5d4d80860a4d6d692344124fe5c562b5Hiroshi SHIBATA2020-05-221-1/+1
|
* Sync Bundler PR #3624 with HEAD commitsHiroshi SHIBATA2020-05-221-0/+19
|
* Marked the failing examples with the current master branch on ruby repositoryHiroshi SHIBATA2020-05-225-15/+15
|
* Sync Bundler PR #3624Hiroshi SHIBATA2020-05-228-46/+51
|
* Skip the examples for bundle exec with gem installationHiroshi SHIBATA2020-05-131-6/+6
|
* Unmask the some of examples with ruby_repo labelHiroshi SHIBATA2020-05-132-2/+2
|
* Skip the example to use rake commandHiroshi SHIBATA2020-05-131-1/+1
|
* Update the bundler version with master branchHiroshi SHIBATA2020-05-1323-391/+727
|
* Merge bundler-2.1.4Hiroshi SHIBATA2020-01-083-3/+3
|
* Merge bundler-2.1.1 from bundler/bundlerHiroshi SHIBATA2019-12-181-0/+6
|
* Fixed test failures with gem command path on ruby core repo.Hiroshi SHIBATA2019-12-151-1/+1
|
* Prepare to release bundler-2.1.0Hiroshi SHIBATA2019-12-156-8/+14
|
* Allow unknown if ruby coreKazuhiro NISHIYAMA2019-11-191-2/+10
|
* Merge Bundler 2.1.0.pre3 released versionHiroshi SHIBATA2019-11-131-26/+49
|
* Merge Bundler 2.1.0.pre.3Hiroshi SHIBATA2019-11-114-342/+181
| | | | | | | | | | | | | | | Features: - Add caller information to some deprecation messages to make them easier to fix [#7361](https://github.com/bundler/bundler/pull/7361) - Reconcile `bundle cache` vs `bundle package` everywhere. Now in docs, CLI help and everywhere else `bundle cache` is the preferred version and `bundle package` remains as an alias [#7389](https://github.com/bundler/bundler/pull/7389) - Display some basic `bundler` documentation together with ruby's RDoc based documentation [#7394](https://github.com/bundler/bundler/pull/7394) Bugfixes: - Fix typos deprecation message and upgrading docs [#7374](https://github.com/bundler/bundler/pull/7374) - Deprecation warnings about `taint` usage on ruby 2.7 [#7385](https://github.com/bundler/bundler/pull/7385) - Fix `--help` flag not correctly delegating to `man` when used with command aliases [#7388](https://github.com/bundler/bundler/pull/7388) - `bundle add` should cache newly added gems if an application cache exists [#7393](https://github.com/bundler/bundler/pull/7393) - Stop using an insecure folder as a "fallback home" when user home is not defined [#7416](https://github.com/bundler/bundler/pull/7416) - Fix `bundler/inline` warning about `Bundler.root` redefinition [#7417](https://github.com/bundler/bundler/pull/7417)
* [bundler/bundler] Merge all `bundle check --path` specsDavid Rodríguez2019-09-181-25/+30
| | | | | | And skip them all for bundler 3. https://github.com/bundler/bundler/commit/b88936cdc2
* [bundler/bundler] Merge #7340Bundlerbot2019-09-181-27/+91
| | | | | | | | | | | | | | | | | | | | | | | | | | | 7340: Fix bundle clean issue r=deivid-rodriguez a=deivid-rodriguez ### What was the end-user problem that led to this PR? The problem was that `bundle clean` is crashing under some conditions. ### What was your diagnosis of the problem? My diagnosis was that sometimes (when the bundle includes git sourced gems with extensions), it assumes that some paths exist, but they don't. ### What is your fix for the problem, implemented in this PR? My fix is to ignore those paths. ### Why did you choose this fix out of the possible options? I chose this fix because it fixes the issue. Fixes #7338. Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net> (cherry picked from commit b007fde67c77c1f15f13b97eda186644c2a2be04) https://github.com/bundler/bundler/commit/3766053507
* [bundler/bundler] Remove duplicated spec filterDavid Rodríguez2019-09-181-1/+1
| | | | https://github.com/bundler/bundler/commit/b7fc6f4187
* Remove github_action_linux tag from bundler examples.Hiroshi SHIBATA2019-08-231-1/+1
| | | | Maybe it has fixed at 5a384e2c08704dc7af9d8d3bdfc475eb8c0723aa
* [bundler/bundler] Fix a couple of typosDavid Rodríguez2019-08-211-1/+1
| | | | https://github.com/bundler/bundler/commit/52b6b94068
* Fix some bundler specs (#2380)David Rodríguez2019-08-206-14/+24
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * These seem to consistenly pass already * Show actual command when running `make test-bundler` Current the setup command that installs the necessary gems for testing bundler was printed, but not the actual command that runs the tests. That was a bit confusing. * Borrow trick from setproctitle specs * A title that long doesn't get set sometimes No idea why, but the test doesn't need that the title is that long. * Fix most gem helper spec ruby-core failures * Fix the rest of the gem helper failures * Fix version spec by improving the assertion * Remove unnecessary `BUNDLE_RUBY` environment var We can use `RUBY` when necessary, and `BUNDLE_RUBY` is not a good name because bundler considers `BUNDLE_*` variables as settings. * Rename `BUNDLE_GEM` to `GEM_COMMAND` This is more descriptive I think, and also friendlier for bundler because `BUNDLE_` env variables are interpreted by bundler as settings, and this is not a bundler setting. This fixes one bundler spec failure in config specs against ruby-core. * Fix quality spec when run in core Use the proper path helper. * Fix dummy lib builder to never load default gems If a dummy library is named as a default gem, when requiring the library from its executable, the default gem would be loaded when running from core, because in core all default gems share path with bundler, and thus they are always in the $LOAD_PATH. We fix the issue by loading lib relatively inside dummy lib executables. * More exact assertions Sometimes I have the problem that I do some "print debugging" inside specs, and suddently the spec passes. This happens when the assertion is too relaxed, and the things I print make it match, specially when they are simple strings like "1.0" than can be easily be part of gem paths that I print for debugging. I fix this by making a more exact assertion. * Detect the correct shebang when ENV["RUBY"] is set * Relax assertion So that the spec passes even if another paths containing "ext" are in the load path. This works to fix a ruby-core issue, but it's a better assertion in general. We just want to know that the extension path was added. * Use folder structure independent path helper It should fix this spec for ruby-core. * Fix the last failing spec on ruby-core * Skip `bundle open <default_gem>` spec when no default gems
* Skip open_spec.rb:L95 because ruby repo doesn't have json as default gems.Hiroshi SHIBATA2019-08-181-1/+1
|
* [bundler/bundler] Remove unnecessary rubygems monkeypatchDavid Rodríguez2019-08-181-2/+1
| | | | | | | Instead, make sure we always load the local copy of bundler during specs, and never end up using the default copy. https://github.com/bundler/bundler/commit/ac655ffeda
* [bundler/bundler] Don't use system bundler on this specDavid Rodríguez2019-08-181-4/+2
| | | | | | | | | | | | | | | | | | | | | | If we use system bundler, when booting the "outermost" bundler process, bundler will save the path to the system bundler in BUNDLE_BIN_PATH, and use it again when booting the "innermost" bundler process (`bundle exec echo foo`). That means that second process will use the system bundler path again. However, we have `-rsupport/hax` in RUBYOPT, so that file will load from the local copy of bundler, and that file will load `bundler/version` from the project (not from system), because -Ilib is in the LOAD_PATH. That will end up causing redefinition errors because the same constant will be loaded from two different locations. In general, this is expected behavior, normally you will wrap the process with `Bundler.with_original_env` to reset the environment. However, the easiest fix here is to not use system bundler, because it's not really necessary and thus doesn't help the readability of the spec. https://github.com/bundler/bundler/commit/a3d72a34ab
* [bundler/bundler] Fix spec using the deprecated `bundle config` modeDavid Rodríguez2019-08-181-1/+1
| | | | https://github.com/bundler/bundler/commit/789dd1864f
* [bundler/bundler] Fix open default gem errorZehan Zhao2019-08-181-0/+13
| | | | https://github.com/bundler/bundler/commit/792d724752
* [bundler/bundler] Wrap `open` specs with a contextDavid Rodríguez2019-08-181-69/+71
| | | | | | So I can add another context that doesn't run the `before` block. https://github.com/bundler/bundler/commit/06d0acc45a
* [bundler/bundler] Prefer `before` to `before :each`David Rodríguez2019-08-181-1/+1
| | | | https://github.com/bundler/bundler/commit/6678747fae
* [bundler/bundler] Fix `bundle doctor` commandDavid Rodríguez2019-08-181-2/+8
| | | | | | | | | | | | | | Previously `bundle doctor` would fail on any bundle that does not include git gems or plugins. This is because the previously used `Bundler.home` does not exist unless the bundle includes git gems or plugins. For example, with `bundle config set path .bundle`, it points to which does not exist unless this kind of gems exist in the Gemfile. The name `Bundler.home` is really unfortunate, it should probably be have more descriptive name, and be private. But for now I just want to make `bundle doctor` usable. https://github.com/bundler/bundler/commit/5531a18c1e
* [bundler/bundler] Bundler displays a duplicate gem entries warning even if ↵David Stosik2019-08-181-2/+2
| | | | | | gems only appear once per group https://github.com/bundler/bundler/commit/d18a83109e
* [bundler/bundler] Extract a `gemspec_dir` helperDavid Rodríguez2019-08-171-2/+1
| | | | https://github.com/bundler/bundler/commit/71a29e286a
* [bundler/bundler] Reconcile testDavid Rodríguez2019-08-171-3/+1
| | | | | | The `:bundler` gem is not needed in the regular repo either. https://github.com/bundler/bundler/commit/ca5ce01a9b
* [bundler/bundler] Reuse `gem_command!` helperDavid Rodríguez2019-08-171-8/+4
| | | | https://github.com/bundler/bundler/commit/37d5dedffe
* [bundler/bundler] Reuse more shared path helpersDavid Rodríguez2019-08-171-6/+1
| | | | https://github.com/bundler/bundler/commit/79fdebd868
* [bundler/bundler] Remove duplicated methodDavid Rodríguez2019-08-171-1/+1
| | | | https://github.com/bundler/bundler/commit/afdacd62ac
* [bundler/bundler] Add `--[no-]git` option to `bundle gem`David Rodríguez2019-08-161-0/+36
| | | | | | | I think using `--no-git` can be useful when creating gems inside monorepos. https://github.com/bundler/bundler/commit/154c687310
* [bundler/bundler] Revert "make system_bundle_bin_path helper and resolve ↵David Rodríguez2019-08-161-1/+1
| | | | | | | | | | | | | | failing tests for ruby < 2.6" This reverts commit e63e844bc7444c6a489fcde0dc7011c6c4807edd. It was introduced to resolve some failing tests at the cost of making the intention of the spec much less clear. Thanks to the previous fixes we have added to this spec, we can revert that patch now. https://github.com/bundler/bundler/commit/b29a40820f
* [bundler/bundler] Make sure spec fails if `bundle install` failsDavid Rodríguez2019-08-161-1/+1
| | | | https://github.com/bundler/bundler/commit/2ed2bbfdec