aboutsummaryrefslogtreecommitdiffstats
path: root/spec/bundler/commands
Commit message (Collapse)AuthorAgeFilesLines
* Merge prepare version of Bundler 2.2.0Hiroshi SHIBATA2020-12-0814-50/+356
|
* Merge bundler-2.2.0.rc.2Hiroshi SHIBATA2020-10-157-9/+118
|
* [rubygems/rubygems] Move comment below shebang in bin/console templateSteven Peckins2020-09-281-0/+2
| | | | | | | | | | In an executable script, the shebang line should be the first line (the file needs to start with the bytes 0x23 0x21). Putting a comment above it will break the script. (Regression test included per @deivid-rodriguez) https://github.com/rubygems/rubygems/commit/962e669feb
* Fix typos [ci skip]Kazuhiro NISHIYAMA2020-09-171-1/+1
| | | | s/overriden/overridden/
* [rubygems/rubygems] Tag the specs with :readlineUtkarsh Gupta2020-07-151-5/+5
| | | | | | | | | | | | The newly added specs needs to be tagged as :readline, otherwise they fail on Windows with the backtrace: `ZeroDivisionError: divided by 0`. Such issues are already being skipped on Windows. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/391f860af4
* [rubygems/rubygems] Add tests with different flag combinationsUtkarsh Gupta2020-07-151-11/+44
| | | | | | | | | | | Since this PR was made because we missed checking RuboCop offenses with different flags, therefore adding tests so that all flag combinations are tested. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/d08250efc2
* [rubygems/rubygems] Fix line spacing to make Layout/EmptyLines happyUtkarsh Gupta2020-07-151-1/+1
| | | | | | | | | | | | | The Gemfile wasn't properly put in the last commit. As a result, Layout/EmptyLines inspected an offense in the Gemfile. This also fixes the spec w.r.t change in the task default. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/d1418fddd3
* [rubygems/rubygems] Remove unneeded trailing conditions on exitstatusDavid Rodríguez2020-07-159-26/+26
| | | | https://github.com/rubygems/rubygems/commit/27e0e4ecb6
* [rubygems/rubygems] Remove unnecessary assertions on exitstatusDavid Rodríguez2020-07-156-13/+0
| | | | | | | Since our helpers now raise by default if the subcommand fails, these will never actually fail and are not necessary. https://github.com/rubygems/rubygems/commit/6153b9321e
* [rubygems/rubygems] Skip this spec on ruby_core workflowUtkarsh Gupta2020-07-151-2/+3
| | | | | | | | | | | | | | | ruby_core has an 'ast.rb' file that gets in the middle and breaks this spec, so it's better we skip this test on this workflow for now. Also, slightly change the spec name from "run" to "runs" and change the last assertion, it's cleaner to check empty error. Thanks to David Rodríguez for this! Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/ba8eaa70c3
* [rubygems/rubygems] Use latest version of rubocop for RUBY_VERSION > 2.4Utkarsh Gupta2020-07-151-1/+2
| | | | | | | | | | | | With older versions of rubocop, the dependency on `jaro_winkler` seems to be a pain. However, in the later versions of rubocop, this dependency was dropped. So we only need to use the older version for ruby2.3. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/9cd87eaee3
* [rubygems/rubygems] Use `--config .rubocop.yml` insteadUtkarsh Gupta2020-07-151-1/+1
| | | | | | | | | | | because rubocop configuration inheritance is messed up and when using `--ignore-parent-exclusion`, even though the exit status is 0, the example still fails because of the configuration issue. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/3e20b2738c
* [rubygems/rubygems] Lock rubocop version to 0.80.1Utkarsh Gupta2020-07-151-1/+1
| | | | | | | | | | | | | | | The later RuboCop versions don't work with ruby2.3 so we should lock the version to what works with ruby2.3 as we haven't dropped the support yet. And since we're using the older version of rubocop, also fix `Max` value of `LineLength` to 120, which is the current standard. Without this, rubocop will throw the line length offenses. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/46d0a800a2
* [rubygems/rubygems] Fix linting and make Style/RedundantInterpolation happyUtkarsh Gupta2020-07-151-4/+4
| | | | | | Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/83e330fa87
* [rubygems/rubygems] Fix test to run rubocop on the generated gemUtkarsh Gupta2020-07-151-4/+2
| | | | | | | | | With this, it will be ensured that the generated (skeleton) gem will have no offenses. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/47411262e0
* [rubygems/rubygems] Make Style/HashSyntax cop happyUtkarsh Gupta2020-07-151-7/+7
| | | | | | | | | | Previously, we were using the old syntax like: `task :default => :spec`, but now this commit uses the new Ruby 1.9 hash syntax. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/b41d0fdb56
* [rubygems/rubygems] WIP: add test to run rubocop on the generated gemUtkarsh Gupta2020-07-151-0/+12
| | | | | | Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/730b770f8a
* [rubygems/rubygems] Fix tests pertaining to newgemUtkarsh Gupta2020-07-151-1/+9
| | | | | | Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/e2ee0b7de3
* [rubygems/rubygems] Bundler specs - Windows - remove skips, File.open => ↵MSP-Greg2020-07-151-3/+1
| | | | | | | | | | | | | | File.readlines Using File.open without a block leaves a file reference that causes issues with file operations commands/binstubs_spec.rb install/gems/compact_index_spec.rb install/gems/dependency_api_spec.rb install/gems/standalone_spec.rb runtime/executable_spec.rb https://github.com/rubygems/rubygems/commit/4b9a6ca156
* [rubygems/rubygems] bundler/spec/commands/binstubs_spec.rb - remove global ↵MSP-Greg2020-07-151-4/+1
| | | | | | | | | | | | Windows skip Added one skip for: bundle binstubs <gem> when the gem exists in the lockfile when generating bundle binstub outside bundler should abort https://github.com/rubygems/rubygems/commit/b77b484889
* [rubygems/rubygems] Better skip messagesDavid Rodríguez2020-06-181-1/+1
| | | | https://github.com/rubygems/rubygems/commit/4f519638ae
* [rubygems/rubygems] Only add .rubocop.yml when --rubocop flag is passedUtkarsh Gupta2020-06-181-7/+0
| | | | | | Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/ef2dae4222
* Ship default .rubocop.ymlUtkarsh Gupta2020-06-181-0/+7
| | | | | | | | | | | Currently, there is no `.rubocop.yml` shipped by default. So when a user runs `rubocop` after creating a new gem via `bundle gem foo`, it throws a bunch of offenses. With the default `.rubocop.yml` present, the number of those offenses significantly reduce by 25. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
* [rubygems/rubygems] Only add .rubocop.yml when --rubocop flag is passedUtkarsh Gupta2020-06-181-0/+8
| | | | | | Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/ef2dae4222
* s/sys_exec!/sys_execDavid Rodríguez2020-06-182-5/+5
|
* [rubygems/rubygems] s/run!/runDavid Rodríguez2020-06-182-2/+2
| | | | https://github.com/rubygems/rubygems/commit/e3f60d8aec
* [rubygems/rubygems] s/ruby!/rubyDavid Rodríguez2020-06-181-1/+1
| | | | https://github.com/rubygems/rubygems/commit/a73fa0760e
* [rubygems/rubygems] s/gem_command!/gem_commandDavid Rodríguez2020-06-181-4/+4
| | | | https://github.com/rubygems/rubygems/commit/f52733f6a4
* [rubygems/rubygems] s/install_gemfile!/install_gemfileDavid Rodríguez2020-06-1812-45/+45
| | | | https://github.com/rubygems/rubygems/commit/4d1a0c465a
* [rubygems/rubygems] s/bundle!/bundleDavid Rodríguez2020-06-1823-346/+346
| | | | https://github.com/rubygems/rubygems/commit/746a4b3d74
* [rubygems/rubygems] Prefer using bundle! to avoid unnecessary swallowing of ↵Frank Lam2020-06-181-26/+26
| | | | | | errors https://github.com/rubygems/rubygems/commit/6bac832a58
* [rubygems/rubygems] Move already configured --test hint to before test file ↵Frank Lam2020-06-181-5/+2
| | | | | | creation https://github.com/rubygems/rubygems/commit/9e5f7a9099
* [rubygems/rubygems] Move already configured --ci hint to before CI file creationFrank Lam2020-06-181-5/+2
| | | | https://github.com/rubygems/rubygems/commit/2af2abe5fd
* [rubygems/rubygems] Lower verboseness of user-facing text for bundle gemFrank Lam2020-06-181-2/+2
| | | | https://github.com/rubygems/rubygems/commit/288f073c3c
* [rubygems/rubygems] Make test framework/CI configuration for bundle gem ↵Frank Lam2020-06-181-0/+49
| | | | | | | | consistent * Add hints for --ci option https://github.com/rubygems/rubygems/commit/5f779f45b0
* [rubygems/rubygems] Fix CI spec typoFrank Lam2020-06-181-1/+1
| | | | | Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com> https://github.com/rubygems/rubygems/commit/24f3739585
* [rubygems/rubygems] Incorporate naming/grammar suggestions from olleolleolleFrank Lam2020-06-181-9/+9
| | | | https://github.com/rubygems/rubygems/commit/80571452ca
* [rubygems/rubygems] Move CI specs below test framework specsFrank Lam2020-06-181-79/+79
| | | | https://github.com/rubygems/rubygems/commit/d8e416d89b
* [rubygems/rubygems] Remove shared examples for present test frameworkFrank Lam2020-06-181-22/+0
| | | | | | * `bundle gem` has new option to select CI provider https://github.com/rubygems/rubygems/commit/320f3546c1
* [rubygems/rubygems] Separate CI and test framework shared examplesFrank Lam2020-06-181-4/+0
| | | | | | * `bundle gem` has new option to choose CI provider other than Travis CI https://github.com/rubygems/rubygems/commit/afaecf16de
* [rubygems/rubygems] Extract shared example for absence of CI filesFrank Lam2020-06-181-0/+9
| | | | https://github.com/rubygems/rubygems/commit/22cb599bcc
* Manually cherry-picked at ↵Hiroshi SHIBATA2020-06-181-2/+100
| | | | https://github.com/rubygems/rubygems/commit/80260b3496e357bf96ffe6f381e29bf25b6749cb
* [rubygems/rubygems] Remove unnecessary `bundle install`David Rodríguez2020-06-181-1/+1
| | | | | | | These specs doesn't really need an installed bundle, they only need a `Gemfile`. https://github.com/rubygems/rubygems/commit/06c85683ae
* [rubygems/rubygems] Make helpers raise by defaultDavid Rodríguez2020-06-1822-154/+153
| | | | https://github.com/rubygems/rubygems/commit/ade0c441d5
* [rubygems/rubygems] Remove bad `bundle install`David Rodríguez2020-06-181-1/+1
| | | | | | | | | This spec is specifically testing for the case where there's no `Gemfile.lock` file and it's only doing the expected thing because the `bundle install` command is silently failing. Remove the `bundle install` to reduce confusion. https://github.com/rubygems/rubygems/commit/ec39fbde0e
* [rubygems/rubygems] Simplify `bundle update --ruby` specsDavid Rodríguez2020-06-181-5/+4
| | | | | | | They don't need to run that many commands, and the new version is also more readable in my opinion. https://github.com/rubygems/rubygems/commit/efff3e3210
* [rubygems/rubygems] Fix redundant commandsDavid Rodríguez2020-06-181-2/+0
| | | | | | | They are preceded by `install_gemfile` calls, which mean `bundle install` is being run twice for no reason. https://github.com/rubygems/rubygems/commit/d2b2d10862
* [rubygems/rubygems] Fix unintended Gemfile installationDavid Rodríguez2020-06-181-1/+1
| | | | | | | | | | This command is failing because of the same reason that the subsequent `bundle exec` is failing: the gemspec is invalid. The `bundle install` here deviates the `bundle exec` focus from the test and is unnecessary: all we need is a `Gemfile` that will trigger the `bundle exec`, so let's create and avoid the extra command. https://github.com/rubygems/rubygems/commit/eb83cf6cf1
* [rubygems/rubygems] Remove failing command that doesn't affect the specDavid Rodríguez2020-06-181-4/+0
| | | | | | | This command was silently failing but doesn't really affect the outcome of the spec. https://github.com/rubygems/rubygems/commit/7880d08146
* [rubygems/rubygems] Remove broken testDavid Rodríguez2020-06-181-15/+0
| | | | | | | | | | | | | | | | | | | | | It turns out that this test is checking essentially nothing useful. The paperclip gem doesn't exist in our setup, so initial install is failing and the test is only checking that calling `bundle check` 3 times on a broken setup always returns the same thing. I went to the history of this test: * https://github.com/rubygems/bundler/commit/105654a31e07e9b0a198f1a5a5ec94e365854edf * https://github.com/rubygems/bundler/commit/ae53be1f8748bfc41bc6565dc4922a1c0ac80998 * https://github.com/rubygems/bundler/commit/d19f4a7b32ccf4ec4ecda5c7c0354adc81e1efb6 * https://github.com/rubygems/bundler/commit/092f169d01472336598e29b32550399991940d63 * https://github.com/rubygems/bundler/commit/36878435b5f0be75fc6f2e07cebd7f15aaddadf0 And have finally decided to remove it since I'm not sure changing it to something else will lead to testing something useful and not already tested. https://github.com/rubygems/rubygems/commit/6184322967
generated by cgit v1.2.3 (git 2.39.1) at 2024-08-07 03:54:17 +0000