aboutsummaryrefslogtreecommitdiffstats
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Warn for keyword to last hash parameter when method has no optional/rest ↵Jeremy Evans2019-08-301-4/+12
| | | | | | | | | parameters Previously, there was no warning in this case, even though we will be changing the behavior in Ruby 3. Fixes [Bug #14130]
* Fix a couple of bundler issues with keyword argument separationJeremy Evans2019-08-301-3/+4
| | | | | There are more issues than this, but hopefully this is enough to get make test-bundler passing in CI.
* Update specs to handle non-Symbols for keyword splats in 2.7Jeremy Evans2019-08-305-150/+378
| | | | Also handle some warnings for behavior that will change in 3.0.
* spec/ruby/core/unboundmethod/bind_call_spec.rb: Add ruby_version_is guardYusuke Endoh2019-08-301-36/+38
|
* spec/ruby/core/unboundmethod/bind_call_spec.rb: AddedYusuke Endoh2019-08-301-0/+50
| | | | | For UnboundMethod#bind_call [Feature #15955] introduced in 002e592e0d67bb0271d16314a32380ad947c9ae9.
* Fixed a comment [ci skip]Nobuyoshi Nakada2019-08-291-1/+1
| | | | | | A range literal in conditional expression is turned into a flip-flop, as a Range object is never falsy and does not make a sense.
* Revert "Remove warnings of flip-flop deprecation from tests and specs"Nobuyoshi Nakada2019-08-293-15/+10
| | | | | | | | This reverts commit bf7a32d22079cc44eb19794e41d82b886d5d17b3. flip-flop is no longer deprecated. [Feature #5400]
* Follows callback declaration updatesNobuyoshi Nakada2019-08-284-11/+16
|
* Fix rb_thread_create argument typeTakashi Kokubun2019-08-271-1/+1
| | | | | | | | | | in response to the declaration change in e3fc30564e9466d6926f9d25a090dcf787bd5c33. Fixing the AppVeyor mswin CI failure: https://ci.appveyor.com/project/ruby/ruby/builds/26980881/job/2j6h1qwjnbc8cpop ref: https://github.com/ruby/ruby/pull/2404
* Remove github_action_linux tag from bundler examples.Hiroshi SHIBATA2019-08-232-2/+1
| | | | Maybe it has fixed at 5a384e2c08704dc7af9d8d3bdfc475eb8c0723aa
* The investigation is going on...Nobuyoshi Nakada2019-08-211-6/+0
|
* [bundler/bundler] Freeze time to avoid failures at midnightlolwut2019-08-211-2/+7
| | | | | | | | Specify just a string set @built_at as nil before testing https://github.com/bundler/bundler/commit/578ec96c9c
* [bundler/bundler] Share test fixtures with parallel_testsHiroshi SHIBATA2019-08-211-1/+1
| | | | https://github.com/bundler/bundler/commit/a38161c5be
* [bundler/bundler] Try to use RunTimeLogger for parallel_testsHiroshi SHIBATA2019-08-211-0/+5
| | | | https://github.com/bundler/bundler/commit/faccc522d1
* [bundler/bundler] Parallelize test suiteDavid Rodríguez2019-08-214-5/+22
| | | | https://github.com/bundler/bundler/commit/23007cb107
* [bundler/bundler] Fix a couple of typosDavid Rodríguez2019-08-212-2/+2
| | | | https://github.com/bundler/bundler/commit/52b6b94068
* [bundler/bundler] Remove the :ruby exclusion tagDavid Rodríguez2019-08-211-1/+0
| | | | | | | Our current set of specs is the same for all supported rubies, and we should keep it that way. https://github.com/bundler/bundler/commit/c9dc0f6f2c
* [bundler/bundler] Remove another 1.8.7 specific bitDavid Rodríguez2019-08-211-5/+0
| | | | https://github.com/bundler/bundler/commit/8c7942d2c6
* [bundler/bundler] Remove old rubies stuff no longer neededDavid Rodríguez2019-08-211-1/+1
| | | | https://github.com/bundler/bundler/commit/36fb3287f4
* Investigation of a sporadic error at Github ActionsNobuyoshi Nakada2019-08-201-0/+6
|
* Fix some bundler specs (#2380)David Rodríguez2019-08-2020-45/+66
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * These seem to consistenly pass already * Show actual command when running `make test-bundler` Current the setup command that installs the necessary gems for testing bundler was printed, but not the actual command that runs the tests. That was a bit confusing. * Borrow trick from setproctitle specs * A title that long doesn't get set sometimes No idea why, but the test doesn't need that the title is that long. * Fix most gem helper spec ruby-core failures * Fix the rest of the gem helper failures * Fix version spec by improving the assertion * Remove unnecessary `BUNDLE_RUBY` environment var We can use `RUBY` when necessary, and `BUNDLE_RUBY` is not a good name because bundler considers `BUNDLE_*` variables as settings. * Rename `BUNDLE_GEM` to `GEM_COMMAND` This is more descriptive I think, and also friendlier for bundler because `BUNDLE_` env variables are interpreted by bundler as settings, and this is not a bundler setting. This fixes one bundler spec failure in config specs against ruby-core. * Fix quality spec when run in core Use the proper path helper. * Fix dummy lib builder to never load default gems If a dummy library is named as a default gem, when requiring the library from its executable, the default gem would be loaded when running from core, because in core all default gems share path with bundler, and thus they are always in the $LOAD_PATH. We fix the issue by loading lib relatively inside dummy lib executables. * More exact assertions Sometimes I have the problem that I do some "print debugging" inside specs, and suddently the spec passes. This happens when the assertion is too relaxed, and the things I print make it match, specially when they are simple strings like "1.0" than can be easily be part of gem paths that I print for debugging. I fix this by making a more exact assertion. * Detect the correct shebang when ENV["RUBY"] is set * Relax assertion So that the spec passes even if another paths containing "ext" are in the load path. This works to fix a ruby-core issue, but it's a better assertion in general. We just want to know that the extension path was added. * Use folder structure independent path helper It should fix this spec for ruby-core. * Fix the last failing spec on ruby-core * Skip `bundle open <default_gem>` spec when no default gems
* Skip open_spec.rb:L95 because ruby repo doesn't have json as default gems.Hiroshi SHIBATA2019-08-181-1/+1
|
* [bundler/bundler] Remove unnecessary requireDavid Rodríguez2019-08-181-1/+0
| | | | https://github.com/bundler/bundler/commit/8ef571ed4e
* [bundler/bundler] No need to activate the `fileutils` default gemDavid Rodríguez2019-08-183-11/+3
| | | | | | | The version we're vendoring actually relaxed this restriction back to 2.3.0+, so we can always use the vendored version. https://github.com/bundler/bundler/commit/d366cbfe5d
* [bundler/bundler] Remove unnecessary rubygems monkeypatchDavid Rodríguez2019-08-1811-48/+48
| | | | | | | Instead, make sure we always load the local copy of bundler during specs, and never end up using the default copy. https://github.com/bundler/bundler/commit/ac655ffeda
* [bundler/bundler] Don't use system bundler on this specDavid Rodríguez2019-08-181-4/+2
| | | | | | | | | | | | | | | | | | | | | | If we use system bundler, when booting the "outermost" bundler process, bundler will save the path to the system bundler in BUNDLE_BIN_PATH, and use it again when booting the "innermost" bundler process (`bundle exec echo foo`). That means that second process will use the system bundler path again. However, we have `-rsupport/hax` in RUBYOPT, so that file will load from the local copy of bundler, and that file will load `bundler/version` from the project (not from system), because -Ilib is in the LOAD_PATH. That will end up causing redefinition errors because the same constant will be loaded from two different locations. In general, this is expected behavior, normally you will wrap the process with `Bundler.with_original_env` to reset the environment. However, the easiest fix here is to not use system bundler, because it's not really necessary and thus doesn't help the readability of the spec. https://github.com/bundler/bundler/commit/a3d72a34ab
* [bundler/bundler] Fix spec using the deprecated `bundle config` modeDavid Rodríguez2019-08-181-1/+1
| | | | https://github.com/bundler/bundler/commit/789dd1864f
* [bundler/bundler] Remove a bunch of unneeded rubygems requiresDavid Rodríguez2019-08-183-20/+0
| | | | https://github.com/bundler/bundler/commit/f9cb39e614
* [bundler/bundler] Fix open default gem errorZehan Zhao2019-08-181-0/+13
| | | | https://github.com/bundler/bundler/commit/792d724752
* [bundler/bundler] Wrap `open` specs with a contextDavid Rodríguez2019-08-181-69/+71
| | | | | | So I can add another context that doesn't run the `before` block. https://github.com/bundler/bundler/commit/06d0acc45a
* [bundler/bundler] Prefer `before` to `before :each`David Rodríguez2019-08-181-1/+1
| | | | https://github.com/bundler/bundler/commit/6678747fae
* [bundler/bundler] Fix `bundle doctor` commandDavid Rodríguez2019-08-181-2/+8
| | | | | | | | | | | | | | Previously `bundle doctor` would fail on any bundle that does not include git gems or plugins. This is because the previously used `Bundler.home` does not exist unless the bundle includes git gems or plugins. For example, with `bundle config set path .bundle`, it points to which does not exist unless this kind of gems exist in the Gemfile. The name `Bundler.home` is really unfortunate, it should probably be have more descriptive name, and be private. But for now I just want to make `bundle doctor` usable. https://github.com/bundler/bundler/commit/5531a18c1e
* [bundler/bundler] Bundler displays a duplicate gem entries warning even if ↵David Stosik2019-08-181-2/+2
| | | | | | gems only appear once per group https://github.com/bundler/bundler/commit/d18a83109e
* [bundler/bundler] Extract a `gemspec_dir` helperDavid Rodríguez2019-08-172-2/+5
| | | | https://github.com/bundler/bundler/commit/71a29e286a
* [bundler/bundler] Extract yet another helper methodDavid Rodríguez2019-08-172-20/+19
| | | | https://github.com/bundler/bundler/commit/948a863bd8
* [bundler/bundler] Extract a `root_gemspec` local variableDavid Rodríguez2019-08-171-3/+4
| | | | https://github.com/bundler/bundler/commit/a4beba4cbf
* [bundler/bundler] Extract a `with_root_gemspec` helperDavid Rodríguez2019-08-173-14/+14
| | | | https://github.com/bundler/bundler/commit/f20c2bdf6a
* [bundler/bundler] Only chdir when necessaryDavid Rodríguez2019-08-171-16/+14
| | | | https://github.com/bundler/bundler/commit/07161ebc1a
* [bundler/bundler] Make sure gem has been built before deleteng itDavid Rodríguez2019-08-171-11/+13
| | | | https://github.com/bundler/bundler/commit/32520c7020
* [bundler/bundler] Cleanup in a location independent wayDavid Rodríguez2019-08-171-1/+1
| | | | https://github.com/bundler/bundler/commit/5b503a4bf1
* [bundler/bundler] Remove obvious commentDavid Rodríguez2019-08-171-1/+0
| | | | https://github.com/bundler/bundler/commit/91e7fe1b2f
* [bundler/bundler] Remve another unneeded `to_s`David Rodríguez2019-08-171-1/+1
| | | | | | `FileUtils.rm` supports a `Pathname` argument. https://github.com/bundler/bundler/commit/7d982a5be9
* [bundler/bundler] Remove unneeded `to_s` callsDavid Rodríguez2019-08-172-3/+3
| | | | | | They are implicit inside `gem_command!`. https://github.com/bundler/bundler/commit/6bdb13c899
* [bundler/bundler] Consistently use `Path` over `Spec::Path`David Rodríguez2019-08-171-1/+1
| | | | https://github.com/bundler/bundler/commit/a4cca66b79
* [bundler/bundler] Extract single gem installation logicDavid Rodríguez2019-08-171-3/+7
| | | | https://github.com/bundler/bundler/commit/7888d621c8
* [bundler/bundler] Unalias `install_gem`David Rodríguez2019-08-172-3/+1
| | | | | | Since I plan to reuse it for something else. https://github.com/bundler/bundler/commit/5379382198
* [bundler/bundler] Use `join` consistentlyDavid Rodríguez2019-08-171-1/+1
| | | | https://github.com/bundler/bundler/commit/096e53dfe6
* [bundler/bundler] Extract a `lib_tracked_files` path helperDavid Rodríguez2019-08-172-4/+4
| | | | https://github.com/bundler/bundler/commit/028dc46f5a
* [bundler/bundler] Rename a variableDavid Rodríguez2019-08-171-4/+4
| | | | | | Otherwise I get conflicts when extracting the helper. https://github.com/bundler/bundler/commit/314c64cd07
* [bundler/bundler] Extract a `tracked_files` path helperDavid Rodríguez2019-08-172-4/+4
| | | | https://github.com/bundler/bundler/commit/d35e31d2e0