aboutsummaryrefslogtreecommitdiffstats
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
...
* [rubygems/rubygems] Don't discard candidates matching ruby metadataDavid Rodríguez2022-08-022-4/+65
| | | | | | | | | | Do dependency filtering and materialization in one step. Before, dependency filtering would not consider ruby metadata so it would discard variants that end up not being materializable in the end. https://github.com/rubygems/rubygems/commit/0c0d40d417 Co-authored-by: Ian Ker-Seymer <ian.kerseymer@shopify.com>
* [rubygems/rubygems] Fix crash when running `bundle outdated` in debug modeDavid Rodríguez2022-08-011-0/+12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Previously it would crash like this: ```` $ /Users/deivid/.asdf/installs/ruby/3.1.2/bin/ruby -I/Users/deivid/Code/rubygems/rubygems/bundler/spec -r/Users/deivid/Code/rubygems/rubygems/bundler/spec/support/artifice/fail.rb -r/Users/deivid/Code/rubygems/rubygems/bundler/spec/support/hax.rb /Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/system/bin/bundle outdated --patch --strict --filter-patch Running `bundle outdated --filter-patch --patch --strict` with bundler 2.4.0.dev Found changes from the lockfile, re-resolving dependencies because bundler is unlocking Using a local server, bundler won't use the CompactIndex API Fetching source index from file:///Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/remote4/ Resolving dependencies... --- ERROR REPORT TEMPLATE ------------------------------------------------------- ``` RuntimeError: LazySpecification has not been materialized yet (calling :loaded_from []) /Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/system/gems/bundler-2.4.0.dev/lib/bundler/lazy_specification.rb:147:in `method_missing' /Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/system/gems/bundler-2.4.0.dev/lib/bundler/cli/outdated.rb:214:in `gem_column_for' /Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/system/gems/bundler-2.4.0.dev/lib/bundler/cli/outdated.rb:174:in `block in print_gems_table' /Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/system/gems/bundler-2.4.0.dev/lib/bundler/cli/outdated.rb:173:in `map' /Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/system/gems/bundler-2.4.0.dev/lib/bundler/cli/outdated.rb:173:in `print_gems_table' /Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/system/gems/bundler-2.4.0.dev/lib/bundler/cli/outdated.rb:123:in `run' /Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/system/gems/bundler-2.4.0.dev/lib/bundler/cli.rb:420:in `outdated' /Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/system/gems/bundler-2.4.0.dev/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run' /Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/system/gems/bundler-2.4.0.dev/lib/bundler/vendor/thor/lib/thor/invocation.rb:127:in `invoke_command' /Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/system/gems/bundler-2.4.0.dev/lib/bundler/vendor/thor/lib/thor.rb:392:in `dispatch' /Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/system/gems/bundler-2.4.0.dev/lib/bundler/cli.rb:31:in `dispatch' /Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/system/gems/bundler-2.4.0.dev/lib/bundler/vendor/thor/lib/thor/base.rb:485:in `start' /Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/system/gems/bundler-2.4.0.dev/lib/bundler/cli.rb:25:in `start' /Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/system/gems/bundler-2.4.0.dev/exe/bundle:48:in `block in <top (required)>' /Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/system/gems/bundler-2.4.0.dev/lib/bundler/friendly_errors.rb:120:in `with_friendly_errors' /Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/system/gems/bundler-2.4.0.dev/exe/bundle:36:in `<top (required)>' /Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/system/bin/bundle:25:in `load' /Users/deivid/Code/rubygems/rubygems/bundler/tmp/1/gems/system/bin/bundle:25:in `<main>' ``` ```` https://github.com/rubygems/rubygems/commit/23c46f3b57
* [rubygems/rubygems] Fix comment incorrectly copied from another specDavid Rodríguez2022-08-011-2/+1
| | | | https://github.com/rubygems/rubygems/commit/9be5eae9cf
* [rubygems/rubygems] Make `--standalone` play nice with `--local`David Rodríguez2022-07-301-0/+28
| | | | | | | | I'm not sure if using relative paths in the generated script is best for this case, since it makes the script not movable, but that can be improved later. https://github.com/rubygems/rubygems/commit/7f5bdbb842
* Merge rubygems master from ↵Hiroshi SHIBATA2022-07-2911-44/+85
| | | | https://github.com/rubygems/rubygems/commit/446cc57a7ccdf1924deb291be9571219e7ba8523
* Update to ruby/spec@cbfaf51Benoit Daloze2022-07-2741-54/+526
|
* Update to ruby/mspec@290e36aBenoit Daloze2022-07-271-0/+10
|
* [rubygems/rubygems] Add ignore_funding_requests config flagmoe2022-07-271-0/+27
| | | | https://github.com/rubygems/rubygems/commit/ab302f72c9
* [rubygems/rubygems] Use main as default branch for Bundler specsDavid Rodríguez2022-07-2715-61/+62
| | | | https://github.com/rubygems/rubygems/commit/482077d185
* Merge rubygems/bundler HEADHiroshi SHIBATA2022-07-267-17/+88
| | | | Merge from https://github.com/rubygems/rubygems/commit/2af2520b4a7ab1c6eb1fdc3d2ef4d8c062d96ad7
* Do not chomp trailing line separator IO#each with nil separator and chompJeremy Evans2022-07-211-4/+14
| | | | | | | nil separator means no sepator, so chomp should not remove a line separator. Partially Fixes [Bug #18770]
* Do not have class/module keywords look up ancestors of ObjectJeremy Evans2022-07-211-3/+12
| | | | | | | | Fixes case where Object includes a module that defines a constant, then using class/module keyword to define the same constant on Object itself. Implements [Feature #18832]
* [rubygems/rubygems] Bundler: change error/warning message for multiple ↵Takuya Noguchi2022-07-191-3/+3
| | | | | | | | global sources Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com> https://github.com/rubygems/rubygems/commit/316564b8fc
* [rubygems/rubygems] Improve error message when gems cannot be foundDavid Rodríguez2022-07-181-2/+2
| | | | | | Include the source of each gem. https://github.com/rubygems/rubygems/commit/a0bed2fb79
* [rubygems/rubygems] bundler: fix typo in inline RuboCop configTakuya Noguchi2022-07-171-1/+1
| | | | | | Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com> https://github.com/rubygems/rubygems/commit/e11f5a143b
* [rubygems/rubygems] Show a proper error if extension dir is not writableDavid Rodríguez2022-07-171-0/+30
| | | | | | Instead of showing the bug report template. https://github.com/rubygems/rubygems/commit/0c8b6f7dd5
* [rubygems/rubygems] Fix misleading error if compact index cannot be copiedDavid Rodríguez2022-07-141-0/+19
| | | | | | | | | | | | | | | | | | | | | | | | | | | Previously if `~/.bundle/cache/compact_index/rubygems.org.*/version` were owned by root with read-only access, `bundle install` would fail with a misleading error message. For example: ``` There was an error while trying to write to `/tmp/bundler-compact-index-20220711-1823-npllre/versions`. It is likely that you need to grant write permissions for that path. ``` This happened because the EACCESS error was caught by `SharedHelpers.filesystem_access`, which makes it look like the target directory is at fault instead of the source. We can't simply drop this guard because that causes the opposite problem: the permission error appears to come from the source instead of the target, since `CompactIndexClient::Cache#lines` also wraps read access errors. Instead, bring a minimal implementation of `FileUtils.cp` and nest calls to `SharedHelpers.filesystem_access` properly. https://github.com/rubygems/rubygems/commit/320822c070 Co-authored-by: Stan Hu <stanhu@gmail.com>
* Merge RubyGems and Bundler masterHiroshi SHIBATA2022-07-1321-164/+394
|
* [rubygems/rubygems] Fix `simulate_windows` helperDavid Rodríguez2022-07-082-0/+8
| | | | | | | It should also set the proper class variable so that `Gem.win_platform?` returns true. https://github.com/rubygems/rubygems/commit/0fbf6904d1
* [rubygems/rubygems] Account for default gems not having remote when cachingDavid Rodríguez2022-07-021-0/+12
| | | | https://github.com/rubygems/rubygems/commit/b93d4de2ff
* Relax `not_before` limitNobuyoshi Nakada2022-07-021-1/+1
| | | | Use the value as similar as other tests below. Trying to fix sporadic “not yet valid” failures on some CIs.
* Fix TODO in stringio/truncate_spec.rbNobuyoshi Nakada2022-07-011-12/+3
|
* stop CI failures.Koichi Sasada2022-07-011-2/+3
| | | | | | 302f353fd9223d020e48495eaa7a03ce5d539409 seems break the rubyspec. @nobu please check it.
* Add more check to debug failuresKazuhiro NISHIYAMA2022-06-301-1/+1
|
* [rubygems/rubygems] Print error messages just once in verbose modeDavid Rodríguez2022-06-272-11/+30
| | | | | | | | | When running a command with the `--verbose` flag that ends up raising a `BundlerError`, Bundler will unnecessarily print the error twice. This commit fixes the issue by removing the duplicate logging. https://github.com/rubygems/rubygems/commit/689004a164
* Fix Process.clock_gettime specs on OpenBSDJeremy Evans2022-06-261-1/+3
|
* Update to ruby/spec@ab32a1aBenoit Daloze2022-06-2674-318/+1195
|
* Update to ruby/mspec@78b5d86Benoit Daloze2022-06-268-11/+69
|
* [rubygems/rubygems] Fix pending Bundler specsDavid Rodríguez2022-06-269-12/+16
| | | | | | | | | | | | | | | | | | | When testing under the ruby/ruby setup, mkmf.rb needs to the `$extout` global variable set properly. This is because, in this particular case, the `ruby.h` header needed to compile extensions is constructed from `$(extout)/include($arch)/ruby/config.h` but `$extout` is not set by default. I tried to fix this in mkmf.rb itself but I couldn't figure it. But setting it externally to workaround the issue fixes the specs, so I'll start with that. Also setting it externally causes issues when running specs upstream against Ruby 2.3 (I guess because of some difference with Ruby 2.3 mkmf.rb implementation). So I'm avoiding doing it on Ruby 2.3 to woraround that. https://github.com/rubygems/rubygems/commit/d782984585
* Sync RubyGems & Bundler with upstream repoDavid Rodríguez2022-06-243-14/+14
|
* [rubygems/rubygems] Fix standalone script generation for statically linked ↵David Rodríguez2022-06-231-5/+23
| | | | | | dev ruby https://github.com/rubygems/rubygems/commit/4d0d7b3c97
* [rubygems/rubygems] Fix `bundle package --no-install` no longer skipping installDavid Rodríguez2022-06-231-1/+1
| | | | | | | | | | | | This is a regression from https://github.com/rubygems/rubygems/commit/cf749f8ffabd. The funny thing is that we have a spec for this feature, so it was unclear how we regressed here. It turns out there was a bug in one of our negative matchers checking that gems ARE NOT included in a bundle. This commit fixes the bug in the negative matcher and reverts https://github.com/rubygems/rubygems/commit/cf749f8ffabd (with a slightly simpler diff). https://github.com/rubygems/rubygems/commit/3f9a4ff32a
* [Feature #18788] Spec for options as `String` to `Regexp.new`Nobuyoshi Nakada2022-06-201-0/+39
| | | | Co-Authored-By: Janosch Müller <janosch.mueller@betterplace.org>
* Spec update for warnning suspicious flag to `Regexp.new`Nobuyoshi Nakada2022-06-201-6/+31
|
* [rubygems/rubygems] Fix extension paths in generated standalone scriptcitrusmoose2022-06-201-1/+2
| | | | | | | | | The paths for extensions of gems would contain the hardcoded ruby version on which the extension was built. This will replace it with runtime ruby version like the parent version directory. It will make the standalone script compatible between different ruby version installations. https://github.com/rubygems/rubygems/commit/a9dae93d5d
* [Bug #18813] Warn when autoload has to lookup in parent namespaceJean Boussier2022-06-181-0/+30
| | | | This is a verbose mode only warning.
* [rubygems/rubygems] Unset ENV set by official Ruby docker imagesDavid Rodríguez2022-06-171-0/+2
| | | | | | So that it does not interfere with our specs. https://github.com/rubygems/rubygems/commit/1029714e21
* Fix spec version guardAlan Wu2022-06-161-1/+1
| | | | Follow up for 278fefb96294adf9d27a78f919c714a31b65ef58
* ENV.merge! support multile arguments [Feature #18279]Nobuyoshi Nakada2022-06-171-0/+9
|
* [rubygems/rubygems] Revert "Support running specs with asdf version manager"David Rodríguez2022-06-151-10/+1
| | | | | | This reverts commit https://github.com/rubygems/rubygems/commit/4b2d09af5bc7. https://github.com/rubygems/rubygems/commit/90ca7a7163
* [rubygems/rubygems] Support running specs with asdf version managerDavid Rodríguez2022-06-151-1/+10
| | | | | | | | | | The `asdf-ruby` plugin sets `RUBYLIB` to require some code to reshim after installing gems. This interferes with our specs. Reset that, but leave any "internal" entries in places, because the ruby-core test setup also uses RUBYLIB. https://github.com/rubygems/rubygems/commit/4b2d09af5b
* [rubygems/rubygems] Don't on gemspecs with invalid `require_paths`, just warnDavid Rodríguez2022-06-121-1/+11
| | | | | | | | | | | | | | | | | These gemspecs already work most of the times. When they are installed normally, the require_paths in the gemspec stub line becomes actually correct, and the incorrect value in the real gemspec is ignored. It only becomes an issue in standalone mode. In Ruby 3.2, `Kernel#=~` has been removed, and that means that it becomes harder for us to gracefully deal with this error in standalone mode, because it now happens earlier due to calling `Array#=~` for this invalid gemspec (since require_paths is incorrectly an array of arrays). The easiest way to fix this is to actually make this just work instead by automatically fixing the issue when reading the packaged gemspec. https://github.com/rubygems/rubygems/commit/d3f2fe6d26
* [rubygems/rubygems] Relax performance spec limitDavid Rodríguez2022-06-071-1/+1
| | | | https://github.com/rubygems/rubygems/commit/eab417d0ce
* [rubygems/rubygems] Add test cases from SHA1 RFC and improve test failure ↵David Rodríguez2022-06-021-2/+9
| | | | | | | | | | message I found that the current test cases did not cover the bitwise AND performed on modified words after each iteration (https://github.com/rubygems/rubygems/blob/7e5765a66c9fe5187b167f619f34db5db121f2df/bundler/lib/bundler/digest.rb#L50) https://github.com/rubygems/rubygems/commit/c8de819fee
* [rubygems/rubygems] Remove leftover debugging putsDavid Rodríguez2022-06-021-1/+0
| | | | https://github.com/rubygems/rubygems/commit/7c6f15040d
* [rubygems/rubygems] Fix `bundle remove` by invalidating cached ↵Ellen Marie Dash2022-06-011-0/+30
| | | | | | | | | | | | `Bundle.defintion`. Prior to this commit, `bundle add GEM_NAME` updated the lockfile, but `bundle remove GEM_NAME` left GEM_NAME in the lockfile. By invalidating the cached `Bundle.definition`, the existing code handles that without a problem. https://github.com/rubygems/rubygems/commit/aa0794d6a9
* [rubygems/rubygems] Fix generated standalone script for default gemsDavid Rodríguez2022-06-011-1/+8
| | | | | | | | | | | The installer is actually rewriting the spec's full gem path to be the one of the newly installed gem, however the accessor was not properly working for `StubSpecification` instances, and default gems are always of this type, because they are always present locally. Fix the accessor to properly update the underlying full specification. https://github.com/rubygems/rubygems/commit/efa41babfa
* [rubygems/rubygems] Skip duplicated dependency warning for gemspec dev depsDavid Rodríguez2022-06-011-0/+26
| | | | | | | | | | | Generally this warning is skipped for gemspec development dependencies. I think because it's common to override them in the Gemfile to change the source, for example. But the order of conditions was not correct and the warning was still being printed in one case. https://github.com/rubygems/rubygems/commit/da9d1d6a3f
* [rubygems/rubygems] Give better conflict resolution adviceDavid Rodríguez2022-05-311-3/+64
| | | | | | | | This alternative really uses only the Gemfile, and can never end up being absurd, because it will never be suggested when there's no lockfile, and it suggests deleting the lockfile. https://github.com/rubygems/rubygems/commit/5d154dd50e
* [rubygems/rubygems] Fix crash when commenting out a mirror in configurationDavid Rodríguez2022-05-301-0/+28
| | | | https://github.com/rubygems/rubygems/commit/2d99277328