aboutsummaryrefslogtreecommitdiffstats
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* Update to ruby/mspec@9f83eeaBenoit Daloze2023-11-271-7/+23
|
* Opaque Etags for compact index requestsJosef Šimánek2023-11-2710-45/+414
| | | | | | | | | | | | | This changes the CompactIndexClient to store etags received from the compact index in separate files rather than relying on the MD5 checksum of the file as the etag. Smoothes the upgrade from md5 etags to opaque by generating them when no etag file exists. This should reduce the initial impact of changing the caching behavior by reducing cache misses when the MD5 etag is the same. Eventually, the MD5 behavior should be retired and the etag should be considered completely opaque with no assumption that MD5 would match.
* [rubygems/rubygems] Don't remember `--jobs` flagDavid Rodríguez2023-11-271-0/+10
| | | | https://github.com/rubygems/rubygems/commit/9ab1136036
* [rubygems/rubygems] Fix advice in `bundle install --system` deprecationDavid Rodríguez2023-11-271-1/+1
| | | | https://github.com/rubygems/rubygems/commit/59a66e3560
* [rubygems/rubygems] Avoid some unnecessary quotes in remember flag ↵David Rodríguez2023-11-271-11/+11
| | | | | | deprecation message https://github.com/rubygems/rubygems/commit/3fd627e486
* [rubygems/rubygems] Simplify remembered flags deprecation messageDavid Rodríguez2023-11-271-3/+3
| | | | | | Configuration is now local by default. https://github.com/rubygems/rubygems/commit/6bc7709aa8
* [rubygems/rubygems] Remove no longer necessary workaround for old RubyGemsDavid Rodríguez2023-11-2713-34/+26
| | | | https://github.com/rubygems/rubygems/commit/ed4eaefac0
* [rubygems/rubygems] Reduce allocations when installing gems with bundlerSamuel Giddins2023-11-261-2/+4
| | | | | | | | | | | | | | | | | ``` ==> memprof.after.txt <== Total allocated: 1.13 MB (2352 objects) Total retained: 10.08 kB (78 objects) ==> memprof.before.txt <== Total allocated: 46.27 MB (38439 objects) Total retained: 9.94 kB (75 objects) ``` Yes, we were allocating 45MB of arrays in `dependencies_installed?`, it was accidentally cubic. https://github.com/rubygems/rubygems/commit/13ab874388
* [rubygems/rubygems] Add --json bundle-outdated flag to produce ↵Eric Mueller2023-11-231-0/+21
| | | | | | json-parseable output https://github.com/rubygems/rubygems/commit/65efa44bc0
* [rubygems/rubygems] Fix universal lockfiles regressionDavid Rodriguez2023-11-221-0/+58
| | | | | | | | | | | | If a platform specific variant would not match the current Ruby, we would still be considering it compatible with the initial resolution and adding its platform to the lockfile, but we would later fail to materialize it for installation due to not really being compatible. Fix is to only add platforms for variants that are also compatible with current Ruby and RubyGems versions. https://github.com/rubygems/rubygems/commit/75d1290843
* [rubygems/rubygems] Fix invalid platform removal missing adjacent platformsBo Anderson2023-11-211-0/+1
| | | | https://github.com/rubygems/rubygems/commit/4ce66c41a2
* [rubygems/rubygems] User bundler UA when downloading gemsSamuel Giddins2023-11-157-18/+15
| | | | | | | | | | | | | | | Gem::RemoteFetcher uses Gem::Request, which adds the RubyGems UA. Gem::RemoteFetcher is used to download gems, as well as the full index. We would like the bundler UA to be used whenever bundler is making requests. This PR also avoids unsafely mutating the headers hash on the shared `Gem::RemoteFetcher.fetcher` instance, which could cause corruption or incorrect headers when making parallel requests. Instead, we create one remote fetcher per rubygems remote, which is similar to the connection segregation bundler is already doing https://github.com/rubygems/rubygems/commit/f0e8dacdec
* [rubygems/rubygems] Make sure to `require "rubygems"` explicitlyNobuyoshi Nakada2023-11-132-6/+15
| | | | | | | This is also done in bundler/lib/bundler/rubygems_integration.rb, but bundler/lib/bundler.rb loads this file before it. https://github.com/rubygems/rubygems/commit/8840d8507b
* [rubygems/rubygems] Add a warning in an edge case of using `gemspec` DSLDavid Rodríguez2023-11-131-0/+54
| | | | | | | | | | | | | | | | | | | | | | | | If a Gemfile duplicates a development dependency also defined in a local gemspec with a different requirement, the requirement in the local gemspec will be silently ignored. This surprised me. I think we should either: * Make sure both requirements are considered, like it happens for runtime dependencies (I added a spec to illustrate the current behavior here). * Add a warning that the requirement in the gemspec will be ignored. I think the former is slightly preferable, but it may cause some bundle's that previously resolve to no longer resolver. I went with the latter but the more I think about it, the more this seems like it should behave like the former. https://github.com/rubygems/rubygems/commit/ad6843972f
* [rubygems/rubygems] Let RuboCop target Ruby 3.0David Rodríguez2023-11-133-5/+5
| | | | https://github.com/rubygems/rubygems/commit/70243b1d72
* [rubygems/rubygems] Drop support for Ruby 2.6 and Ruby 2.7 in BundlerDavid Rodríguez2023-11-1318-71/+22
| | | | https://github.com/rubygems/rubygems/commit/93619c97ff
* [rubygems/rubygems] Automatically lock extra ruby platformsDavid Rodríguez2023-11-136-41/+166
| | | | | | | | | | | | | | | | | | | | | | | | | Since we started locking the specific platform in the lockfile, that has created an annoying situation for users that don't develop on Linux. They will create a lockfile on their machines, locking their local platform, for example, darwin. But then that lockfile won't work automatically when deploying to Heroku for example, because the lockfile is frozen and the Linux platform is not included. There's the chance though that resolving against two platforms (Linux + the local platform) won't succeed while resolving for just the current platform will. So, instead, we check other platform specific variants available for the resolution we initially found, and lock those platforms and specs too if they satisfy the resolution. This is only done when generating new lockfiles from scratch, existing lockfiles should keep working as before, and it's only done for "ruby platforms", i.e., not Java or Windows which have their own complexities, and so are excluded. With this change, we expect that MacOS users can bundle locally and deploy to Heroku without needing to do anything special. https://github.com/rubygems/rubygems/commit/5f24f06bc5
* [rubygems/rubygems] Refactor platform test helpersDavid Rodriguez2023-11-134-9/+14
| | | | https://github.com/rubygems/rubygems/commit/7ab4c203f9
* [rubygems/rubygems] Remove unused `SpecSet#merge`David Rodríguez2023-11-131-18/+0
| | | | https://github.com/rubygems/rubygems/commit/53e0490b55
* IO#read always check the provided buffer is mutableJean Boussier2023-11-091-0/+26
| | | | Otherwise you can have work in some circumstance but not in others.
* [rubygems/rubygems] Fix daily Bundler CIDavid Rodríguez2023-11-091-2/+2
| | | | | | | | | | Daily Bundler CI against ruby-head is failing because ruby-head now uses bigdecimal 3.1.5, so that gets locked by this spec. This change should make the test stable until bigdecimal 99.1.5 is bundled with Ruby :) https://github.com/rubygems/rubygems/commit/830326041f
* [rubygems/rubygems] Explicitly pass install-dir when installing system gems ↵David Rodríguez2023-11-091-8/+8
| | | | | | | | | | | | in Bundler specs We want to avoid any "user home" fallbacks, since that won't work with Bundler. So if there's a permissions issue during specs, it's best to raise immediately. https://github.com/rubygems/rubygems/commit/767a3e7533
* [rubygems/rubygems] No need to let this command failDavid Rodríguez2023-11-091-1/+1
| | | | | | This command is not expected to fail. If it fails, we can stop the test. https://github.com/rubygems/rubygems/commit/2511a5b093
* [rubygems/rubygems] Remove unused logicDavid Rodríguez2023-11-091-3/+1
| | | | https://github.com/rubygems/rubygems/commit/2eb2860e9e
* Add foo.gemspec for failing testPeter Zhu2023-11-081-0/+13
| | | | | | | foo.gemspec was added in rubygems/rubygems@8d699ed096960ed9a6636bd27143952ff5f8addc but was not sync'd in commit b4bf8c9ee2d716adf5fc08e67c4b26d6a8f929c2. This causes the spec to fail.
* [rubygems/rubygems] Ensure we are using the same extension dirHan Young2023-11-081-0/+11
| | | | | | | | Since #6945 the extension dir changed to Gem::BasicSpecification's implementation, we didn't hook that in rubygems_ext.rb. So for universal rubies, we ended up using the universal platform name when installing, but arch replaced platform name when checking. This lead to native extensions can never be correctly installed on universal rubies. Hook Gem::BasicSpecifications so the behavior is consistent on installing and checking. https://github.com/rubygems/rubygems/commit/8d699ed096
* Escape the target string to be checkedNobuyoshi Nakada2023-11-081-3/+1
| | | | | | | | | Comparing file paths as strings may not work well for some reasons, symlink, relative `__FILE__`, etc. Some alternatives are possible: comparing with `File.realpath`, or with `File.identical?`, it should be most robust to escape the target string contained within this file itself.
* [rubygems/rubygems] Simplify spec wording and implementationDavid Rodríguez2023-11-081-17/+2
| | | | https://github.com/rubygems/rubygems/commit/3e7f1379fb
* [rubygems/rubygems] Better error when having an insecure install folderDavid Rodríguez2023-11-082-18/+30
| | | | https://github.com/rubygems/rubygems/commit/e41156e272
* [rubygems/rubygems] Don't show bug report template when GEM_HOME has no ↵David Rodríguez2023-11-081-0/+35
| | | | | | | | | | | | | | | | | | | | writable bit Instead, don't check that at all and proceed. If something fails to be written inside GEM_HOME, we'll eventually fail with a proper permissions error. In addition to that, the writable bit in GEM_HOME is not even reliable, because only the immediate parent is actually checked when writing. For example, ``` $ mkdir -p foo/bar $ chmod -w foo $ touch foo/bar/baz # writes without issue ``` https://github.com/rubygems/rubygems/commit/4bced7ac73
* Skip example for 07df8a5d5ee725eee00632717ea4deead5fc783bHiroshi SHIBATA2023-11-071-7/+9
|
* Fix the CI failure in OpenBSDYusuke Endoh2023-11-061-1/+1
| | | | | | | | | | | LibreSSL seems not to support `scrypt`. https://rubyci.s3.amazonaws.com/openbsd-current/ruby-master/log/20231105T233005Z.fail.html.gz ``` 1) OpenSSL::KDF.scrypt creates the same value with the same input ERROR NoMethodError: undefined method `scrypt' for module OpenSSL::KDF ```
* [rubygems/rubygems] Only remove bundler plugin gem when it's inside the cacheCody Cutrer2023-10-311-0/+25
| | | | https://github.com/rubygems/rubygems/commit/8d51390ca4
* Disable wrong testNobuyoshi Nakada2023-10-311-1/+2
|
* Missing format stringNobuyoshi Nakada2023-10-311-1/+1
| | | | | Do not use a variable as a format string. Also we usually don't expect non-ascii data in C string literals.
* Update to ruby/spec@d56bd0fBenoit Daloze2023-10-301-202/+204
|
* Update to ruby/mspec@d03ad9cBenoit Daloze2023-10-301-4/+6
|
* Revert "OpenSSL::KDF.scrypt needs EVP_PBE_scrypt()"Benoit Daloze2023-10-301-2/+0
| | | | This reverts commit d434765faead1583ca9008bb579067a288085b93.
* OpenSSL::KDF.scrypt needs EVP_PBE_scrypt()Nobuyoshi Nakada2023-10-311-0/+2
|
* Update to ruby/spec@bd7017fBenoit Daloze2023-10-3088-289/+1634
|
* [rubygems/rubygems] Relax matching pattern for rake versionHiroshi SHIBATA2023-10-301-3/+3
| | | | https://github.com/rubygems/rubygems/commit/a89f74c27e
* Windows: Prefer USERPROFILE over HOMEPATHLars Kanis2023-10-261-14/+13
| | | | | | Enable the test commented out in ruby/ruby@d0f5dc9eac78ecade459. Extracted from GH-7033, that is for initialization at start up time and this test is unrelated to it.
* [rubygems/rubygems] Handle CI configuration on ignore list for ↵Hiroshi SHIBATA2023-10-251-0/+18
| | | | | | Gem::Specification#files https://github.com/rubygems/rubygems/commit/4bb0ef3e55
* [rubygems/rubygems] Handle empty arrayHiroshi SHIBATA2023-10-241-0/+26
| | | | https://github.com/rubygems/rubygems/commit/7c0afdd9af
* [rubygems/rubygems] Handle base64 encoded checksums in lockfile for future ↵Martin Emde2023-10-235-17/+54
| | | | | | | | compatibility. Save checksums using = as separator. https://github.com/rubygems/rubygems/commit/a36ad7d160
* [rubygems/rubygems] Improve errors and register checksums reliablyMartin Emde2023-10-2312-107/+277
| | | | | | | | | | | | Improve error reporting for checksums, raises a new error class. Solve for multi-source checksum errors. Add CHECKSUMS to tool/bundler/(dev|standard|rubocop)26_gems.rb https://github.com/rubygems/rubygems/commit/26ceee0e76 Co-authored-by: Samuel Giddins <segiddins@segiddins.me>
* [rubygems/rubygems] Refactor Checksum classes and methods to reduceMartin Emde2023-10-2316-125/+192
| | | | | | | code. (https://github.com/rubygems/rubygems/pull/6917) https://github.com/rubygems/rubygems/commit/2238bdaadc
* [rubygems/rubygems] Refactor to checksums stored via sourceSamuel Giddins2023-10-2316-97/+195
| | | | | | | | | | | | | | | | | | | | This gets the specs passing, and handles the fact that we expect checkums to be pinned only to a particular source This also avoids reading in .gem files during lockfile generation, instead allowing us to query the source for each resolved gem to grab the checksum Finally, this opens up a route to having user-stored checksum databases, similar to how other package managers do this! Add checksums to dev lockfiles Handle full name conflicts from different original_platforms when adding checksums to store from compact index Specs passing on Bundler 3 https://github.com/rubygems/rubygems/commit/86c7084e1c
* [rubygems/rubygems] Use the server checksum, then calculate from gem on disk ↵Mercedes Bernard2023-10-2311-7/+203
| | | | | | | | | | | | | | | | | | | | | | if possible 1. Use the checksum provided by the server if provided: provides security knowing if the gem you downloaded matches the gem on the server 2. Calculate the checksum from the gem on disk: provides security knowing if the gem has changed between installs 3. In some cases, neither is possible in which case we don't put anything in the checksum and we maintain functionality as it is today Add the checksums to specs in the index if we already have them Prior to checksums, we didn't lose any information when overwriting specs in the index with stubs. But now when we overwrite EndpointSpecifications or RemoteSpecifications with more generic specs, we could lose checksum info. This manually sets checksum info so we keep it in the index. https://github.com/rubygems/rubygems/commit/de00a4f153
* [rubygems/rubygems] Add CHECKSUMS for each gem in lockfileThong Kuah2023-10-2324-20/+642
| | | | | | | | | | | | | We lock the checksum for each resolved spec under a new CHECKSUMS section in the lockfile. If the locked spec does not resolve for the local platform, we preserve the locked checksum, similar to how we preserve specs. Checksum locking only makes sense on install. The compact index information is only available then. https://github.com/rubygems/rubygems/commit/bde37ca6bf
generated by cgit v1.2.3 (git 2.39.1) at 2024-07-15 13:40:23 +0000