aboutsummaryrefslogtreecommitdiffstats
path: root/spec
Commit message (Collapse)AuthorAgeFilesLines
* [rubygems/rubygems] https functionality was merged into `net/https`David Rodríguez2020-07-311-5/+0
| | | | https://github.com/rubygems/rubygems/commit/d81ce9e457
* Fix arity of Hash#to_proc [Bug #12671]Benoit Daloze2020-07-291-0/+4
|
* Use https instead of httpKazuhiro NISHIYAMA2020-07-283-6/+6
|
* Do not assume all compilers accept same flags as gccNobuyoshi Nakada2020-07-281-1/+1
|
* Update to ruby/spec@07164daBenoit Daloze2020-07-2738-44/+733
|
* Update to ruby/mspec@9cffee9Benoit Daloze2020-07-271-1/+4
|
* Switch reserved for numbered parameter warning to SyntaxErrorJeremy Evans2020-07-221-10/+29
|
* Make StringIO encoding fixedNobuyoshi Nakada2020-07-202-3/+3
| | | | Get rid of affects by default external encoding.
* Import remaining changesDavid Rodríguez2020-07-154-39/+54
| | | | | The "sync with commits" scripts failed to properly import these for some reason.
* [rubygems/rubygems] Tag the specs with :readlineUtkarsh Gupta2020-07-151-5/+5
| | | | | | | | | | | | The newly added specs needs to be tagged as :readline, otherwise they fail on Windows with the backtrace: `ZeroDivisionError: divided by 0`. Such issues are already being skipped on Windows. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/391f860af4
* [rubygems/rubygems] Add tests with different flag combinationsUtkarsh Gupta2020-07-151-11/+44
| | | | | | | | | | | Since this PR was made because we missed checking RuboCop offenses with different flags, therefore adding tests so that all flag combinations are tested. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/d08250efc2
* [rubygems/rubygems] Allow setting a tag prefix to be used by gem release tasksDavid Rodríguez2020-07-151-0/+17
| | | | https://github.com/rubygems/rubygems/commit/679008f23a
* [rubygems/rubygems] Fix line spacing to make Layout/EmptyLines happyUtkarsh Gupta2020-07-151-1/+1
| | | | | | | | | | | | | The Gemfile wasn't properly put in the last commit. As a result, Layout/EmptyLines inspected an offense in the Gemfile. This also fixes the spec w.r.t change in the task default. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/d1418fddd3
* [rubygems/rubygems] Remove unneeded trailing conditions on exitstatusDavid Rodríguez2020-07-1520-52/+52
| | | | https://github.com/rubygems/rubygems/commit/27e0e4ecb6
* [rubygems/rubygems] Easier way to find path to ruby binaryDavid Rodríguez2020-07-151-4/+1
| | | | https://github.com/rubygems/rubygems/commit/cdc201f5c4
* [rubygems/rubygems] Remove unnecessary assertions on exitstatusDavid Rodríguez2020-07-1521-46/+0
| | | | | | | Since our helpers now raise by default if the subcommand fails, these will never actually fail and are not necessary. https://github.com/rubygems/rubygems/commit/6153b9321e
* [rubygems/rubygems] No need to update remotesDavid Rodríguez2020-07-151-1/+0
| | | | | | Everything is already fetched locally. https://github.com/rubygems/rubygems/commit/9c304639b1
* [rubygems/rubygems] Git clone already takes care of thisDavid Rodríguez2020-07-151-1/+0
| | | | https://github.com/rubygems/rubygems/commit/6e0c28d3ab
* [rubygems/rubygems] Clone rubygems from the local repoDavid Rodríguez2020-07-151-1/+1
| | | | | | | | | | | | | It simplifies things and should avoid issues like the one we had where the master branch had a bad `.gitattributes` file and changing it on a PR would be disregarded. In order for this to work, we need to make sure to fetch all tags from the repository, so that they can properly be checked out later. This does not apply to the case of testing against `RGV=..`, since no extra cloning is needed there. https://github.com/rubygems/rubygems/commit/d088d936b8
* [rubygems/rubygems] Skip this spec on ruby_core workflowUtkarsh Gupta2020-07-151-2/+3
| | | | | | | | | | | | | | | ruby_core has an 'ast.rb' file that gets in the middle and breaks this spec, so it's better we skip this test on this workflow for now. Also, slightly change the spec name from "run" to "runs" and change the last assertion, it's cleaner to check empty error. Thanks to David Rodríguez for this! Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/ba8eaa70c3
* [rubygems/rubygems] Use latest version of rubocop for RUBY_VERSION > 2.4Utkarsh Gupta2020-07-151-1/+2
| | | | | | | | | | | | With older versions of rubocop, the dependency on `jaro_winkler` seems to be a pain. However, in the later versions of rubocop, this dependency was dropped. So we only need to use the older version for ruby2.3. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/9cd87eaee3
* [rubygems/rubygems] Use `--config .rubocop.yml` insteadUtkarsh Gupta2020-07-151-1/+1
| | | | | | | | | | | because rubocop configuration inheritance is messed up and when using `--ignore-parent-exclusion`, even though the exit status is 0, the example still fails because of the configuration issue. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/3e20b2738c
* [rubygems/rubygems] Lock rubocop version to 0.80.1Utkarsh Gupta2020-07-151-1/+1
| | | | | | | | | | | | | | | The later RuboCop versions don't work with ruby2.3 so we should lock the version to what works with ruby2.3 as we haven't dropped the support yet. And since we're using the older version of rubocop, also fix `Max` value of `LineLength` to 120, which is the current standard. Without this, rubocop will throw the line length offenses. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/46d0a800a2
* [rubygems/rubygems] Fix linting and make Style/RedundantInterpolation happyUtkarsh Gupta2020-07-151-4/+4
| | | | | | Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/83e330fa87
* [rubygems/rubygems] Fix test to run rubocop on the generated gemUtkarsh Gupta2020-07-151-4/+2
| | | | | | | | | With this, it will be ensured that the generated (skeleton) gem will have no offenses. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/47411262e0
* [rubygems/rubygems] Make Style/HashSyntax cop happyUtkarsh Gupta2020-07-151-7/+7
| | | | | | | | | | Previously, we were using the old syntax like: `task :default => :spec`, but now this commit uses the new Ruby 1.9 hash syntax. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/b41d0fdb56
* [rubygems/rubygems] WIP: add test to run rubocop on the generated gemUtkarsh Gupta2020-07-151-0/+12
| | | | | | Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/730b770f8a
* [rubygems/rubygems] Fix tests pertaining to newgemUtkarsh Gupta2020-07-151-1/+9
| | | | | | Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/e2ee0b7de3
* [rubygems/rubygems] Show also output from all commands on rubygems checkout ↵David Rodríguez2020-07-151-1/+9
| | | | | | errors https://github.com/rubygems/rubygems/commit/1fe24e471d
* [rubygems/rubygems] Remove `--quiet` flag to `git checkout`David Rodríguez2020-07-151-1/+1
| | | | | | | Since we don't show this output by default, it's better to be verbose in case we happen to need more info. https://github.com/rubygems/rubygems/commit/baa4ccf5a6
* [rubygems/rubygems] Bundler specs - Windows - remove skips, File.open => ↵MSP-Greg2020-07-155-29/+3
| | | | | | | | | | | | | | File.readlines Using File.open without a block leaves a file reference that causes issues with file operations commands/binstubs_spec.rb install/gems/compact_index_spec.rb install/gems/dependency_api_spec.rb install/gems/standalone_spec.rb runtime/executable_spec.rb https://github.com/rubygems/rubygems/commit/4b9a6ca156
* [rubygems/rubygems] bundler/spec/commands/binstubs_spec.rb - remove global ↵MSP-Greg2020-07-151-4/+1
| | | | | | | | | | | | Windows skip Added one skip for: bundle binstubs <gem> when the gem exists in the lockfile when generating bundle binstub outside bundler should abort https://github.com/rubygems/rubygems/commit/b77b484889
* RBasci::flags (VALUE) doesn't match int.Koichi Sasada2020-07-151-6/+17
| | | | | The type of RBasic::flags is VALUE, and INT2FIX(flags) does not make sense. Use correct type to represent.
* Fixed yday and wday with timezone [Bug #17024]Nobuyoshi Nakada2020-07-121-0/+4
|
* Avoid deprecated OpenSSL::Digest constantsBart de Water2020-06-292-2/+2
|
* Update to ruby/spec@6c466d4Benoit Daloze2020-06-271-1/+1
|
* Update to ruby/spec@b6b7752Benoit Daloze2020-06-2735-55/+651
|
* Update to ruby/mspec@6cb1f10Benoit Daloze2020-06-274-5/+8
|
* Implement Proc#== and #eql?Jeremy Evans2020-06-193-9/+21
| | | | | | | | | | Previously, these were not implemented, and Object#== and #eql? were used. This tries to check the proc internals to make sure that procs created from separate blocks are treated as not equal, but procs created from the same block are treated as equal, even when the lazy proc allocation optimization is used. Implements [Feature #14267]
* Dup splat array in certain cases where there is a block argumentJeremy Evans2020-06-181-9/+27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This makes: ```ruby args = [1, 2, -> {}]; foo(*args, &args.pop) ``` call `foo` with 1, 2, and the lambda, in addition to passing the lambda as a block. This is different from the previous behavior, which passed the lambda as a block but not as a regular argument, which goes against the expected left-to-right evaluation order. This is how Ruby already compiled arguments if using leading arguments, trailing arguments, or keywords in the same call. This works by disabling the optimization that skipped duplicating the array during the splat (splatarray instruction argument switches from false to true). In the above example, the splat call duplicates the array. I've tested and cases where a local variable or symbol are used do not duplicate the array, so I don't expect this to decrease the performance of most Ruby programs. However, programs such as: ```ruby foo(*args, &bar) ``` could see a decrease in performance, if `bar` is a method call and not a local variable. This is not a perfect solution, there are ways to get around this: ```ruby args = Struct.new(:a).new([:x, :y]) def args.to_a; a; end def args.to_proc; a.pop; ->{}; end foo(*args, &args) # calls foo with 1 argument (:x) # not 2 arguments (:x and :y) ``` A perfect solution would require completely disabling the optimization. Fixes [Bug #16504] Fixes [Bug #16500]
* [rubygems/rubygems] Make sure to pass URI's to `:git`David Rodríguez2020-06-181-9/+9
| | | | | | | | | | | | | | | Passing paths should work in most cases, but on Windows the driver letter is interpreted as the scheme and causes some case mismatches because ``` irb> URI.parse("E:").to_s => "e:" ``` We fix this by passing file URI's instead. https://github.com/rubygems/rubygems/commit/b6bc517628
* [rubygems/rubygems] Better skip messagesDavid Rodríguez2020-06-182-2/+2
| | | | https://github.com/rubygems/rubygems/commit/4f519638ae
* [rubygems/rubygems] More portable PATH editionDavid Rodríguez2020-06-181-1/+1
| | | | https://github.com/rubygems/rubygems/commit/a6d50afad0
* [rubygems/rubygems] Only add .rubocop.yml when --rubocop flag is passedUtkarsh Gupta2020-06-181-7/+0
| | | | | | Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/ef2dae4222
* Ship default .rubocop.ymlUtkarsh Gupta2020-06-181-0/+7
| | | | | | | | | | | Currently, there is no `.rubocop.yml` shipped by default. So when a user runs `rubocop` after creating a new gem via `bundle gem foo`, it throws a bunch of offenses. With the default `.rubocop.yml` present, the number of those offenses significantly reduce by 25. Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
* [rubygems/rubygems] Only add .rubocop.yml when --rubocop flag is passedUtkarsh Gupta2020-06-181-0/+8
| | | | | | Signed-off-by: Utkarsh Gupta <utkarsh@debian.org> https://github.com/rubygems/rubygems/commit/ef2dae4222
* Undeprecate the `--no-cache` flagDavid Rodríguez2020-06-181-1/+0
| | | | | This is not a remembered option, so it shouldn't have been deprecated. At least not for that reason.
* s/sys_exec!/sys_execDavid Rodríguez2020-06-187-14/+14
|
* [rubygems/rubygems] Remove now unused "bang helpers"David Rodríguez2020-06-181-12/+0
| | | | https://github.com/rubygems/rubygems/commit/84e4c58e83
* [rubygems/rubygems] s/run!/runDavid Rodríguez2020-06-1813-33/+33
| | | | https://github.com/rubygems/rubygems/commit/e3f60d8aec