aboutsummaryrefslogtreecommitdiffstats
path: root/yjit/src
Commit message (Collapse)AuthorAgeFilesLines
* YJIT: Skip printing stats at exit if --yjit-disable (#8727)Takashi Kokubun2023-10-201-1/+1
|
* YJIT: remove unused `--yjit-greedy-versioning` command-line option (#8713)Maxime Chevalier-Boisvert2023-10-192-15/+1
|
* YJIT: Return Option from asm.compile() for has_dropped_bytes()Alan Wu2023-10-197-176/+175
| | | | | | | | | So that we get a reminder to check CodeBlock::has_dropped_bytes(). Internally, asm.compile() already checks it, and this patch just propagates it out to the caller with a `#[must_use]`. Code GC logic moved out one level in entry_stub_hit(), so the body can freely use `?`
* YJIT: Add RubyVM::YJIT.enable (#8705)Takashi Kokubun2023-10-192-41/+47
|
* YJIT: Enable the dead_code lint and delete some dead codeAlan Wu2023-10-192-82/+6
|
* YJIT: Add a live ISeq counter Alan Wu2023-10-181-0/+6
| | | | | | | It's an estimator for application size and could be used as a compilation heuristic later. Co-authored-by: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@shopify.com> Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
* Revert "shape.h: Make attr_index_t uint8_t"Katherine Oelsner2023-10-182-5/+5
| | | | This reverts commit e3afc212ec059525fe4e5387b2a3be920ffe0f0e.
* YJIT: Add --yjit-perf (#8697)Takashi Kokubun2023-10-187-8/+105
| | | Co-authored-by: Alan Wu <alansi.xingwu@shopify.com>
* YJIT: Fix clippy::redundant_localsAlan Wu2023-10-171-3/+1
| | | | | | > note: `#[deny(clippy::redundant_locals)]` on by default On Rust 1.73.0.
* YJIT: Remove call to compile() on empty AssemblerAlan Wu2023-10-171-4/+1
|
* YJIT: Add a few missing counters for send fallback (#8681)Takashi Kokubun2023-10-172-3/+6
|
* YJIT: Lookup IDs on boot instead of binding to themAlan Wu2023-10-175-219/+56
| | | | | | | | | | Previously, the version-controlled `cruby_bindings.inc.rs` file contained the build-time artifact `id.h`, which nobu mentioned hinders the goal of having fewer magic numbers in the repository. Lookup the IDs YJIT needs on boot. It costs cycles, but it's fine since YJIT only uses a handful of IDs at the moment. No perceptible degradation to boot time found in my testing.
* YJIT: Count cold_iseq_entry by default (#8654)Takashi Kokubun2023-10-141-5/+0
|
* YJIT: Fallback opt_getconstant_path for const_missing (#8623)Takashi Kokubun2023-10-132-9/+22
| | | | | | | * YJIT: Fallback opt_getconstant_path for const_missing * Fix a comment [ci skip] * Remove a wrapper function
* YJIT: Fix argument clobbering in some block_arg+rest_param calls (#8647)Alan Wu2023-10-132-42/+60
| | | | | | | | | | | | Previously, for block argument callsites with some specific argument count and callee local variable count combinations, YJIT ended up writing over arguments that are supposed to be collected into a rest parameter array unmodified. Detect when clobbering would happen and avoid it. Also, place the block handler after the stack overflow check, since it writes to new stack space. Reported-by: Takashi Kokubun <takashikkbn@gmail.com>
* YJIT: port call threshold logic from Rust to C for performance (#8628)Maxime Chevalier-Boisvert2023-10-124-67/+29
| | | | | | | | | | | | | | | | | * Port call threshold logic from Rust to C for performance * Prefix global/field names with yjit_ * Fix linker error * Fix preprocessor condition for rb_yjit_threshold_hit * Fix third linker issue * Exclude yjit_calls_at_interv from RJIT bindgen --------- Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
* shape.h: Make attr_index_t uint8_tJean Boussier2023-10-112-5/+5
| | | | | | | | | | Given `SHAPE_MAX_NUM_IVS 80`, we transition to TOO_COMPLEX way before we could overflow a 8bit counter. This reduce the size of `rb_shape_t` from 32B to 24B. If we decide to raise `SHAPE_MAX_NUM_IVS` we can always increase that type again.
* YJIT: Allow --yjit-trace-exits on release builds (#8619)Takashi Kokubun2023-10-101-21/+0
|
* Refactor rb_shape_transition_shape_capa to not accept capacityJean Boussier2023-10-102-7/+3
| | | | | This way the groth factor is encapsulated, which allows rb_shape_transition_shape_capa to be smarter about ideal sizes.
* YJIT: shink local types from 8 to 4 bytes (#8597)Maxime Chevalier-Boisvert2023-10-051-24/+79
| | | | | | | * Shink local types from 8 to 4 bytes, context from 21 to 17 bytes Use repr(packed) * Add comment about Type being limited to 4 bits
* YJIT: Run bindgenAlan Wu2023-10-051-1/+0
|
* YJIT: Remove duplicate cfp->iseq accessorAlan Wu2023-10-051-1/+1
|
* YJIT: Avoid writing return value to memory in `leave`Alan Wu2023-10-053-41/+111
| | | | | | | | | | | | | | | | | | | Previously, at the end of `leave` we did `*caller_cfp->sp = return_value`, like the interpreter. With future changes that leaves the SP field uninitialized for C frames, this will become problematic. For cases like returning from `rb_funcall()`, the return value was written above the stack and never read anyway (callers use the copy in the return register). Leave the return value in a register at the end of `leave` and have the code at `cfp->jit_return` decide what to do with it. This avoids the unnecessary memory write mentioned above. For JIT-to-JIT returns, it goes through `asm.stack_push()` and benefits from register allocation for stack temporaries. Mostly flat on benchmarks, with maybe some marginal speed improvements. Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
* YJIT: Add a comment for YJIT_OPTIONS [ci skip]Takashi Kokubun2023-10-041-0/+1
|
* Use a better variable name for wTakashi Kokubun2023-10-041-4/+5
|
* Make the function names consistentTakashi Kokubun2023-10-041-1/+1
|
* YJIT: Move help descriptions to options.rsTakashi Kokubun2023-10-041-1/+27
|
* YJIT: Call mprotect after entry stub failure (#8582)Takashi Kokubun2023-10-031-18/+16
| | | Co-authored-by: Alan Wu <XrXr@users.noreply.github.com>
* YJIT: add heuristic to avoid compiling cold ISEQs (#8522)Maxime Chevalier-Boisvert2023-10-034-3/+64
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * YJIT: Add counter to measure how often we compile "cold" ISEQs (#535) Fix counter name in DEFAULT_COUNTERS YJIT: add --yjit-cold-threshold, don't compile cold ISEQs YJIT: increase default cold threshold to 200_000 Remove rb_yjit_call_threshold() Remove conflict markers Fix compilation errors Threshold 1 should compile immediately Debug deadlock issue with test_ractor Fix call threshold issue with tests * Revert exception threshold logic. Document option in yjid.md * (void) for 0 parameter functions in C99 * Rename iseq_entry_cold => cold_iseq_entry * Document --yjit-cold-threshold in ruby.c * Update doc/yjit/yjit.md Co-authored-by: Jean byroot Boussier <jean.boussier+github@shopify.com> * Shorten help string to appease test * Address bug found by Kokubun. Reorder logic. --------- Co-authored-by: Alan Wu <XrXr@users.noreply.github.com> Co-authored-by: Jean byroot Boussier <jean.boussier+github@shopify.com>
* YJIT: Stop spilling temps on jit_prepare_routine_call (#8581)Takashi Kokubun2023-10-031-34/+49
| | | YJIT: Remove spill_temps from jit_prepare_routine_call
* YJIT: Chain-guard opt_mult overflow (#8554)Takashi Kokubun2023-09-295-11/+29
| | | | | * YJIT: Chain-guard opt_mult overflow * YJIT: Support regenerating Jo after Mul
* YJIT: Use registers for passing C method arguments (#8538)Takashi Kokubun2023-09-291-19/+23
|
* YJIT: Remove obsoleted jit_rb_int_mul (#8539)Takashi Kokubun2023-09-291-29/+0
|
* YJIT: Avoid creating a vector in get_temp_regs() (#8446)Takashi Kokubun2023-09-156-21/+23
| | | | | | | | | | | | * YJIT: Avoid creating a vector in get_temp_regs() Co-authored-by: Alan Wu <alansi.xingwu@shopify.com> * Remove unused import --------- Co-authored-by: Alan Wu <alansi.xingwu@shopify.com> Co-authored-by: Alan Wu <XrXr@users.noreply.github.com>
* YJIT: Fix object movement bug in iseq guard for invokeblockAlan Wu2023-09-151-1/+1
| | | | | | | Since the compile-time iseq used in the guard was not marked and updated during compaction, a runtime value reusing the address could falsely pass the guard. Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
* YJIT: Fix and enable the unused_imports warningAlan Wu2023-09-151-4/+2
|
* YJIT: Skip Insn::Comment and format! if disasm is disabled (#8441)Takashi Kokubun2023-09-144-144/+151
| | | | | | | | | | | | | * YJIT: Skip Insn::Comment and format! if disasm is disabled Co-authored-by: Alan Wu <alansi.xingwu@shopify.com> * YJIT: Get rid of asm.comment --------- Co-authored-by: Alan Wu <alansi.xingwu@shopify.com>
* YJIT: Remove UTF-8 BOM [ci skip]Alan Wu2023-09-141-1/+1
| | | | | /yjit/src/backend/x86_64/mod.rs Is also UTF-8 and it doesn't have the marker. The standard recommends against it, so remove it.
* YJIT: Plug native stack overflowAlan Wu2023-09-143-3/+15
| | | | | | | Previously, TestStack#test_machine_stack_size failed pretty consistently on ARM64 macOS, with Rust code and part of the interpreter used for per-instruction fallback (rb_vm_invokeblock() and friends) touching the stack guard page and crashing with SEGV. I've also seen the same test fail on x64 Linux, though with a different symptom.
* YJIT: Initialize Vec with capacity for iterators (#8439)Takashi Kokubun2023-09-141-1/+1
|
* YJIT: Initialize Assembler vectors with capacity (#8437)Takashi Kokubun2023-09-141-2/+5
|
* YJIT: Skip adding past_page_bytes for past pages (#8433)Takashi Kokubun2023-09-131-2/+22
| | | YJIT: Skip adding past_pages_bytes for past pages
* YJIT: Make yjit_alloc_size available by default (#8426)Takashi Kokubun2023-09-131-13/+36
|
* YJIT: Make compile_time_ns a default counter (#8425)Takashi Kokubun2023-09-131-10/+7
|
* YJIT: Add compilation time counter (#8417)Takashi Kokubun2023-09-123-3/+20
| | | | | * YJIT: Add compilation time counter * YJIT: Use Instant instead
* Make Kernel#lambda raise when given non-literal blockAlan Wu2023-09-121-3/+0
| | | | | | | | | | | | | | | | | Previously, Kernel#lambda returned a non-lambda proc when given a non-literal block and issued a warning under the `:deprecated` category. With this change, Kernel#lambda will always return a lambda proc, if it returns without raising. Due to interactions with block passing optimizations, we previously had two separate code paths for detecting whether Kernel#lambda got a literal block. This change allows us to remove one path, the hack done with rb_control_frame_t::block_code introduced in 85a337f for supporting situations where Kernel#lambda returned a non-lambda proc. [Feature #19777] Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
* Add `String#getbyte` YJIT implementation (#8397)Ian Candy2023-09-071-0/+29
| | | | | | | | | | | | | | | | * Add getbyte JIT implementation Adds an implementation for String#getbyte for YJIT, along with a bootstrap test. This should be helpful for pure Ruby implementations and to avoid unneeded allocations. Co-authored-by: John Hawthorn <jhawthorn@github.com> * Skip the getbyte test for RJIT for now --------- Co-authored-by: John Hawthorn <jhawthorn@github.com> Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
* YJIT: Decrease IVAR_MAX_DEPTH to 8 (#8398)Takashi Kokubun2023-09-071-4/+4
|
* YJIT: Decrease SEND_MAX_DEPTH to 5 (#8390)Takashi Kokubun2023-09-071-17/+14
|
* Remove function call for String#bytesize (#8389)Aaron Patterson2023-09-072-3/+13
| | | | | | | | | | | | | | | * Remove function call for String#bytesize String size is stored in a consistent location, so we can eliminate the function call. * Update yjit/src/codegen.rs Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com> --------- Co-authored-by: Maxime Chevalier-Boisvert <maximechevalierb@gmail.com> Co-authored-by: Takashi Kokubun <takashikkbn@gmail.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-28 14:44:51 +0000