From 25459f400d2532ab4dedfb93c884652de55b56d8 Mon Sep 17 00:00:00 2001 From: k0kubun Date: Sat, 11 Aug 2018 05:33:15 +0000 Subject: _mjit_compile_pc_and_sp.erb: always move pc to fix the wrong line number on #caller_locations or rb_profile_frames. Actually we would be able to move it only when method call (of caller_locations) or C extension invocation (calling rb_profile_frames) can happen. This degrades performance. Optcarrot fps becomes... before: 71.78976052783555 after: 67.65429356624131 I think I can lazily move it and fix the performance issue, even improving the performance for the situation catch table exists. But let me fix this bug first... git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64283 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- test/ruby/test_jit.rb | 19 +++++++++++++++++++ tool/ruby_vm/views/_mjit_compile_pc_and_sp.erb | 4 +--- 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/test/ruby/test_jit.rb b/test/ruby/test_jit.rb index 77742d3bc6..3fbc26cd15 100644 --- a/test/ruby/test_jit.rb +++ b/test/ruby/test_jit.rb @@ -795,6 +795,25 @@ class TestJIT < Test::Unit::TestCase end; end + def test_caller_locations_without_catch_table + out, _ = eval_with_jit("#{<<~"begin;"}\n#{<<~"end;"}", min_calls: 1) + begin; + def b # 2 + caller_locations.first # 3 + end # 4 + # 5 + def a # 6 + print # <-- don't leave PC here # 7 + b # 8 + end + puts a + puts a + end; + lines = out.lines + assert_equal("-e:8:in `a'\n", lines[0]) + assert_equal("-e:8:in `a'\n", lines[1]) + end + private # Some tests are stil failing on VC++. diff --git a/tool/ruby_vm/views/_mjit_compile_pc_and_sp.erb b/tool/ruby_vm/views/_mjit_compile_pc_and_sp.erb index f97d4263c6..5ff1c96f8e 100644 --- a/tool/ruby_vm/views/_mjit_compile_pc_and_sp.erb +++ b/tool/ruby_vm/views/_mjit_compile_pc_and_sp.erb @@ -7,9 +7,7 @@ % % # JIT: Move pc so that catch table lookup condition is met. If the ISeq might not catch an exception, % # the pc motion is optimized away and thus pc should be set properly before `goto cancel`. - if (body->catch_except_p) { - fprintf(f, " reg_cfp->pc = original_body_iseq + %d;\n", next_pos); /* ADD_PC(INSN_ATTR(width)); */ - } + fprintf(f, " reg_cfp->pc = original_body_iseq + %d;\n", next_pos); /* ADD_PC(INSN_ATTR(width)); */ % % # JIT: move sp to use or preserve stack variables if (status->local_stack_p) { -- cgit v1.2.3