From 268962077a84d4d24401986af56992aeb39a8146 Mon Sep 17 00:00:00 2001
From: 卜部昌平 <shyouhei@ruby-lang.org>
Date: Tue, 16 Jun 2020 10:53:31 +0900
Subject: rb_mod_const_location: do not goto into a branch

I'm not necessarily against every goto in general, but jumping into a
branch is definitely a bad idea.  Better refactor.
---
 object.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/object.c b/object.c
index cec3890721..c0481d75f3 100644
--- a/object.c
+++ b/object.c
@@ -2835,8 +2835,7 @@ rb_mod_const_source_location(int argc, VALUE *argv, VALUE mod)
     pend = path + RSTRING_LEN(name);
 
     if (p >= pend || !*p) {
-      wrong_name:
-        rb_name_err_raise(wrong_constant_name, mod, name);
+        goto wrong_name;
     }
 
     if (p + 2 < pend && p[0] == ':' && p[1] == ':') {
@@ -2902,6 +2901,9 @@ rb_mod_const_source_location(int argc, VALUE *argv, VALUE mod)
     }
 
     return loc;
+
+  wrong_name:
+    rb_name_err_raise(wrong_constant_name, mod, name);
 }
 
 /*
-- 
cgit v1.2.3