From 77a7137c4b3e30276af6d4271de9aea6531c621f Mon Sep 17 00:00:00 2001 From: kosaki Date: Fri, 28 Jan 2011 14:23:04 +0000 Subject: * test/gdbm/test_gdbm.rb (TestGDBM#test_s_open_no_create, TestGDBM2#test_writer_open_notexist): We only need to skip libgdbm 1.8.0, not all 1.8.x. 1.8.1 or later don't have GDBM_WRITER sickness. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@30710 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 6 ++++++ test/gdbm/test_gdbm.rb | 17 +++++------------ 2 files changed, 11 insertions(+), 12 deletions(-) diff --git a/ChangeLog b/ChangeLog index 9a544aa9c9..b19e3a1d89 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +Fri Jan 28 23:20:28 2011 KOSAKI Motohiro + + * test/gdbm/test_gdbm.rb (TestGDBM#test_s_open_no_create, + TestGDBM2#test_writer_open_notexist): We only need to skip libgdbm 1.8.0, + not all 1.8.x. 1.8.1 or later don't have GDBM_WRITER sickness. + Fri Jan 28 21:56:57 2011 KOSAKI Motohiro * ext/dbm/extconf.rb: Added new header places for Fedora13. diff --git a/test/gdbm/test_gdbm.rb b/test/gdbm/test_gdbm.rb index f98152a302..64f135b683 100644 --- a/test/gdbm/test_gdbm.rb +++ b/test/gdbm/test_gdbm.rb @@ -92,7 +92,7 @@ if defined? GDBM end end def test_s_open_no_create - skip "this test is failed on libgdbm 1.8.0" if /1\.8\./ =~ GDBM::VERSION + skip "gdbm_open(GDBM_WRITER) is broken on libgdbm 1.8.0" if /1\.8\.0/ =~ GDBM::VERSION assert_nil(gdbm = GDBM.open("#{@tmpdir}/#{@prefix}", nil)) ensure gdbm.close if gdbm @@ -667,18 +667,11 @@ if defined? GDBM end def test_writer_open_notexist - if /1\.8\./ =~ GDBM::VERSION - # 1.8.x are using O_RDWR|O_CREAT. - assert_nothing_raised { - GDBM.open("#{@tmproot}/a", 0666, GDBM::WRITER) - } - else - # 1.7.x are using O_RDWR. - assert_raise(Errno::ENOENT) { - GDBM.open("#{@tmproot}/a", 0666, GDBM::WRITER) - } - end + skip "gdbm_open(GDBM_WRITER) is broken on libgdbm 1.8.0" if /1\.8\.0/ =~ GDBM::VERSION + assert_raise(Errno::ENOENT) { + GDBM.open("#{@tmproot}/a", 0666, GDBM::WRITER) + } end def test_wrcreat_open_notexist -- cgit v1.2.3