From 9d630784b84e8acaee4b1cb20f52070efa622303 Mon Sep 17 00:00:00 2001 From: nobu Date: Mon, 26 May 2014 14:36:26 +0000 Subject: test/rdoc: avoid tempfile leaks * test/rubygems/test_gem_package.rb: avoid tempfile leaks by using `Tempfile.create` instead of `Tempfile.open`. * test/rubygems/test_gem_request_set.rb: ditto. * test/rubygems/test_gem_request_set_gem_dependency_api.rb: ditto. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46145 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- test/rubygems/test_gem_package.rb | 2 +- test/rubygems/test_gem_request_set.rb | 8 ++++---- test/rubygems/test_gem_request_set_gem_dependency_api.rb | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/test/rubygems/test_gem_package.rb b/test/rubygems/test_gem_package.rb index 6a328d5a53..16586a66aa 100644 --- a/test/rubygems/test_gem_package.rb +++ b/test/rubygems/test_gem_package.rb @@ -621,7 +621,7 @@ class TestGemPackage < Gem::Package::TarTestCase end def test_verify_corrupt - Tempfile.open 'corrupt' do |io| + Tempfile.create 'corrupt' do |io| data = Gem.gzip 'a' * 10 io.write \ tar_file_header('metadata.gz', "\000x", 0644, data.length, Time.now) diff --git a/test/rubygems/test_gem_request_set.rb b/test/rubygems/test_gem_request_set.rb index a5fcdcc2fb..f742b6d96d 100644 --- a/test/rubygems/test_gem_request_set.rb +++ b/test/rubygems/test_gem_request_set.rb @@ -156,7 +156,7 @@ DEPENDENCIES def test_load_gemdeps rs = Gem::RequestSet.new - Tempfile.open 'gem.deps.rb' do |io| + Tempfile.create 'gem.deps.rb' do |io| io.puts 'gem "a"' io.flush @@ -172,7 +172,7 @@ DEPENDENCIES def test_load_gemdeps_without_groups rs = Gem::RequestSet.new - Tempfile.open 'gem.deps.rb' do |io| + Tempfile.create 'gem.deps.rb' do |io| io.puts 'gem "a", :group => :test' io.flush @@ -202,7 +202,7 @@ DEPENDENCIES rs = Gem::RequestSet.new - Tempfile.open 'gem.deps.rb' do |io| + Tempfile.create 'gem.deps.rb' do |io| io.puts <<-gems_deps_rb gem "#{name}", :git => "#{repository}" gems_deps_rb @@ -263,7 +263,7 @@ DEPENDENCIES rs = Gem::RequestSet.new - Tempfile.open 'gem.deps.rb' do |io| + Tempfile.create 'gem.deps.rb' do |io| io.puts <<-gems_deps_rb gem "#{a_name}", :path => "#{a_directory}" gem "#{b_name}", :path => "#{b_directory}" diff --git a/test/rubygems/test_gem_request_set_gem_dependency_api.rb b/test/rubygems/test_gem_request_set_gem_dependency_api.rb index cadaf76883..0fb36a2cbc 100644 --- a/test/rubygems/test_gem_request_set_gem_dependency_api.rb +++ b/test/rubygems/test_gem_request_set_gem_dependency_api.rb @@ -492,7 +492,7 @@ class TestGemRequestSetGemDependencyAPI < Gem::TestCase end def test_load - Tempfile.open 'gem.deps.rb' do |io| + Tempfile.create 'gem.deps.rb' do |io| io.write <<-GEM_DEPS gem 'a' -- cgit v1.2.3