From a93da4970be44a473b7b42e7516eb2663dece2c3 Mon Sep 17 00:00:00 2001 From: 卜部昌平 Date: Thu, 11 Jun 2020 14:20:24 +0900 Subject: cmp_clamp: do not goto into a branch I'm not necessarily against every goto in general, but jumping into a branch is definitely a bad idea. Better refactor. --- compar.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/compar.c b/compar.c index 15ebfcdcd2..6e64e3d9ef 100644 --- a/compar.c +++ b/compar.c @@ -233,11 +233,9 @@ cmp_clamp(int argc, VALUE *argv, VALUE x) } if (!NIL_P(max)) { if (excl) rb_raise(rb_eArgError, "cannot clamp with an exclusive range"); - if (!NIL_P(min) && cmpint(min, max) > 0) goto arg_error; } } - else if (cmpint(min, max) > 0) { - arg_error: + if (!NIL_P(min) && !NIL_P(max) && cmpint(min, max) > 0) { rb_raise(rb_eArgError, "min argument must be smaller than max argument"); } -- cgit v1.2.3