From d1e2d6a9c52749912e8239d51b6beb5c6d9de943 Mon Sep 17 00:00:00 2001 From: nobu Date: Sun, 27 Mar 2016 03:55:08 +0000 Subject: sprintf.c: simplify * sprintf.c (rb_str_format): remove repeated calculations. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@54303 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- sprintf.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/sprintf.c b/sprintf.c index f0c2f8dbc2..5c1f7780f0 100644 --- a/sprintf.c +++ b/sprintf.c @@ -1034,7 +1034,7 @@ rb_str_format(int argc, const VALUE *argv, VALUE fmt) { VALUE val = GETARG(), num, den; int sign = (flags&FPLUS) ? 1 : 0, zero = 0; - long len, done = 0; + long len, done = blen; int prefix = 0; if (FIXNUM_P(val) || RB_TYPE_P(val, T_BIGNUM)) { den = INT2FIX(1); @@ -1077,39 +1077,32 @@ rb_str_format(int argc, const VALUE *argv, VALUE fmt) if (sign || (flags&FSPACE)) { buf[blen++] = sign > 0 ? '+' : sign < 0 ? '-' : ' '; prefix++; - done++; } len = RSTRING_LEN(val) + zero; t = RSTRING_PTR(val); if (len > prec) { memcpy(&buf[blen], t, len - prec); blen += len - prec; - done += len - prec; } else { buf[blen++] = '0'; - done++; } if (prec > 0) { buf[blen++] = '.'; - done++; } if (zero) { FILL('0', zero); - done += zero; } else if (prec > len) { FILL('0', prec - len); memcpy(&buf[blen], t, len); blen += len; - done += prec; } else if (prec > 0) { memcpy(&buf[blen], t + len - prec, prec); blen += prec; - done += prec; } - if ((flags & FWIDTH) && width > done) { + if ((flags & FWIDTH) && width > (done = blen - done)) { int fill = ' '; long shifting = 0; if (!(flags&FMINUS)) { -- cgit v1.2.3