From eda2441b5354829bea9225a99e0b96f0ba40b7ab Mon Sep 17 00:00:00 2001 From: normal Date: Tue, 17 Nov 2015 01:05:30 +0000 Subject: socket: avoid arg parsing in bsock_sendmsg_internal * ext/socket/ancdata.c (bsock_sendmsg_internal): avoid arg parsing [ruby-core:71439] [Feature #11339] (rsock_bsock_sendmsg): make private, adjust for above (rsock_bsock_sendmsg_nonblock): ditto * ext/socket/rubysocket.h: adjust prototypes (rsock_opt_false_p): remove * ext/socket/basicsocket.c (rsock_init_basicsocket): define private methods * ext/socket/lib/socket.rb (BasicSocket#sendmsg): new wrapper (BasicSocket#sendmsg_nonblock): ditto target 0: a (ruby 2.3.0dev (2015-11-12 trunk 52550) [x86_64-linux]) target 1: b (ruby 2.3.0dev (2015-11-12 avoid-kwarg-capi 52550) [x86_64-linux] ----------------------------------------------------------- sendmsg_nonblock require 'socket' nr = 1_000_000 i = 0 msg = '.' buf = '.' begin r, w = UNIXSocket.pair(:SEQPACKET) while i < nr i += 1 w.sendmsg_nonblock(msg, exception: false) r.recv(1, 0, buf) end ensure r.close w.close end ----------------------------------------------------------- raw data: [["sendmsg_nonblock", [[1.875997293740511, 1.8452614955604076, 1.8449317328631878, 1.8418389447033405, 1.869386937469244], [1.5175109766423702, 1.4987873211503029, 1.4989623799920082, 1.47918451577425, 1.5017359890043736]]]] Elapsed time: 16.775453245 (sec) ----------------------------------------------------------- benchmark results: minimum results in each 5 measurements. Execution time (sec) name a b sendmsg_nonblock 1.842 1.479 Speedup ratio: compare with the result of `a' (greater is better) name b sendmsg_nonblock 1.245 git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@52603 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- ChangeLog | 13 +++++++++++++ 1 file changed, 13 insertions(+) (limited to 'ChangeLog') diff --git a/ChangeLog b/ChangeLog index adbac8a906..6f9d08e95f 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,16 @@ +Tue Nov 17 09:59:00 2015 Eric Wong + + * ext/socket/ancdata.c (bsock_sendmsg_internal): avoid arg parsing + [ruby-core:71439] [Feature #11339] + (rsock_bsock_sendmsg): make private, adjust for above + (rsock_bsock_sendmsg_nonblock): ditto + * ext/socket/rubysocket.h: adjust prototypes + (rsock_opt_false_p): remove + * ext/socket/basicsocket.c (rsock_init_basicsocket): + define private methods + * ext/socket/lib/socket.rb (BasicSocket#sendmsg): new wrapper + (BasicSocket#sendmsg_nonblock): ditto + Tue Nov 17 09:45:18 2015 Eric Wong * ext/socket/ancdata.c (bsock_recvmsg_internal): avoid arg parsing -- cgit v1.2.3