From eca21fdfaa91b3474c07e9cb149ffc4df750d810 Mon Sep 17 00:00:00 2001 From: normal Date: Wed, 24 Jan 2018 21:07:14 +0000 Subject: ruby/ruby.h: remove unnecessary exports from C-API Needlessly exporting can reduce performance locally and increase binary size. Increasing the footprint of our C-API larger is also detrimental to our development as it encourages tighter coupling with our internals; making it harder for us to preserve compatibility. If some parts of the core codebase needs access to globals, internal.h should be used instead of anything in include/ruby/*. "Urabe, Shyouhei" wrote: > On Thu, Jan 18, 2018 at 7:33 PM, Eric Wong wrote: > > shyouhei@ruby-lang.org wrote: > >> https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=61908 > >> > >> export rb_mFConst > > > > Why are we exporting all these and making the public C-API bigger? > > If anything, we should make these static. Thanks. > > No concrete reason, except they have already been externed in 2.5. > These variables had lacked declarations so far, which resulted in their > visibility to be that of extern. The commit is just confirming the status quo. > > I'm not against to turn them into static. This reverts changes from r61910, r61909, r61908, r61907, and r61906. * transcode.c (rb_eUndefinedConversionError): make static (rb_eInvalidByteSequenceError): ditto (rb_eConverterNotFoundError): ditto * process.c (rb_mProcGID, rb_mProcUid, rb_mProcID_Syscall): ditto * file.c (rb_mFConst): ditto * error.c (rb_mWarning, rb_cWarningBuffer): ditto * enumerator.c (rb_cLazy): ditto [Misc #14381] git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@62029 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- error.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'error.c') diff --git a/error.c b/error.c index 2aa5169c2b..52ff87bc0f 100644 --- a/error.c +++ b/error.c @@ -53,8 +53,8 @@ int rb_str_end_with_asciichar(VALUE str, int c); VALUE rb_eEAGAIN; VALUE rb_eEWOULDBLOCK; VALUE rb_eEINPROGRESS; -VALUE rb_mWarning; -VALUE rb_cWarningBuffer; +static VALUE rb_mWarning; +static VALUE rb_cWarningBuffer; static ID id_warn; -- cgit v1.2.3