From c5c05460ac20abcbc0ed686eb4acf06da7a39a79 Mon Sep 17 00:00:00 2001 From: Jeremy Evans Date: Fri, 20 Sep 2019 19:06:22 -0700 Subject: Warn on access/modify of $SAFE, and remove effects of modifying $SAFE This removes the security features added by $SAFE = 1, and warns for access or modification of $SAFE from Ruby-level, as well as warning when calling all public C functions related to $SAFE. This modifies some internal functions that took a safe level argument to no longer take the argument. rb_require_safe now warns, rb_require_string has been added as a version that takes a VALUE and does not warn. One public C function that still takes a safe level argument and that this doesn't warn for is rb_eval_cmd. We may want to consider adding an alternative method that does not take a safe level argument, and warn for rb_eval_cmd. --- ext/readline/readline.c | 1 - 1 file changed, 1 deletion(-) (limited to 'ext/readline') diff --git a/ext/readline/readline.c b/ext/readline/readline.c index b686f99645..646be2b194 100644 --- a/ext/readline/readline.c +++ b/ext/readline/readline.c @@ -95,7 +95,6 @@ static char **readline_attempted_completion_function(const char *text, #define OutputStringValue(str) do {\ StringValueCStr(str);\ - rb_check_safe_obj(str);\ (str) = rb_str_conv_enc((str), rb_enc_get(str), rb_locale_encoding());\ } while (0)\ -- cgit v1.2.3