From 6abcd35762db4bf49cd6c62a8c624e2a013e5dc1 Mon Sep 17 00:00:00 2001 From: Aaron Patterson Date: Mon, 7 Oct 2019 12:28:21 -0700 Subject: Do not free too many pages. Sweep step checks `heap_pages_freeable_pages`, so compaction should do the same. --- gc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'gc.c') diff --git a/gc.c b/gc.c index 66bdb012b6..18154714db 100644 --- a/gc.c +++ b/gc.c @@ -8409,10 +8409,12 @@ gc_compact_after_gc(rb_objspace_t *objspace, int use_toward_empty, int use_doubl RMOVED(moved_list)->next = 0; page->free_slots++; heap_page_add_freeobj(objspace, page, moved_list); - if (page->free_slots == page->total_slots) { + if (page->free_slots == page->total_slots && heap_pages_freeable_pages > 0) { heap_pages_freeable_pages--; heap_unlink_page(objspace, heap_eden, page); heap_add_page(objspace, heap_tomb, page); + } else if (page->free_slots == page->total_slots) { + page->free_next = NULL; } objspace->profile.total_freed_objects++; moved_list = next_moved; -- cgit v1.2.3