From f75bd9bb8bf1764de613ab1b601d21c46b1d4681 Mon Sep 17 00:00:00 2001 From: Frank Lam Date: Fri, 24 Apr 2020 16:00:59 +0800 Subject: [rubygems/rubygems] Fix bundle gem ignoring global gem.test config * bundle gem previously ignored gem.test when passed empty -t flag, defaulting to RSpec * bundle gem will now ask user for test framework when passed empty -t flag and gem.test is set to false, but will not overwrite gem.test * thor option parsing for String types falls back to human name for nil, so setting lazy_default to nil won't work * https://github.com/erikhuda/thor/blob/c5161501e0cfac7a8c5b838a9c6084c275f03c0d/lib/thor/parser/options.rb#L224 Default to Bundler.settings["gem.test"] for empty --test Add shared examples for test framework to newgem spec Add examples for empty --test flag to newgem spec Simplify conditional for prompting test framework Follow naming conventions for bundler settings Add more descriptive test framework help text for bundle gem Update man pages for bundler https://github.com/rubygems/rubygems/commit/ab0785a09f --- man/bundle-gem.ronn | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) (limited to 'man/bundle-gem.ronn') diff --git a/man/bundle-gem.ronn b/man/bundle-gem.ronn index 1dba9ed607..7aa5c3333a 100644 --- a/man/bundle-gem.ronn +++ b/man/bundle-gem.ronn @@ -64,10 +64,17 @@ configuration file using the following names: Specify the test framework that Bundler should use when generating the project. Acceptable values are `minitest`, `rspec` and `test-unit`. The `GEM_NAME.gemspec` will be configured and a skeleton test/spec directory will - be created based on this option. If this option is unspecified, an interactive - prompt will be displayed and the answer will be saved in Bundler's global - config for future `bundle gem` use. - If no option is specified, the default testing framework is RSpec. + be created based on this option. Given no option is specified: + + When Bundler is configured to generate tests, this defaults to Bundler's + global config setting `gem.test`. + + When Bundler is configured to not generate tests, an interactive prompt will + be displayed and the answer will be used for the current rubygem project. + + When Bundler is unconfigured, an interactive prompt will be displayed and + the answer will be saved in Bundler's global config for future `bundle gem` + use. * `-e`, `--edit[=EDITOR]`: Open the resulting GEM_NAME.gemspec in EDITOR, or the default editor if not -- cgit v1.2.3