From 0f4e4aae22b4e7b92b7ca72dc7dab4b22a9752b4 Mon Sep 17 00:00:00 2001 From: nobu Date: Sat, 13 May 2017 01:05:30 +0000 Subject: math.c: check argument to lgamma_r * math.c (math_lgamma): check the argument before calling math function `lgamma_r` for edge cases. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@58698 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- math.c | 20 ++++---------------- 1 file changed, 4 insertions(+), 16 deletions(-) (limited to 'math.c') diff --git a/math.c b/math.c index 6a55966c49..ce49879305 100644 --- a/math.c +++ b/math.c @@ -778,22 +778,6 @@ math_erfc(VALUE unused_obj, VALUE x) return DBL2NUM(erfc(Get_Double(x))); } -#if defined LGAMMA_R_PM0_FIX -static inline double -ruby_lgamma_r(const double d, int *sign) -{ - const double g = lgamma_r(d, sign); - if (isinf(g)) { - if (d == 0.0) { - *sign = signbit(d) ? -1 : +1; - return INFINITY; - } - } - return g; -} -#define lgamma_r(d, sign) ruby_lgamma_r(d, sign) -#endif - /* * call-seq: * Math.gamma(x) -> Float @@ -911,6 +895,10 @@ math_lgamma(VALUE unused_obj, VALUE x) if (signbit(d)) domain_error("lgamma"); return rb_assoc_new(DBL2NUM(INFINITY), INT2FIX(1)); } + if (d == 0.0) { + VALUE vsign = signbit(d) ? INT2FIX(-1) : INT2FIX(+1); + return rb_assoc_new(DBL2NUM(INFINITY), vsign); + } v = DBL2NUM(lgamma_r(d, &sign)); return rb_assoc_new(v, INT2FIX(sign)); } -- cgit v1.2.3