From 71e793533194e1dd03036b4e0c3cc4550d822477 Mon Sep 17 00:00:00 2001 From: akr Date: Tue, 5 Jun 2012 14:33:32 +0000 Subject: update async-signal-safe comments. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@35926 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- process.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) (limited to 'process.c') diff --git a/process.c b/process.c index 5c03157ee3..a773793847 100644 --- a/process.c +++ b/process.c @@ -2591,7 +2591,7 @@ rb_exec_err(const struct rb_exec_arg *e, char *errmsg, size_t errmsg_buflen) rb_proc_exec_e(prog, e->envp_str); /* not async-signal-safe because after_exec. */ } else { - proc_exec_v(prog, e->argv_str, e->envp_str); /* async-signal-safe not checked */ + proc_exec_v(prog, e->argv_str, e->envp_str); /* not async-signal-safe because dln_find_exe_r */ } #if !defined(HAVE_FORK) preserving_errno(rb_run_exec_options_err(sargp, NULL, errmsg, errmsg_buflen)); @@ -2623,12 +2623,12 @@ rb_exec(const struct rb_exec_arg *e) } #ifdef HAVE_FORK -/* This function should be async-signal-safe but rb_thread_atfork_before_exec is not checked. */ +/* This function should be async-signal-safe. */ static int rb_exec_atfork(void* arg, char *errmsg, size_t errmsg_buflen) { - rb_thread_atfork_before_exec(); - return rb_exec_err(arg, errmsg, errmsg_buflen); + rb_thread_atfork_before_exec(); /* xxx: not async-signal-safe because it calls rb_thread_atfork_internal which calls st_insert, etc. */ + return rb_exec_err(arg, errmsg, errmsg_buflen); /* not async-signal-safe because run_exec_dup2, after_exec and dln_find_exe_r */ } #endif -- cgit v1.2.3