From 0d4185f30e360b078d663acd8f4dfda95fe2aae9 Mon Sep 17 00:00:00 2001 From: akr Date: Fri, 17 Oct 2014 09:49:28 +0000 Subject: * Avoid undefined behaviors found by gcc -fsanitize=undefined. gcc (Debian 4.9.1-16) 4.9.1 * string.c (rb_str_sum): Avoid undefined behavior. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@47997 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- string.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) (limited to 'string.c') diff --git a/string.c b/string.c index c2501f99b1..b433a21446 100644 --- a/string.c +++ b/string.c @@ -7571,7 +7571,7 @@ rb_str_ord(VALUE s) * * Returns a basic n-bit checksum of the characters in str, * where n is the optional Fixnum parameter, defaulting - * to 16. The result is simply the sum of the binary value of each character in + * to 16. The result is simply the sum of the binary value of each byte in * str modulo 2**n - 1. This is not a particularly good * checksum. */ @@ -7592,6 +7592,8 @@ rb_str_sum(int argc, VALUE *argv, VALUE str) else { rb_scan_args(argc, argv, "01", &vbits); bits = NUM2INT(vbits); + if (bits < 0) + bits = 0; } ptr = p = RSTRING_PTR(str); len = RSTRING_LEN(str); -- cgit v1.2.3