From 15689ed7780b06ddc14cde4f427de834177283a5 Mon Sep 17 00:00:00 2001 From: eregon Date: Tue, 12 Dec 2017 18:44:49 +0000 Subject: Fix test-all tests to avoid creating report_on_exception warnings * The warnings are shown by Thread.report_on_exception defaulting to true. [Feature #14143] [ruby-core:83979] * Improves tests by narrowing down the scope where an exception is expected. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@61188 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- test/fiddle/test_func.rb | 10 +++++----- test/fiddle/test_handle.rb | 18 ++++++++++-------- 2 files changed, 15 insertions(+), 13 deletions(-) (limited to 'test/fiddle') diff --git a/test/fiddle/test_func.rb b/test/fiddle/test_func.rb index 8517965223..8c35833a32 100644 --- a/test/fiddle/test_func.rb +++ b/test/fiddle/test_func.rb @@ -13,12 +13,12 @@ module Fiddle def test_syscall_with_tainted_string f = Function.new(@libc['system'], [TYPE_VOIDP], TYPE_INT) - assert_raise(SecurityError) do - Thread.new { - $SAFE = 1 + Thread.new { + $SAFE = 1 + assert_raise(SecurityError) do f.call("uname -rs".dup.taint) - }.join - end + end + }.join end def test_sinf diff --git a/test/fiddle/test_handle.rb b/test/fiddle/test_handle.rb index 444ac55da3..77559eb4d9 100644 --- a/test/fiddle/test_handle.rb +++ b/test/fiddle/test_handle.rb @@ -9,20 +9,22 @@ module Fiddle include Fiddle def test_safe_handle_open - t = Thread.new do + Thread.new do $SAFE = 1 - Fiddle::Handle.new(LIBC_SO.dup.taint) - end - assert_raise(SecurityError) { t.value } + assert_raise(SecurityError) { + Fiddle::Handle.new(LIBC_SO.dup.taint) + } + end.join end def test_safe_function_lookup - t = Thread.new do + Thread.new do h = Fiddle::Handle.new(LIBC_SO) $SAFE = 1 - h["qsort".dup.taint] - end - assert_raise(SecurityError) { t.value } + assert_raise(SecurityError) { + h["qsort".dup.taint] + } + end.join end def test_to_i -- cgit v1.2.3