From ae1565503036e1f38fb2684f82acf5bb3403eec3 Mon Sep 17 00:00:00 2001 From: hsbt Date: Fri, 4 Jul 2014 01:09:27 +0000 Subject: * test/rubygems/test_gem_package.rb: avoid tempfile leaks using Tempfile#close! * test/rubygems/test_gem_request_set.rb: ditto. * test/rubygems/test_gem_request_set_gem_dependency_api.rb: ditto. git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46684 b2dd03c8-39d4-4d8f-98ff-823fe69b080e --- test/rubygems/test_gem_request_set.rb | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) (limited to 'test/rubygems/test_gem_request_set.rb') diff --git a/test/rubygems/test_gem_request_set.rb b/test/rubygems/test_gem_request_set.rb index a5fcdcc2fb..130728e249 100644 --- a/test/rubygems/test_gem_request_set.rb +++ b/test/rubygems/test_gem_request_set.rb @@ -156,12 +156,14 @@ DEPENDENCIES def test_load_gemdeps rs = Gem::RequestSet.new - Tempfile.open 'gem.deps.rb' do |io| + tf = Tempfile.open 'gem.deps.rb' do |io| io.puts 'gem "a"' io.flush rs.load_gemdeps io.path + io end + tf.close! assert_equal [dep('a')], rs.dependencies @@ -172,12 +174,14 @@ DEPENDENCIES def test_load_gemdeps_without_groups rs = Gem::RequestSet.new - Tempfile.open 'gem.deps.rb' do |io| + tf = Tempfile.open 'gem.deps.rb' do |io| io.puts 'gem "a", :group => :test' io.flush rs.load_gemdeps io.path, [:test] + io end + tf.close! assert_empty rs.dependencies end @@ -202,7 +206,7 @@ DEPENDENCIES rs = Gem::RequestSet.new - Tempfile.open 'gem.deps.rb' do |io| + tf = Tempfile.open 'gem.deps.rb' do |io| io.puts <<-gems_deps_rb gem "#{name}", :git => "#{repository}" gems_deps_rb @@ -210,7 +214,9 @@ DEPENDENCIES io.flush rs.load_gemdeps io.path + io end + tf.close! res = rs.resolve assert_equal 1, res.size @@ -263,7 +269,7 @@ DEPENDENCIES rs = Gem::RequestSet.new - Tempfile.open 'gem.deps.rb' do |io| + tf = Tempfile.open 'gem.deps.rb' do |io| io.puts <<-gems_deps_rb gem "#{a_name}", :path => "#{a_directory}" gem "#{b_name}", :path => "#{b_directory}" @@ -272,7 +278,9 @@ DEPENDENCIES io.flush rs.load_gemdeps io.path + io end + tf.close! res = rs.resolve assert_equal 2, res.size -- cgit v1.2.3