From c5c05460ac20abcbc0ed686eb4acf06da7a39a79 Mon Sep 17 00:00:00 2001 From: Jeremy Evans Date: Fri, 20 Sep 2019 19:06:22 -0700 Subject: Warn on access/modify of $SAFE, and remove effects of modifying $SAFE This removes the security features added by $SAFE = 1, and warns for access or modification of $SAFE from Ruby-level, as well as warning when calling all public C functions related to $SAFE. This modifies some internal functions that took a safe level argument to no longer take the argument. rb_require_safe now warns, rb_require_string has been added as a version that takes a VALUE and does not warn. One public C function that still takes a safe level argument and that this doesn't warn for is rb_eval_cmd. We may want to consider adding an alternative method that does not take a safe level argument, and warn for rb_eval_cmd. --- tool/lib/leakchecker.rb | 5 ----- 1 file changed, 5 deletions(-) (limited to 'tool/lib') diff --git a/tool/lib/leakchecker.rb b/tool/lib/leakchecker.rb index 26ece9340f..57e28665d6 100644 --- a/tool/lib/leakchecker.rb +++ b/tool/lib/leakchecker.rb @@ -16,16 +16,11 @@ class LeakChecker check_tempfile_leak(test_name), check_env(test_name), check_encodings(test_name), - check_safe(test_name), check_verbose(test_name), ] GC.start if leaks.any? end - def check_safe test_name - puts "#{test_name}: $SAFE == #{$SAFE}" unless $SAFE == 0 - end - def check_verbose test_name puts "#{test_name}: $VERBOSE == #{$VERBOSE}" unless @old_verbose == $VERBOSE end -- cgit v1.2.3