1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
|
require 'rubygems/test_case'
require 'rubygems/dependency_resolver'
class TestGemDependencyResolver < Gem::TestCase
def make_dep(name, *req)
Gem::Dependency.new(name, *req)
end
def set(*specs)
StaticSet.new(specs)
end
def assert_set(expected, actual)
exp = expected.sort_by { |s| s.full_name }
act = actual.map { |a| a.spec }.sort_by { |s| s.full_name }
assert_equal exp, act
end
def test_no_overlap_specificly
a = util_spec "a", '1'
b = util_spec "b", "1"
ad = make_dep "a", "= 1"
bd = make_dep "b", "= 1"
deps = [ad, bd]
s = set(a, b)
res = Gem::DependencyResolver.new(deps, s)
assert_set [a, b], res.resolve
end
def test_pulls_in_dependencies
a = util_spec "a", '1'
b = util_spec "b", "1", "c" => "= 1"
c = util_spec "c", "1"
ad = make_dep "a", "= 1"
bd = make_dep "b", "= 1"
deps = [ad, bd]
s = set(a, b, c)
res = Gem::DependencyResolver.new(deps, s)
assert_set [a, b, c], res.resolve
end
def test_picks_highest_version
a1 = util_spec "a", '1'
a2 = util_spec "a", '2'
s = set(a1, a2)
ad = make_dep "a"
res = Gem::DependencyResolver.new([ad], s)
assert_set [a2], res.resolve
end
def test_only_returns_spec_once
a1 = util_spec "a", "1", "c" => "= 1"
b1 = util_spec "b", "1", "c" => "= 1"
c1 = util_spec "c", "1"
ad = make_dep "a"
bd = make_dep "b"
s = set(a1, b1, c1)
res = Gem::DependencyResolver.new([ad, bd], s)
assert_set [a1, b1, c1], res.resolve
end
def test_picks_lower_version_when_needed
a1 = util_spec "a", "1", "c" => ">= 1"
b1 = util_spec "b", "1", "c" => "= 1"
c1 = util_spec "c", "1"
c2 = util_spec "c", "2"
ad = make_dep "a"
bd = make_dep "b"
s = set(a1, b1, c1, c2)
res = Gem::DependencyResolver.new([ad, bd], s)
assert_set [a1, b1, c1], res.resolve
cons = res.conflicts
assert_equal 1, cons.size
con = cons.first
assert_equal "c (= 1)", con.dependency.to_s
assert_equal "c-2", con.activated.full_name
end
def test_conflict_resolution_only_effects_correct_spec
a1 = util_spec "a", "1", "c" => ">= 1"
b1 = util_spec "b", "1", "d" => ">= 1"
d3 = util_spec "d", "3", "c" => "= 1"
d4 = util_spec "d", "4", "c" => "= 1"
c1 = util_spec "c", "1"
c2 = util_spec "c", "2"
ad = make_dep "a"
bd = make_dep "b"
s = set(a1, b1, d3, d4, c1, c2)
res = Gem::DependencyResolver.new([ad, bd], s)
assert_set [a1, b1, c1, d4], res.resolve
cons = res.conflicts
assert_equal 1, cons.size
con = cons.first
assert_equal "c (= 1)", con.dependency.to_s
assert_equal "c-2", con.activated.full_name
end
def test_raises_dependency_error
a1 = util_spec "a", "1", "c" => "= 1"
b1 = util_spec "b", "1", "c" => "= 2"
c1 = util_spec "c", "1"
c2 = util_spec "c", "2"
ad = make_dep "a"
bd = make_dep "b"
s = set(a1, b1, c1, c2)
r = Gem::DependencyResolver.new([ad, bd], s)
e = assert_raises Gem::DependencyResolutionError do
r.resolve
end
assert_equal "unable to resolve conflicting dependencies 'c (= 2)' and 'c (= 1)'", e.message
deps = [make_dep("c", "= 2"), make_dep("c", "= 1")]
assert_equal deps, e.conflicting_dependencies
con = e.conflict
act = con.activated
assert_equal "c-1", act.spec.full_name
parent = act.parent
assert_equal "a-1", parent.spec.full_name
act = con.requester
assert_equal "b-1", act.spec.full_name
end
def test_raises_when_a_gem_is_missing
ad = make_dep "a"
r = Gem::DependencyResolver.new([ad], set)
e = assert_raises Gem::UnsatisfiableDepedencyError do
r.resolve
end
assert_equal "unable to find any gem matching dependency 'a (>= 0)'", e.message
assert_equal "a (>= 0)", e.dependency.to_s
end
def test_raises_when_a_gem_version_is_missing
a1 = util_spec "a", "1"
ad = make_dep "a", "= 3"
r = Gem::DependencyResolver.new([ad], set(a1))
e = assert_raises Gem::UnsatisfiableDepedencyError do
r.resolve
end
assert_equal "a (= 3)", e.dependency.to_s
end
def test_raises_when_possibles_are_exhausted
a1 = util_spec "a", "1", "c" => ">= 2"
b1 = util_spec "b", "1", "c" => "= 1"
c1 = util_spec "c", "1"
c2 = util_spec "c", "2"
c3 = util_spec "c", "3"
s = set(a1, b1, c1, c2, c3)
ad = make_dep "a"
bd = make_dep "b"
r = Gem::DependencyResolver.new([ad, bd], s)
e = assert_raises Gem::ImpossibleDependenciesError do
r.resolve
end
assert_equal "detected 1 conflict with dependency 'c (>= 2)'", e.message
assert_equal "c (>= 2)", e.dependency.to_s
s, con = e.conflicts[0]
assert_equal "c-3", s.full_name
assert_equal "c (= 1)", con.dependency.to_s
assert_equal "b-1", con.requester.full_name
end
def test_keeps_resolving_after_seeing_satisfied_dep
a1 = util_spec "a", "1", "b" => "= 1", "c" => "= 1"
b1 = util_spec "b", "1"
c1 = util_spec "c", "1"
ad = make_dep "a"
bd = make_dep "b"
s = set(a1, b1, c1)
r = Gem::DependencyResolver.new([ad, bd], s)
assert_set [a1, b1, c1], r.resolve
end
def test_common_rack_activation_scenario
rack100 = util_spec "rack", "1.0.0"
rack101 = util_spec "rack", "1.0.1"
lib1 = util_spec "lib", "1", "rack" => ">= 1.0.1"
rails = util_spec "rails", "3", "actionpack" => "= 3"
ap = util_spec "actionpack", "3", "rack" => ">= 1.0.0"
d1 = make_dep "rails"
d2 = make_dep "lib"
s = set(lib1, rails, ap, rack100, rack101)
r = Gem::DependencyResolver.new([d1, d2], s)
assert_set [rails, ap, rack101, lib1], r.resolve
# check it with the deps reverse too
r = Gem::DependencyResolver.new([d2, d1], s)
assert_set [lib1, rack101, rails, ap], r.resolve
end
def test_backtracks_to_the_first_conflict
a1 = util_spec "a", "1"
a2 = util_spec "a", "2"
a3 = util_spec "a", "3"
a4 = util_spec "a", "4"
d1 = make_dep "a"
d2 = make_dep "a", ">= 2"
d3 = make_dep "a", "= 1"
s = set(a1, a2, a3, a4)
r = Gem::DependencyResolver.new([d1, d2, d3], s)
assert_raises Gem::ImpossibleDependenciesError do
r.resolve
end
end
# actionmailer 2.3.4
# activemerchant 1.5.0
# activesupport 2.3.5, 2.3.4
# Activemerchant needs activesupport >= 2.3.2. When you require activemerchant, it will activate the latest version that meets that requirement which is 2.3.5. Actionmailer on the other hand needs activesupport = 2.3.4. When rubygems tries to activate activesupport 2.3.4, it will raise an error.
def test_simple_activesupport_problem
sup1 = util_spec "activesupport", "2.3.4"
sup2 = util_spec "activesupport", "2.3.5"
merch = util_spec "activemerchant", "1.5.0", "activesupport" => ">= 2.3.2"
mail = util_spec "actionmailer", "2.3.4", "activesupport" => "= 2.3.4"
s = set(mail, merch, sup1, sup2)
d1 = make_dep "activemerchant"
d2 = make_dep "actionmailer"
r = Gem::DependencyResolver.new([d1, d2], s)
assert_set [merch, mail, sup1], r.resolve
end
def test_second_level_backout
b1 = new_spec "b", "1", { "c" => ">= 1" }, "lib/b.rb"
b2 = new_spec "b", "2", { "c" => ">= 2" }, "lib/b.rb"
c1 = new_spec "c", "1"
c2 = new_spec "c", "2"
d1 = new_spec "d", "1", { "c" => "< 2" }, "lib/d.rb"
d2 = new_spec "d", "2", { "c" => "< 2" }, "lib/d.rb"
s = set(b1, b2, c1, c2, d1, d2)
p1 = make_dep "b", "> 0"
p2 = make_dep "d", "> 0"
r = Gem::DependencyResolver.new([p1, p2], s)
assert_set [b1, c1, d2], r.resolve
end
end
|