user: reflect registered state before cache expires

1 files changed, 7 insertions, 5 deletions

diff --git a/app/models/user.rb b/app/models/user.rb
index feff823..465b390 100644
--- a/app/models/user.rb
+++ b/app/models/user.rb
@@ -67,7 +67,7 @@ class User < ActiveRecord::Base
   end
 
   def stats
-    Rails.cache.fetch("users/#{self.id}/stats", expires_in: Settings.cache.stats) do
+    ret = Rails.cache.fetch("users/#{self.id}/stats", expires_in: Settings.cache.stats) do
       plucked = self.tweets.select("COUNT(*) AS count, SUM(reactions_count) AS sum").reorder("").first.attributes
 
       ret = OpenStruct.new
@@ -76,12 +76,14 @@ class User < ActiveRecord::Base
       ret.reactions_count = plucked["sum"]
       ret.registered = self.registered?
 
-      if self.registered?
-        ret.since_join = (DateTime.now.utc - self.account.created_at.to_datetime).to_i
-      end
-      
       ret
     end
+
+    if self.registered?
+      ret.since_join = (DateTime.now.utc - self.account.created_at.to_datetime).to_i
+    end
+
+    ret
   end
 
   def count_favorited_by