Fixes per code review

- validate the options in the options hash
- move the default ui option into options processing
- preserve the users options hash

1 files changed, 28 insertions, 0 deletions

diff --git a/spec/runtime/inline_spec.rb b/spec/runtime/inline_spec.rb
index 0933e447..b3e90cd4 100644
--- a/spec/runtime/inline_spec.rb
+++ b/spec/runtime/inline_spec.rb
@@ -111,4 +111,32 @@ describe "bundler/inline#gemfile" do
     expect(out).to eq("CONFIRMED!")
     expect(exitstatus).to be_zero if exitstatus
   end
+
+  it "raises an exception if passed unknown arguments" do
+    script <<-RUBY, :expect_err => true
+      gemfile(true, arglebargle: true) do
+        path "#{lib_path}"
+        gem "two"
+      end
+
+      puts "success"
+    RUBY
+    expect(err).to include "Unknown options: arglebargle"
+    expect(out).not_to include "success"
+  end
+
+  it "does not mutate the option argument" do
+    script <<-RUBY
+      require 'bundler'
+      options = { ui: Bundler::UI::Shell.new }
+      gemfile(false, options) do
+        path "#{lib_path}"
+        gem "two"
+      end
+      puts "OKAY" if options.key?(:ui)
+    RUBY
+
+    expect(out).to match("OKAY")
+    expect(exitstatus).to be_zero if exitstatus
+  end
 end