1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
|
require "spec_helper"
describe "bundle clean" do
def should_have_gems(*gems)
gems.each do |g|
expect(vendored_gems("gems/#{g}")).to exist
expect(vendored_gems("specifications/#{g}.gemspec")).to exist
expect(vendored_gems("cache/#{g}.gem")).to exist
end
end
def should_not_have_gems(*gems)
gems.each do |g|
expect(vendored_gems("gems/#{g}")).not_to exist
expect(vendored_gems("specifications/#{g}.gemspec")).not_to exist
expect(vendored_gems("cache/#{g}.gem")).not_to exist
end
end
it "removes unused gems that are different" do
gemfile <<-G
source "file://#{gem_repo1}"
gem "thin"
gem "foo"
G
bundle "install --path vendor/bundle --no-clean"
gemfile <<-G
source "file://#{gem_repo1}"
gem "thin"
G
bundle "install"
bundle :clean
expect(out).to eq("Removing foo (1.0)")
should_have_gems 'thin-1.0', 'rack-1.0.0'
should_not_have_gems 'foo-1.0'
expect(vendored_gems("bin/rackup")).to exist
end
it "removes old version of gem if unused" do
gemfile <<-G
source "file://#{gem_repo1}"
gem "rack", "0.9.1"
gem "foo"
G
bundle "install --path vendor/bundle --no-clean"
gemfile <<-G
source "file://#{gem_repo1}"
gem "rack", "1.0.0"
gem "foo"
G
bundle "install"
bundle :clean
expect(out).to eq("Removing rack (0.9.1)")
should_have_gems 'foo-1.0', 'rack-1.0.0'
should_not_have_gems 'rack-0.9.1'
expect(vendored_gems("bin/rackup")).to exist
end
it "removes new version of gem if unused" do
gemfile <<-G
source "file://#{gem_repo1}"
gem "rack", "1.0.0"
gem "foo"
G
bundle "install --path vendor/bundle --no-clean"
gemfile <<-G
source "file://#{gem_repo1}"
gem "rack", "0.9.1"
gem "foo"
G
bundle "install"
bundle :clean
expect(out).to eq("Removing rack (1.0.0)")
should_have_gems 'foo-1.0', 'rack-0.9.1'
should_not_have_gems 'rack-1.0.0'
expect(vendored_gems("bin/rackup")).to exist
end
it "remove gems in bundle without groups" do
gemfile <<-G
source "file://#{gem_repo1}"
gem "foo"
group :test_group do
gem "rack", "1.0.0"
end
G
bundle "install --path vendor/bundle"
bundle "install --without test_group"
bundle :clean
expect(out).to eq("Removing rack (1.0.0)")
should_have_gems 'foo-1.0'
should_not_have_gems 'rack-1.0.0'
expect(vendored_gems("bin/rackup")).to_not exist
end
it "does not remove cached git dir if it's being used" do
build_git "foo"
revision = revision_for(lib_path("foo-1.0"))
git_path = lib_path('foo-1.0')
gemfile <<-G
source "file://#{gem_repo1}"
gem "rack", "1.0.0"
git "#{git_path}", :ref => "#{revision}" do
gem "foo"
end
G
bundle "install --path vendor/bundle"
bundle :clean
digest = Digest::SHA1.hexdigest(git_path.to_s)
expect(vendored_gems("cache/bundler/git/foo-1.0-#{digest}")).to exist
end
it "removes unused git gems" do
build_git "foo", :path => lib_path("foo")
git_path = lib_path('foo')
revision = revision_for(git_path)
gemfile <<-G
source "file://#{gem_repo1}"
gem "rack", "1.0.0"
git "#{git_path}", :ref => "#{revision}" do
gem "foo"
end
G
bundle "install --path vendor/bundle"
gemfile <<-G
source "file://#{gem_repo1}"
gem "rack", "1.0.0"
G
bundle "install"
bundle :clean
expect(out).to eq("Removing foo (#{revision[0..11]})")
expect(vendored_gems("gems/rack-1.0.0")).to exist
expect(vendored_gems("bundler/gems/foo-#{revision[0..11]}")).not_to exist
digest = Digest::SHA1.hexdigest(git_path.to_s)
expect(vendored_gems("cache/bundler/git/foo-#{digest}")).not_to exist
expect(vendored_gems("specifications/rack-1.0.0.gemspec")).to exist
expect(vendored_gems("bin/rackup")).to exist
end
it "removes old git gems" do
build_git "foo-bar", :path => lib_path("foo-bar")
revision = revision_for(lib_path("foo-bar"))
gemfile <<-G
source "file://#{gem_repo1}"
gem "rack", "1.0.0"
git "#{lib_path('foo-bar')}" do
gem "foo-bar"
end
G
bundle "install --path vendor/bundle"
update_git "foo", :path => lib_path("foo-bar")
revision2 = revision_for(lib_path("foo-bar"))
bundle "update"
bundle :clean
expect(out).to eq("Removing foo-bar (#{revision[0..11]})")
expect(vendored_gems("gems/rack-1.0.0")).to exist
expect(vendored_gems("bundler/gems/foo-bar-#{revision[0..11]}")).not_to exist
expect(vendored_gems("bundler/gems/foo-bar-#{revision2[0..11]}")).to exist
expect(vendored_gems("specifications/rack-1.0.0.gemspec")).to exist
expect(vendored_gems("bin/rackup")).to exist
end
it "does not remove nested gems in a git repo" do
build_lib "activesupport", "3.0", :path => lib_path("rails/activesupport")
build_git "rails", "3.0", :path => lib_path("rails") do |s|
s.add_dependency "activesupport", "= 3.0"
end
revision = revision_for(lib_path("rails"))
gemfile <<-G
gem "activesupport", :git => "#{lib_path('rails')}", :ref => '#{revision}'
G
bundle "install --path vendor/bundle"
bundle :clean
expect(out).to eq("")
expect(vendored_gems("bundler/gems/rails-#{revision[0..11]}")).to exist
end
it "does not remove git sources that are in without groups" do
build_git "foo", :path => lib_path("foo")
git_path = lib_path('foo')
revision = revision_for(git_path)
gemfile <<-G
source "file://#{gem_repo1}"
gem "rack", "1.0.0"
group :test do
git "#{git_path}", :ref => "#{revision}" do
gem "foo"
end
end
G
bundle "install --path vendor/bundle --without test"
bundle :clean
expect(out).to eq("")
expect(vendored_gems("bundler/gems/foo-#{revision[0..11]}")).to exist
digest = Digest::SHA1.hexdigest(git_path.to_s)
expect(vendored_gems("cache/bundler/git/foo-#{digest}")).to_not exist
end
it "does not blow up when using without groups" do
gemfile <<-G
source "file://#{gem_repo1}"
gem "rack"
group :development do
gem "foo"
end
G
bundle "install --path vendor/bundle --without development"
bundle :clean, :exitstatus => true
expect(exitstatus).to eq(0)
end
it "displays an error when used without --path" do
install_gemfile <<-G
source "file://#{gem_repo1}"
gem "rack", "1.0.0"
G
bundle :clean, :exitstatus => true
expect(exitstatus).to eq(1)
expect(out).to eq("Can only use bundle clean when --path is set or --force is set")
end
# handling bundle clean upgrade path from the pre's
it "removes .gem/.gemspec file even if there's no corresponding gem dir is already moved" do
gemfile <<-G
source "file://#{gem_repo1}"
gem "thin"
gem "foo"
G
bundle "install --path vendor/bundle"
gemfile <<-G
source "file://#{gem_repo1}"
gem "foo"
G
bundle "install"
FileUtils.rm(vendored_gems("bin/rackup"))
FileUtils.rm_rf(vendored_gems("gems/thin-1.0"))
FileUtils.rm_rf(vendored_gems("gems/rack-1.0.0"))
bundle :clean
should_not_have_gems 'thin-1.0', 'rack-1.0'
should_have_gems 'foo-1.0'
expect(vendored_gems("bin/rackup")).not_to exist
end
it "does not call clean automatically when using system gems" do
gemfile <<-G
source "file://#{gem_repo1}"
gem "thin"
gem "rack"
G
bundle :install
gemfile <<-G
source "file://#{gem_repo1}"
gem "rack"
G
bundle :install
sys_exec "gem list"
expect(out).to include("rack (1.0.0)")
expect(out).to include("thin (1.0)")
end
it "--clean should override the bundle setting on install" do
gemfile <<-G
source "file://#{gem_repo1}"
gem "thin"
gem "rack"
G
bundle "install --path vendor/bundle --clean"
gemfile <<-G
source "file://#{gem_repo1}"
gem "rack"
G
bundle "install"
should_have_gems 'rack-1.0.0'
should_not_have_gems 'thin-1.0'
end
it "--clean should override the bundle setting on update" do
build_repo2
gemfile <<-G
source "file://#{gem_repo2}"
gem "foo"
G
bundle "install --path vendor/bundle --clean"
update_repo2 do
build_gem 'foo', '1.0.1'
end
bundle "update"
should_have_gems 'foo-1.0.1'
should_not_have_gems 'foo-1.0'
end
it "does not clean automatically on --path" do
gemfile <<-G
source "file://#{gem_repo1}"
gem "thin"
gem "rack"
G
bundle "install --path vendor/bundle"
gemfile <<-G
source "file://#{gem_repo1}"
gem "rack"
G
bundle "install"
should_have_gems 'rack-1.0.0', 'thin-1.0'
end
it "does not clean on bundle update with --path" do
build_repo2
gemfile <<-G
source "file://#{gem_repo2}"
gem "foo"
G
bundle "install --path vendor/bundle"
update_repo2 do
build_gem 'foo', '1.0.1'
end
bundle :update
should_have_gems 'foo-1.0', 'foo-1.0.1'
end
it "does not clean on bundle update when using --system" do
build_repo2
gemfile <<-G
source "file://#{gem_repo2}"
gem "foo"
G
bundle "install"
update_repo2 do
build_gem 'foo', '1.0.1'
end
bundle :update
sys_exec "gem list"
expect(out).to include("foo (1.0.1, 1.0)")
end
it "cleans system gems when --force is used" do
gemfile <<-G
source "file://#{gem_repo1}"
gem "foo"
gem "rack"
G
bundle :install
gemfile <<-G
source "file://#{gem_repo1}"
gem "rack"
G
bundle :install
bundle "clean --force"
expect(out).to eq("Removing foo (1.0)")
sys_exec "gem list"
expect(out).not_to include("foo (1.0)")
expect(out).to include("rack (1.0.0)")
end
it "cleans git gems with a 7 length git revision" do
build_git "foo"
revision = revision_for(lib_path("foo-1.0"))
gemfile <<-G
source "file://#{gem_repo1}"
gem "foo", :git => "#{lib_path('foo-1.0')}"
G
bundle "install --path vendor/bundle"
# mimic 7 length git revisions in Gemfile.lock
gemfile_lock = File.read(bundled_app('Gemfile.lock')).split("\n")
gemfile_lock.each_with_index do |line, index|
gemfile_lock[index] = line[0..(11 + 7)] if line.include?(" revision:")
end
File.open(bundled_app('Gemfile.lock'), 'w') do |file|
file.print gemfile_lock.join("\n")
end
bundle "install --path vendor/bundle"
bundle :clean
expect(out).not_to include("Removing foo (1.0 #{revision[0..6]})")
expect(vendored_gems("bundler/gems/foo-1.0-#{revision[0..6]}")).to exist
end
it "when using --force on system gems, it doesn't remove binaries" do
build_repo2
update_repo2 do
build_gem 'bindir' do |s|
s.bindir = "exe"
s.executables = "foo"
end
end
gemfile <<-G
source "file://#{gem_repo2}"
gem "bindir"
G
bundle :install
bundle "clean --force"
sys_status "foo"
expect(exitstatus).to eq(0)
expect(out).to eq("1.0")
end
it "doesn't blow up on path gems without a .gempsec" do
relative_path = "vendor/private_gems/bar-1.0"
absolute_path = bundled_app(relative_path)
FileUtils.mkdir_p("#{absolute_path}/lib/bar")
File.open("#{absolute_path}/lib/bar/bar.rb", 'wb') do |file|
file.puts "module Bar; end"
end
gemfile <<-G
source "file://#{gem_repo1}"
gem "foo"
gem "bar", "1.0", :path => "#{relative_path}"
G
bundle "install --path vendor/bundle"
bundle :clean, :exitstatus => true
expect(exitstatus).to eq(0)
end
it "doesn't remove gems in dry-run mode" do
gemfile <<-G
source "file://#{gem_repo1}"
gem "thin"
gem "foo"
G
bundle "install --path vendor/bundle --no-clean"
gemfile <<-G
source "file://#{gem_repo1}"
gem "thin"
G
bundle :install
bundle "clean --dry-run"
expect(out).not_to eq("Removing foo (1.0)")
expect(out).to eq("Would have removed foo (1.0)")
should_have_gems 'thin-1.0', 'rack-1.0.0', 'foo-1.0'
expect(vendored_gems("bin/rackup")).to exist
end
end
|