diff options
| author | FdaSilvaYY <fdasilvayy@gmail.com> | 2016-03-19 00:40:11 +0100 |
|---|---|---|
| committer | Matt Caswell <matt@openssl.org> | 2016-03-29 17:40:54 +0100 |
| commit | 1a50b8139a6221d65bc526ab415c77b0561ff708 (patch) | |
| tree | 90a4421c0a3a119dc3352b931030f4dccc085420 | |
| parent | bbe9769ba66ab2512678a87b0d9b266ba970db05 (diff) | |
| download | openssl-1a50b8139a6221d65bc526ab415c77b0561ff708.tar.gz | |
Fix a big leak when using stack-allocated BIO items.
Reviewed-by: Richard Levitte <levitte@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
| -rw-r--r-- | crypto/err/err_prn.c | 29 |
1 files changed, 12 insertions, 17 deletions
diff --git a/crypto/err/err_prn.c b/crypto/err/err_prn.c index ac6b81f80b..0f7d40c398 100644 --- a/crypto/err/err_prn.c +++ b/crypto/err/err_prn.c @@ -92,23 +92,6 @@ void ERR_print_errors_cb(int (*cb) (const char *str, size_t len, void *u), } } -#ifndef OPENSSL_NO_STDIO -static int print_fp(const char *str, size_t len, void *fp) -{ - BIO bio; - - BIO_set(&bio, BIO_s_file()); - BIO_set_fp(&bio, fp, BIO_NOCLOSE); - - return BIO_printf(&bio, "%s", str); -} - -void ERR_print_errors_fp(FILE *fp) -{ - ERR_print_errors_cb(print_fp, fp); -} -#endif - static int print_bio(const char *str, size_t len, void *bp) { return BIO_write((BIO *)bp, str, len); @@ -118,3 +101,15 @@ void ERR_print_errors(BIO *bp) { ERR_print_errors_cb(print_bio, bp); } + +#ifndef OPENSSL_NO_STDIO +void ERR_print_errors_fp(FILE *fp) +{ + BIO *bio = BIO_new_fp(fp, BIO_NOCLOSE); + if (bio == NULL) + return; + + ERR_print_errors_cb(print_bio, bio); + BIO_free(bio); +} +#endif |