diff options
| author | Richard Levitte <levitte@openssl.org> | 2017-05-11 12:52:47 +0200 |
|---|---|---|
| committer | Richard Levitte <levitte@openssl.org> | 2017-06-28 12:54:33 +0200 |
| commit | 8bd2c65fbb25c4d64c1fd098e02bdef40b3d9773 (patch) | |
| tree | 59b5ce4572dfd1742271aa3352a5b6774ac6df90 | |
| parent | 4f79affb05717243d3d041f3448156c35cabf0a2 (diff) | |
| download | openssl-8bd2c65fbb25c4d64c1fd098e02bdef40b3d9773.tar.gz | |
Comment on the lack of documentation for asymmetric ciphers
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/3744)
| -rw-r--r-- | crypto/engine/eng_devcrypto.c | 23 |
1 files changed, 22 insertions, 1 deletions
diff --git a/crypto/engine/eng_devcrypto.c b/crypto/engine/eng_devcrypto.c index ed3335e897..19781b8ab0 100644 --- a/crypto/engine/eng_devcrypto.c +++ b/crypto/engine/eng_devcrypto.c @@ -629,7 +629,28 @@ void engine_load_devcrypto_int() if (!ENGINE_set_id(e, "devcrypto") || !ENGINE_set_name(e, "/dev/crypto engine") || !ENGINE_set_destroy_function(e, devcrypto_unload) -#if 0 /* Not supported yet */ + +/* + * Asymmetric ciphers aren't well supported with /dev/crypto. Among the BSD + * implementations, it seems to only exist in FreeBSD, and regarding the + * parameters in its crypt_kop, the manual crypto(4) has this to say: + * + * The semantics of these arguments are currently undocumented. + * + * Reading through the FreeBSD source code doesn't give much more than + * their CRK_MOD_EXP implementation for ubsec. + * + * It doesn't look much better with cryptodev-linux. They have the crypt_kop + * structure as well as the command (CRK_*) in cryptodev.h, but no support + * seems to be implemented at all for the moment. + * + * At the time of writing, it seems impossible to write proper support for + * FreeBSD's asym features without some very deep knowledge and access to + * specific kernel modules. + * + * /Richard Levitte, 2017-05-11 + */ +#if 0 # ifndef OPENSSL_NO_RSA || !ENGINE_set_RSA(e, devcrypto_rsa) # endif |