aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRich Salz <rsalz@openssl.org>2015-04-11 16:53:27 +0200
committerKurt Roeckx <kurt@roeckx.be>2015-04-11 20:31:29 +0200
commita38537721dfdd853c40b4b4d99b57950075b0178 (patch)
tree185ae0376ec4c6edfd18bfaef7ecc94a38cafa95
parent8ec5c5dd361343d9017eff8547b19e86e4944ebc (diff)
downloadopenssl-a38537721dfdd853c40b4b4d99b57950075b0178.tar.gz
Fix memory leak
It should have freed them when != NULL, not when == NULL. Reviewed-by: Kurt Roeckx <kurt@roeckx.be> Reviewed-by: Viktor Dukhovni <openssl-users@dukhovni.org>
-rw-r--r--crypto/ec/ecp_smpl.c9
1 files changed, 3 insertions, 6 deletions
diff --git a/crypto/ec/ecp_smpl.c b/crypto/ec/ecp_smpl.c
index ee0c46841b..2d42d34f51 100644
--- a/crypto/ec/ecp_smpl.c
+++ b/crypto/ec/ecp_smpl.c
@@ -133,12 +133,9 @@ int ec_GFp_simple_group_init(EC_GROUP *group)
group->a = BN_new();
group->b = BN_new();
if (!group->field || !group->a || !group->b) {
- if (!group->field)
- BN_free(group->field);
- if (!group->a)
- BN_free(group->a);
- if (!group->b)
- BN_free(group->b);
+ BN_free(group->field);
+ BN_free(group->a);
+ BN_free(group->b);
return 0;
}
group->a_is_minus3 = 0;