diff options
| author | Pauli <ppzgs1@gmail.com> | 2021-03-18 13:04:21 +1000 |
|---|---|---|
| committer | Pauli <ppzgs1@gmail.com> | 2021-03-20 10:08:00 +1000 |
| commit | 77b8b49bdd01e2b1162b337941ebc70fef7030c1 (patch) | |
| tree | eee8cf03b30ed8fb6ac368638544492ac7f99437 /apps | |
| parent | bca681aa5b2539c1e50072a2034ef2f5414bb61c (diff) | |
| download | openssl-77b8b49bdd01e2b1162b337941ebc70fef7030c1.tar.gz | |
apps: fix Coverity 1472670 & 1472685: resource leaks
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/14596)
Diffstat (limited to 'apps')
| -rw-r--r-- | apps/ocsp.c | 10 |
1 files changed, 3 insertions, 7 deletions
diff --git a/apps/ocsp.c b/apps/ocsp.c index e77c90f041..bd509d98a7 100644 --- a/apps/ocsp.c +++ b/apps/ocsp.c @@ -241,14 +241,10 @@ int ocsp_main(int argc, char **argv) unsigned long sign_flags = 0, verify_flags = 0, rflags = 0; OPTION_CHOICE o; - reqnames = sk_OPENSSL_STRING_new_null(); - if (reqnames == NULL) + if ((reqnames = sk_OPENSSL_STRING_new_null()) == NULL + || (ids = sk_OCSP_CERTID_new_null()) == NULL + || (vpm = X509_VERIFY_PARAM_new()) == NULL) goto end; - ids = sk_OCSP_CERTID_new_null(); - if (ids == NULL) - goto end; - if ((vpm = X509_VERIFY_PARAM_new()) == NULL) - return 1; prog = opt_init(argc, argv, ocsp_options); while ((o = opt_next()) != OPT_EOF) { |