aboutsummaryrefslogtreecommitdiffstats
path: root/crypto/cms/cms_sd.c
diff options
context:
space:
mode:
authorPW Hu <jlu.hpw@foxmail.com>2021-11-10 12:39:54 +0800
committerTomas Mraz <tomas@openssl.org>2021-11-22 11:17:48 +0100
commit2349d7ba57c9327290df6f7bc18b7f0c3976ca9e (patch)
tree665b40724ec43bd912f90de936e06e4c890f9bdd /crypto/cms/cms_sd.c
parent615a9b8798e6ec58f1b2e1ec08a0f6b3c8cb7f60 (diff)
downloadopenssl-2349d7ba57c9327290df6f7bc18b7f0c3976ca9e.tar.gz
Fix the return check of OBJ_obj2txt
Also update OBJ_nid2obj.pod to document the possible return values. Reviewed-by: Paul Dale <pauli@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from https://github.com/openssl/openssl/pull/17005)
Diffstat (limited to 'crypto/cms/cms_sd.c')
-rw-r--r--crypto/cms/cms_sd.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/crypto/cms/cms_sd.c b/crypto/cms/cms_sd.c
index 4fbe09ca5f..34c021bba6 100644
--- a/crypto/cms/cms_sd.c
+++ b/crypto/cms/cms_sd.c
@@ -784,8 +784,8 @@ int CMS_SignerInfo_sign(CMS_SignerInfo *si)
const CMS_CTX *ctx = si->cms_ctx;
char md_name[OSSL_MAX_NAME_SIZE];
- if (!OBJ_obj2txt(md_name, sizeof(md_name),
- si->digestAlgorithm->algorithm, 0))
+ if (OBJ_obj2txt(md_name, sizeof(md_name),
+ si->digestAlgorithm->algorithm, 0) <= 0)
return 0;
if (CMS_signed_get_attr_by_NID(si, NID_pkcs9_signingTime, -1) < 0) {