aboutsummaryrefslogtreecommitdiffstats
path: root/crypto/ec/ec_check.c
diff options
context:
space:
mode:
authorNicola Tuveri <nic.tuv@gmail.com>2019-03-31 18:46:53 +0300
committerNicola Tuveri <nic.tuv@gmail.com>2019-04-11 12:05:38 +0300
commitac2b52c6ad0cd40482b1c5c1c4ec68eb16020ae8 (patch)
tree99deb44793f269cf4403551577a582584521a496 /crypto/ec/ec_check.c
parent8d4f150f70d70d6c3e62661ed7cc16c2f751d8a1 (diff)
downloadopenssl-ac2b52c6ad0cd40482b1c5c1c4ec68eb16020ae8.tar.gz
Separate the lookup test
This fixes the "verifying the alias" case. Actually, while working on it, I realized that conceptually we were testing the 2 different behaviours of `EC_GROUP_check_named_curve()` at the same time, and actually not in the proper way. I think it's fair to assume that overwriting the curve name for an existing group with `NID_undef` could lead to the unexpected behaviour we were observing and working around. Thus I decided to separate the lookup test in a dedicated simpler test that does what the documentation of `EC_GROUP_check_named_curve()` suggests: the lookup functionality is meant to find a name for a group generated with explicit parameters. In case an alternative alias is returned by the lookup instead of the expected nid, to avoid doing comparisons between `EC_GROUP`s with different `EC_METHOD`s, the workaround is to retrieve the `ECPARAMETERS` of the "alias group" and create a new explicit parameters group to use in `EC_GROUP_cmp()`. Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from https://github.com/openssl/openssl/pull/8555)
Diffstat (limited to 'crypto/ec/ec_check.c')
0 files changed, 0 insertions, 0 deletions