diff options
| author | Richard Levitte <levitte@openssl.org> | 2022-04-20 16:43:13 +0200 |
|---|---|---|
| committer | Richard Levitte <levitte@openssl.org> | 2022-05-05 15:05:54 +0200 |
| commit | 20b6d85ab2b9cfa4cd29d2422d69c3e3f4db0a41 (patch) | |
| tree | b36e80fcc6b3c399828112365c01f4c4f4b61706 /crypto/property | |
| parent | 802cacf34f2db9111becb4f0d3aa00460df13a19 (diff) | |
| download | openssl-20b6d85ab2b9cfa4cd29d2422d69c3e3f4db0a41.tar.gz | |
Drop ossl_provider_clear_all_operation_bits() and all uses of it
This is a misused function, as it was called during query cache flush,
when the provider operation bits were meant to record if methods for a
certain operation has already been added to the method store.
Fixes #18150
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/18151)
Diffstat (limited to 'crypto/property')
| -rw-r--r-- | crypto/property/property.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/crypto/property/property.c b/crypto/property/property.c index fd511d2e25..d0415a6c55 100644 --- a/crypto/property/property.c +++ b/crypto/property/property.c @@ -498,7 +498,6 @@ static void ossl_method_cache_flush(OSSL_METHOD_STORE *store, int nid) ALGORITHM *alg = ossl_method_store_retrieve(store, nid); if (alg != NULL) { - ossl_provider_clear_all_operation_bits(store->ctx); store->nelem -= lh_QUERY_num_items(alg->cache); impl_cache_flush_alg(0, alg, NULL); } @@ -510,7 +509,6 @@ int ossl_method_store_flush_cache(OSSL_METHOD_STORE *store, int all) if (!ossl_property_write_lock(store)) return 0; - ossl_provider_clear_all_operation_bits(store->ctx); ossl_sa_ALGORITHM_doall_arg(store->algs, &impl_cache_flush_alg, arg); store->nelem = 0; ossl_property_unlock(store); @@ -575,7 +573,6 @@ static void ossl_method_cache_flush_some(OSSL_METHOD_STORE *store) state.nelem = 0; if ((state.seed = OPENSSL_rdtsc()) == 0) state.seed = 1; - ossl_provider_clear_all_operation_bits(store->ctx); store->need_flush = 0; ossl_sa_ALGORITHM_doall_arg(store->algs, &impl_cache_flush_one_alg, &state); store->nelem = state.nelem; |