diff options
author | David Benjamin <davidben@google.com> | 2016-08-22 22:39:24 -0700 |
---|---|---|
committer | Matt Caswell <matt@openssl.org> | 2016-08-23 20:37:58 +0100 |
commit | 2338ad88859313922e3a861e07aec441a90464de (patch) | |
tree | 7919eeff62d51a8f4e2baf70a78f4a1dd748acaf /crypto | |
parent | fa515410aae2cf4ced2cf41cc6715fee6c6db344 (diff) | |
download | openssl-2338ad88859313922e3a861e07aec441a90464de.tar.gz |
Fix math in BN_bn2dec comment.
The bound on log(2)/3 on the second line is incorrect and has an extra
zero compared to the divisions in the third line. log(2)/3 = 0.10034...
which is bounded by 0.101 and not 0.1001. The divisions actually
correspond to 0.101 which is fine. The third line also dropped a factor
of three.
The actual code appears to be fine. Just the comments are wrong.
Reviewed-by: Rich Salz <rsalz@openssl.org>
Reviewed-by: Matt Caswell <matt@openssl.org>
Diffstat (limited to 'crypto')
-rw-r--r-- | crypto/bn/bn_print.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/crypto/bn/bn_print.c b/crypto/bn/bn_print.c index e5f641b99d..39fb03412e 100644 --- a/crypto/bn/bn_print.c +++ b/crypto/bn/bn_print.c @@ -67,8 +67,8 @@ char *BN_bn2dec(const BIGNUM *a) /*- * get an upper bound for the length of the decimal integer * num <= (BN_num_bits(a) + 1) * log(2) - * <= 3 * BN_num_bits(a) * 0.1001 + log(2) + 1 (rounding error) - * <= BN_num_bits(a)/10 + BN_num_bits/1000 + 1 + 1 + * <= 3 * BN_num_bits(a) * 0.101 + log(2) + 1 (rounding error) + * <= 3 * BN_num_bits(a) / 10 + 3 * BN_num_bits / 1000 + 1 + 1 */ i = BN_num_bits(a) * 3; num = (i / 10 + i / 1000 + 1) + 1; |