diff options
| author | rhe <rhe@ruby-lang.org> | 2016-05-24 13:09:03 +0000 |
|---|---|---|
| committer | Kazuki Yamaguchi <k@rhe.jp> | 2016-05-31 11:31:27 +0900 |
| commit | f8eec6b558675eb8cedccdd904e833ed77151b42 (patch) | |
| tree | c959fbf455121c5000ee23aa39646cc7b3742b1c /test | |
| parent | 5783408e86d4dd145e3263669f54f7269e00c500 (diff) | |
| download | ruby-openssl-f8eec6b558675eb8cedccdd904e833ed77151b42.tar.gz | |
openssl: make Cipher#key= and #iv= reject too long values
* ext/openssl/ossl_cipher.c (ossl_cipher_set_key, ossl_cipher_set_iv):
Reject too long values as well as too short ones. Currently they
just truncate the input but this would hide bugs and lead to
unexpected encryption/decryption results.
* test/openssl/test_cipher.rb: Test that Cipher#key= and #iv= reject
Strings with invalid length.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@55146 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'test')
| -rw-r--r-- | test/test_cipher.rb | 12 |
1 files changed, 12 insertions, 0 deletions
diff --git a/test/test_cipher.rb b/test/test_cipher.rb index dab64aa5..aec33fdd 100644 --- a/test/test_cipher.rb +++ b/test/test_cipher.rb @@ -80,6 +80,18 @@ class OpenSSL::TestCipher < OpenSSL::TestCase assert_equal(s1, s2, "encrypt reset") end + def test_key_iv_set + # default value for DES-EDE3-CBC + assert_equal(24, @c1.key_len) + assert_equal(8, @c1.iv_len) + assert_raise(ArgumentError) { @c1.key = "\x01" * 23 } + @c1.key = "\x01" * 24 + assert_raise(ArgumentError) { @c1.key = "\x01" * 25 } + assert_raise(ArgumentError) { @c1.iv = "\x01" * 7 } + @c1.iv = "\x01" * 8 + assert_raise(ArgumentError) { @c1.iv = "\x01" * 9 } + end + def test_empty_data @c1.encrypt assert_raise(ArgumentError){ @c1.update("") } |