diff options
author | Charles Oliver Nutter <headius@headius.com> | 2020-06-01 00:48:41 -0500 |
---|---|---|
committer | Hiroshi SHIBATA <hsbt@ruby-lang.org> | 2020-09-24 21:21:38 +0900 |
commit | 46ba416a1fa0973b56146077a654d68779c2497b (patch) | |
tree | ce80b9a48d23140dfc303e51414d0ccccc8f9b60 | |
parent | 0c611d7f4fce67c64bee4815f263c55ef15561c4 (diff) | |
download | ruby-46ba416a1fa0973b56146077a654d68779c2497b.tar.gz |
[ruby/webrick] Skip env-locale-sensitive CGI test on the "java" platform
JRuby's environment variables are provided by the Java Development
Kit's (JDK's) classes, which present them as a map from string to
string. In order to do this, those environment variable names and
values must be decoded into characters, which breaks any variables
that are intended to be "raw" bytes not necessarily decodable with
the default system encoding.
This issue is detailed in jruby/jruby#6248. The only solution on
the JRuby side will be to bypass the JDK environment variable API
and go directly to the native getenv/setenv system calls. This is
not likely to happen in the near future, due to the complexity of
such a change and the rarity of undecodable environment values.
The exclude here was added due to the Windows platform also having
a similar sensitivity to character encodings when working with
environment variables. It seems appropriate to expand this skip
to the "java" platform, as the root issue is largely the same.
https://github.com/ruby/webrick/commit/dc453e5c3c
-rw-r--r-- | test/webrick/test_cgi.rb | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/test/webrick/test_cgi.rb b/test/webrick/test_cgi.rb index 764c63f325..7a75cf565e 100644 --- a/test/webrick/test_cgi.rb +++ b/test/webrick/test_cgi.rb @@ -43,7 +43,7 @@ class TestWEBrickCGI < Test::Unit::TestCase http.request(req){|res| assert_equal("/path/info", res.body, log.call)} req = Net::HTTP::Get.new("/webrick.cgi/%3F%3F%3F?foo=bar") http.request(req){|res| assert_equal("/???", res.body, log.call)} - unless RUBY_PLATFORM =~ /mswin|mingw|cygwin|bccwin32/ + unless RUBY_PLATFORM =~ /mswin|mingw|cygwin|bccwin32|java/ # Path info of res.body is passed via ENV. # ENV[] returns different value on Windows depending on locale. req = Net::HTTP::Get.new("/webrick.cgi/%A4%DB%A4%B2/%A4%DB%A4%B2") |