diff options
author | Hiroshi SHIBATA <hsbt@ruby-lang.org> | 2023-03-16 13:35:34 +0900 |
---|---|---|
committer | Hiroshi SHIBATA <hsbt@ruby-lang.org> | 2023-03-17 18:50:55 +0900 |
commit | 52ea7afa5f33d1a586866e0f12ede3b4a2a083e8 (patch) | |
tree | fff48f1513c01a8fa811e8fbb959d30b7372b807 | |
parent | 9ab860f9afd6033d5fbf1cadd90c6e3aea396ee4 (diff) | |
download | ruby-52ea7afa5f33d1a586866e0f12ede3b4a2a083e8.tar.gz |
[rubygems/rubygems] util/rubocop -A --only Style/NegatedIf
https://github.com/rubygems/rubygems/commit/aa95ee27a2
-rw-r--r-- | lib/rubygems/commands/cert_command.rb | 2 | ||||
-rw-r--r-- | lib/rubygems/query_utils.rb | 2 | ||||
-rw-r--r-- | lib/rubygems/source.rb | 4 | ||||
-rw-r--r-- | lib/rubygems/specification.rb | 4 | ||||
-rw-r--r-- | lib/rubygems/specification_policy.rb | 6 | ||||
-rw-r--r-- | lib/rubygems/user_interaction.rb | 4 | ||||
-rw-r--r-- | test/rubygems/test_gem_requirement.rb | 2 |
7 files changed, 12 insertions, 12 deletions
diff --git a/lib/rubygems/commands/cert_command.rb b/lib/rubygems/commands/cert_command.rb index 391b1d94f7..e7fcfdca4e 100644 --- a/lib/rubygems/commands/cert_command.rb +++ b/lib/rubygems/commands/cert_command.rb @@ -135,7 +135,7 @@ class Gem::Commands::CertCommand < Gem::Command end def build(email) - if !valid_email?(email) + unless valid_email?(email) raise Gem::CommandLineError, "Invalid email address #{email}" end diff --git a/lib/rubygems/query_utils.rb b/lib/rubygems/query_utils.rb index c554bce480..2c09ef4e1a 100644 --- a/lib/rubygems/query_utils.rb +++ b/lib/rubygems/query_utils.rb @@ -84,7 +84,7 @@ module Gem::QueryUtils installed = !installed unless options[:installed] say(installed) - exit_code = 1 if !installed + exit_code = 1 unless installed end exit_code diff --git a/lib/rubygems/source.rb b/lib/rubygems/source.rb index aa0cbc1641..7c3a7534a8 100644 --- a/lib/rubygems/source.rb +++ b/lib/rubygems/source.rb @@ -44,12 +44,12 @@ class Gem::Source Gem::Source::Vendor then -1 when Gem::Source then - if !@uri + unless @uri return 0 unless other.uri return 1 end - return -1 if !other.uri + return -1 unless other.uri # Returning 1 here ensures that when sorting a list of sources, the # original ordering of sources supplied by the user is preserved. diff --git a/lib/rubygems/specification.rb b/lib/rubygems/specification.rb index 77984eb98f..7acdb5c52a 100644 --- a/lib/rubygems/specification.rb +++ b/lib/rubygems/specification.rb @@ -1616,8 +1616,8 @@ class Gem::Specification < Gem::BasicSpecification # we need to fresh build when same name and version of default gems return if self.class.find_by_full_name(full_name)&.default_gem? return if File.exist? gem_build_complete_path - return if !File.writable?(base_dir) - return if !File.exist?(File.join(base_dir, "extensions")) + return unless File.writable?(base_dir) + return unless File.exist?(File.join(base_dir, "extensions")) begin # We need to require things in $LOAD_PATH without looking for the diff --git a/lib/rubygems/specification_policy.rb b/lib/rubygems/specification_policy.rb index 03d7e92be5..765f57bfca 100644 --- a/lib/rubygems/specification_policy.rb +++ b/lib/rubygems/specification_policy.rb @@ -125,7 +125,7 @@ class Gem::SpecificationPolicy metadata.each do |key, value| entry = "metadata['#{key}']" - if !key.is_a?(String) + unless key.is_a?(String) error "metadata keys must be a String" end @@ -133,7 +133,7 @@ class Gem::SpecificationPolicy error "metadata key is too large (#{key.size} > 128)" end - if !value.is_a?(String) + unless value.is_a?(String) error "#{entry} value must be a String" end @@ -368,7 +368,7 @@ duplicate dependency on #{dep}, (#{prev.requirement}) use: licenses = @specification.licenses licenses.each do |license| - if !Gem::Licenses.match?(license) + unless Gem::Licenses.match?(license) suggestions = Gem::Licenses.suggestions(license) message = <<-WARNING license value '#{license}' is invalid. Use a license identifier from diff --git a/lib/rubygems/user_interaction.rb b/lib/rubygems/user_interaction.rb index f22a24a718..502ccc4357 100644 --- a/lib/rubygems/user_interaction.rb +++ b/lib/rubygems/user_interaction.rb @@ -281,7 +281,7 @@ class Gem::StreamUI # Ask a question. Returns an answer if connected to a tty, nil otherwise. def ask(question) - return nil if !tty? + return nil unless tty? @outs.print(question + " ") @outs.flush @@ -295,7 +295,7 @@ class Gem::StreamUI # Ask for a password. Does not echo response to terminal. def ask_for_password(question) - return nil if !tty? + return nil unless tty? @outs.print(question, " ") @outs.flush diff --git a/test/rubygems/test_gem_requirement.rb b/test/rubygems/test_gem_requirement.rb index 130ea6297d..e3d87b1e5d 100644 --- a/test/rubygems/test_gem_requirement.rb +++ b/test/rubygems/test_gem_requirement.rb @@ -83,7 +83,7 @@ class TestGemRequirement < Gem::TestCase Gem::Requirement.parse(Gem::Version.new("2")) end - if !(Gem.java_platform? && ENV["JRUBY_OPTS"].to_s.include?("--debug")) + unless (Gem.java_platform? && ENV["JRUBY_OPTS"].to_s.include?("--debug")) def test_parse_deduplication assert_same "~>", Gem::Requirement.parse("~> 1").first end |