diff options
| author | Christian van Rensen <christian.van.rensen@tngtech.com> | 2022-07-28 18:29:19 +0200 |
|---|---|---|
| committer | git <svn-admin@ruby-lang.org> | 2023-10-30 09:27:06 +0000 |
| commit | f109269a0392940df2b314e16502c4509b94a290 (patch) | |
| tree | 78708cbe6fd14d240c44ea98e0e7eb66ae0a9d27 | |
| parent | f757a5d3ceb62a1f049f7060429b5b3bac6ad545 (diff) | |
| download | ruby-f109269a0392940df2b314e16502c4509b94a290.tar.gz | |
[ruby/net-http] fix a false-negative test
* no_proxy is meant to operate on the destination address, not on the name of the proxy
* if both end with `'.example'`, the test does not nail down the behaviour
https://github.com/ruby/net-http/commit/bb9a5cfa3d
| -rw-r--r-- | test/net/http/test_http.rb | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/test/net/http/test_http.rb b/test/net/http/test_http.rb index 0508645ac5..53092ee0e8 100644 --- a/test/net/http/test_http.rb +++ b/test/net/http/test_http.rb @@ -126,10 +126,10 @@ class TestNetHTTP < Test::Unit::TestCase def test_proxy_address_no_proxy TestNetHTTPUtils.clean_http_proxy_env do - http = Net::HTTP.new 'hostname.example', nil, 'proxy.example', nil, nil, nil, 'example' + http = Net::HTTP.new 'hostname.example', nil, 'proxy.com', nil, nil, nil, 'example' assert_nil http.proxy_address - http = Net::HTTP.new '10.224.1.1', nil, 'proxy.example', nil, nil, nil, 'example,10.224.0.0/22' + http = Net::HTTP.new '10.224.1.1', nil, 'proxy.com', nil, nil, nil, 'example,10.224.0.0/22' assert_nil http.proxy_address end end |