diff options
author | usa <usa@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2017-11-16 12:26:04 +0000 |
---|---|---|
committer | usa <usa@b2dd03c8-39d4-4d8f-98ff-823fe69b080e> | 2017-11-16 12:26:04 +0000 |
commit | d6d10679e03cd01652483eb45fa31410b42c808d (patch) | |
tree | 3186c316e275c0bf254c16edf5b5669742099fc1 /common.mk | |
parent | 9748bc2d5cb50b5d7297a9d86e82819c1a03720d (diff) | |
download | ruby-d6d10679e03cd01652483eb45fa31410b42c808d.tar.gz |
Old gem file had not been removed
* common.mk (update-gems): `old.delete("gems/#{gem}")` always returns nil
because when really downloading new gem, the filename is not in `old`.
the real intention of this condition might be checking `old` is empty or not.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@60813 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
Diffstat (limited to 'common.mk')
-rw-r--r-- | common.mk | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -1134,7 +1134,7 @@ update-gems: PHONY -e 'old = Dir.glob("gems/#{gem}-*.gem")' \ -e 'gem = "#{gem}-#{ver}.gem"' \ -e 'Downloader::RubyGems.download(gem, "gems", nil) and' \ - -e 'old.delete("gems/#{gem}") and' \ + -e '(old.delete("gems/#{gem}"); !old.empty?) and' \ -e 'File.unlink(*old) and' \ -e 'FileUtils.rm_rf(old.map{'"|n|"'n.chomp(".gem")})' \ gems/bundled_gems |