diff options
| author | Kazuki Yamaguchi <k@rhe.jp> | 2017-10-01 15:02:54 +0900 |
|---|---|---|
| committer | Kazuki Yamaguchi <k@rhe.jp> | 2017-10-06 08:47:40 +0000 |
| commit | 7ca6ca4e96a93f9c23fc54320f5ff8e4ff044c8f (patch) | |
| tree | 05b351fb0ad0af1a44df8ebf43f8bcbb80f559fa /ext/sdbm/init.c | |
| parent | 0ee8bb4c2a35d81dacf27be5fc42706aa891f33f (diff) | |
| download | ruby-7ca6ca4e96a93f9c23fc54320f5ff8e4ff044c8f.tar.gz | |
gdbm, dbm, sdbm: prevent possible leak in #initialize
Allocate struct dbmdata before opening a file in case of out of memory.
As a bonus, make ext/dbm and ext/sdbm close the currently open file if
any, as ext/gdbm is doing.
Diffstat (limited to 'ext/sdbm/init.c')
| -rw-r--r-- | ext/sdbm/init.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/ext/sdbm/init.c b/ext/sdbm/init.c index 684f31b98f..de99b07367 100644 --- a/ext/sdbm/init.c +++ b/ext/sdbm/init.c @@ -79,7 +79,6 @@ closed_sdbm(void) #define GetDBM(obj, dbmp) do {\ TypedData_Get_Struct((obj), struct dbmdata, &sdbm_type, (dbmp));\ - if ((dbmp) == 0) closed_sdbm();\ if ((dbmp)->di_dbm == 0) closed_sdbm();\ } while (0) @@ -148,8 +147,6 @@ fsdbm_closed(VALUE obj) struct dbmdata *dbmp; TypedData_Get_Struct(obj, struct dbmdata, &sdbm_type, dbmp); - if (dbmp == 0) - return Qtrue; if (dbmp->di_dbm == 0) return Qtrue; @@ -159,7 +156,9 @@ fsdbm_closed(VALUE obj) static VALUE fsdbm_alloc(VALUE klass) { - return TypedData_Wrap_Struct(klass, &sdbm_type, 0); + struct dbmdata *dbmp; + + return TypedData_Make_Struct(klass, struct dbmdata, &sdbm_type, dbmp); } /* * call-seq: @@ -184,6 +183,7 @@ fsdbm_initialize(int argc, VALUE *argv, VALUE obj) struct dbmdata *dbmp; int mode; + TypedData_Get_Struct(obj, struct dbmdata, &sdbm_type, dbmp); if (rb_scan_args(argc, argv, "11", &file, &vmode) == 1) { mode = 0666; /* default value */ } @@ -208,8 +208,8 @@ fsdbm_initialize(int argc, VALUE *argv, VALUE obj) rb_sys_fail_str(file); } - dbmp = ALLOC(struct dbmdata); - DATA_PTR(obj) = dbmp; + if (dbmp->di_dbm) + sdbm_close(dbmp->di_dbm); dbmp->di_dbm = dbm; dbmp->di_size = -1; |